You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Slideee (via GitHub)" <gi...@apache.org> on 2023/02/22 05:48:27 UTC

[GitHub] [rocketmq-client-go] Slideee commented on a diff in pull request #1000: [ISSUE #999]support admin topicList and groupList method

Slideee commented on code in PR #1000:
URL: https://github.com/apache/rocketmq-client-go/pull/1000#discussion_r1113863715


##########
admin/admin.go:
##########
@@ -34,7 +34,8 @@ type Admin interface {
 	CreateTopic(ctx context.Context, opts ...OptionCreate) error
 	DeleteTopic(ctx context.Context, opts ...OptionDelete) error
 	//TODO
-	//TopicList(ctx context.Context, mq *primitive.MessageQueue) (*remote.RemotingCommand, error)
+	GroupList(ctx context.Context, brokerAddr string) (*remote.RemotingCommand, error)
+	TopicList(ctx context.Context) (*remote.RemotingCommand, error)

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org