You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/06/11 08:50:51 UTC

[kudu-CR] [tserver] Move cell size checking to prepare phase

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 )

Change subject: [tserver] Move cell size checking to prepare phase
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> Does this change user-facing behavior? Previously, if there were a too-large cell in a batch with other valid rows, would the other rows succeed (and the error get reported as a per-row error?)

Yes, the whole operation will fail if any row's cell size is too large.


-- 
To view, visit http://gerrit.cloudera.org:8080/13470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c
Gerrit-Change-Number: 13470
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 11 Jun 2019 08:50:51 +0000
Gerrit-HasComments: No