You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "tooo-bad (via GitHub)" <gi...@apache.org> on 2023/11/01 06:28:12 UTC
[PR] [ISSUE #3902] Do some code optimization.[NetUtils] (eventmesh)
tooo-bad opened a new pull request, #4528:
URL: https://github.com/apache/eventmesh/pull/4528
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3902
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3902] Do some code optimization.[NetUtils] (eventmesh)
Posted by "tooo-bad (via GitHub)" <gi...@apache.org>.
tooo-bad commented on PR #4528:
URL: https://github.com/apache/eventmesh/pull/4528#issuecomment-1790468176
> There is an error report in CI, but it is not your fault. It seems to be caused by detecting SSRF security issues in
>
> https://github.com/apache/eventmesh/blob/40a2aea812e75895e70e42be99c3736bcfcb10b1/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/WebhookUtil.java#L58
>
> .
> If you are willing, you can try a simple approach, such as verifying that the `targetUrl` must be in the http and https protocols first, or prohibiting redirection with a response code of `30x`, or other more effective ways to eliminate SSRF security issues. Thank you.
> You can also refuse my suggestion, and after you reply to me, I will also approve this PR.
Sorry, I don't know how to solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3902] Do some code optimization.[NetUtils] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4528:
URL: https://github.com/apache/eventmesh/pull/4528#issuecomment-1788567418
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4528?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4528](https://app.codecov.io/gh/apache/eventmesh/pull/4528?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a5ce481) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/2bfc1ae801f17e761c8cb1c8982410f11f65d3cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2bfc1ae) will **decrease** coverage by `0.02%`.
> Report is 4 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head a5ce481 differs from pull request most recent head 59ee2d7. Consider uploading reports for the commit 59ee2d7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4528 +/- ##
============================================
- Coverage 16.09% 16.08% -0.02%
Complexity 1550 1550
============================================
Files 730 730
Lines 28640 28635 -5
Branches 2523 2521 -2
============================================
- Hits 4611 4607 -4
+ Misses 23581 23578 -3
- Partials 448 450 +2
```
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/eventmesh/common/utils/NetUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9OZXRVdGlscy5qYXZh) | `80.00% <ø> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4528/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3902] Do some code optimization.[NetUtils] (eventmesh)
Posted by "tooo-bad (via GitHub)" <gi...@apache.org>.
tooo-bad commented on PR #4528:
URL: https://github.com/apache/eventmesh/pull/4528#issuecomment-1788514311
> @tooo-bad Please fix code style
I have made the changes again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3902] Do some code optimization.[NetUtils] (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4528:
URL: https://github.com/apache/eventmesh/pull/4528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org