[jira] [Commented] (HADOOP-11032) Replace use of Guava Stopwatch with Apache StopWatch

["Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117043#comment-14117043 ] 

Tsuyoshi OZAWA commented on HADOOP-11032:
-----------------------------------------

Thanks for updating patch, Gary. Some of these test failures are related to our work - Apache StopWatch#stop() raises IllegalStateException if we call the method twice. I'll update it to fix.

{quote}
java.lang.IllegalStateException: Stopwatch is not running. 
	at org.apache.commons.lang.time.StopWatch.stop(StopWatch.java:142)
	at org.apache.hadoop.util.TestDataChecksum.commonUsagePerfTest(TestDataChecksum.java:160)
{quote}

> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
>                 Key: HADOOP-11032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11032
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Gary Steelman
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm working on use v17. 
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we can use the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which provides nearly equivalent functionality. apache.commons.lang is already a dependency for Hadoop so this will not introduce new dependencies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)