You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 12:20:51 UTC
[jira] [Created] (BOOKKEEPER-114) add a shutdown hook to shut down
bookie server safely.
add a shutdown hook to shut down bookie server safely.
------------------------------------------------------
Key: BOOKKEEPER-114
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
Project: Bookkeeper
Issue Type: Improvement
Affects Versions: 4.0.0
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.0.0
Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-114) add a shutdown hook to shut down
bookie server safely.
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-114:
---------------------------------
Attachment: BOOKKEEPER-114.patch
Attach a patch to add a shutdown hook, which can shut down bookie server safely in following case:
- the JVM is terminated. e.g. CTRL-C, kill -SIGTERM pid or kill pid
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut
down bookie server safely.
Posted by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152921#comment-13152921 ]
Sijie Guo commented on BOOKKEEPER-114:
--------------------------------------
since Entry log files use BufferedChannel, a non-clean shutdown will corrupt them, as comments in [BOOKKEEPER-82|https://issues.apache.org/jira/browse/BOOKKEEPER-82?focusedCommentId=13147692&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13147692] . And we also add some documents in BOOKKEEPER-109 describing data flush during shutting down.
And bookie server can't start when encountering corrupted entries, as described in BOOKKEEPER-62 .
I think for now it is better to avoid such corruption first, since we don't have a clear solution in BOOKKEEPER-62 .
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut
down bookie server safely.
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152884#comment-13152884 ]
Ivan Kelly commented on BOOKKEEPER-114:
---------------------------------------
While this change is good, a non-clean shutdown shouldn't corrupt data unrecoverably. If it does, then there's a pretty serious bug. This is the reason that we have a journal, so we should be able to handle it.
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut
down bookie server safely.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153062#comment-13153062 ]
Hudson commented on BOOKKEEPER-114:
-----------------------------------
Integrated in bookkeeper-trunk #231 (See [https://builds.apache.org/job/bookkeeper-trunk/231/])
BOOKKEEPER-114: add a shutdown hook to shut down bookie server safely. (Sijie via ivank)
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut
down bookie server safely.
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152986#comment-13152986 ]
Ivan Kelly commented on BOOKKEEPER-114:
---------------------------------------
Ah, I hadn't seen BOOKKEEPER-62. Will comment on that, as it's more relevant to the issue.
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut
down bookie server safely.
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153045#comment-13153045 ]
Ivan Kelly commented on BOOKKEEPER-114:
---------------------------------------
Committed as r1203790
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-114) add a shutdown hook to shut down
bookie server safely.
Posted by "Flavio Junqueira (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-114:
----------------------------------------
Priority: Blocker (was: Major)
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-114
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted.
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira