You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:14:32 UTC

[GitHub] [pulsar] TakaHiro0208 commented on pull request #15217: [fix][broker] Fix update topic partitions failed

TakaHiro0208 commented on PR #15217:
URL: https://github.com/apache/pulsar/pull/15217#issuecomment-1102572024

   > @TakaHiro0208 I think the proper way is, `createSubscriptions` should be called after `updatePartitionedTopicAsync` successfully.
   
   Yep, this can also solve the problem and remove redundant code, I can revise the committed code following this. But, there would be a situation: after successful  `updatePartitionedTopicAsync` and failed `createSubscriptions`, we would still get newPartitions by getPartitionedTopicMetadata.  Does it matter??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org