You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Patrick Linehan (JIRA)" <ji...@apache.org> on 2010/11/17 06:34:13 UTC
[jira] Created: (AVRO-696) DataFileWriter.setMetaInternal(String
key, String value) should be private.
DataFileWriter.setMetaInternal(String key, String value) should be private.
---------------------------------------------------------------------------
Key: AVRO-696
URL: https://issues.apache.org/jira/browse/AVRO-696
Project: Avro
Issue Type: Bug
Components: java
Reporter: Patrick Linehan
This method bypasses the checks for reserved Avro metadata keys, so it should be private (or at least default-visible).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-696) DataFileWriter.setMetaInternal(String
key, String value) should be private.
Posted by "Patrick Linehan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Linehan updated AVRO-696:
---------------------------------
Status: Open (was: Patch Available)
> DataFileWriter.setMetaInternal(String key, String value) should be private.
> ---------------------------------------------------------------------------
>
> Key: AVRO-696
> URL: https://issues.apache.org/jira/browse/AVRO-696
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Patrick Linehan
>
> This method bypasses the checks for reserved Avro metadata keys, so it should be private (or at least default-visible).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-696) DataFileWriter.setMetaInternal(String
key, String value) should be private.
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved AVRO-696.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
Assignee: Patrick Linehan
Hadoop Flags: [Incompatible change, Reviewed]
I just committed this. Thanks, Patrick!
> DataFileWriter.setMetaInternal(String key, String value) should be private.
> ---------------------------------------------------------------------------
>
> Key: AVRO-696
> URL: https://issues.apache.org/jira/browse/AVRO-696
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Patrick Linehan
> Assignee: Patrick Linehan
> Fix For: 1.5.0
>
> Attachments: AVRO-696.patch
>
>
> This method bypasses the checks for reserved Avro metadata keys, so it should be private (or at least default-visible).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-696) DataFileWriter.setMetaInternal(String
key, String value) should be private.
Posted by "Patrick Linehan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Linehan updated AVRO-696:
---------------------------------
Attachment: AVRO-696.patch
Attaching the trivial patch.
The only issue with this patch is that it is a backward-incompatible change.
> DataFileWriter.setMetaInternal(String key, String value) should be private.
> ---------------------------------------------------------------------------
>
> Key: AVRO-696
> URL: https://issues.apache.org/jira/browse/AVRO-696
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Patrick Linehan
> Attachments: AVRO-696.patch
>
>
> This method bypasses the checks for reserved Avro metadata keys, so it should be private (or at least default-visible).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-696) DataFileWriter.setMetaInternal(String
key, String value) should be private.
Posted by "Patrick Linehan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Linehan updated AVRO-696:
---------------------------------
Status: Patch Available (was: Open)
> DataFileWriter.setMetaInternal(String key, String value) should be private.
> ---------------------------------------------------------------------------
>
> Key: AVRO-696
> URL: https://issues.apache.org/jira/browse/AVRO-696
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Patrick Linehan
>
> This method bypasses the checks for reserved Avro metadata keys, so it should be private (or at least default-visible).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.