You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "yumengwang03 (via GitHub)" <gi...@apache.org> on 2023/01/29 11:22:25 UTC
[GitHub] [incubator-devlake] yumengwang03 opened a new pull request, #4261: Fixed Image Licenses
yumengwang03 opened a new pull request, #4261:
URL: https://github.com/apache/incubator-devlake/pull/4261
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
This PR fixed all the license issues of the images:
1. Added Apache 2.0 license to all of the icons we have drawn;
2. Added the license info for the icons we have used from the library Feather Icons (MIT license);
3. Removed all illustrations from ManyPixels, whose license is incompatible with Apache 2.0. We will find illustrations with a more suitable license in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] yumengwang03 commented on a diff in pull request #4261: Fixed Image Licenses
Posted by "yumengwang03 (via GitHub)" <gi...@apache.org>.
yumengwang03 commented on code in PR #4261:
URL: https://github.com/apache/incubator-devlake/pull/4261#discussion_r1090326353
##########
LICENSE:
##########
@@ -202,55 +202,28 @@
--------------------------------------------------------------------------------
-config-ui/src/images/help.svg - Apache License, Version 2.0
+Some icons in Config UI are using Feather Icons with the MIT license.
Review Comment:
Yes, I just fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] WillemJiang commented on a diff in pull request #4261: Fixed Image Licenses
Posted by "WillemJiang (via GitHub)" <gi...@apache.org>.
WillemJiang commented on code in PR #4261:
URL: https://github.com/apache/incubator-devlake/pull/4261#discussion_r1090253244
##########
LICENSE:
##########
@@ -202,55 +202,28 @@
--------------------------------------------------------------------------------
-config-ui/src/images/help.svg - Apache License, Version 2.0
+Some icons in Config UI are using Feather Icons with the MIT license.
Review Comment:
Can we add the Icons file list here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #4261: Fixed Image Licenses
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #4261:
URL: https://github.com/apache/incubator-devlake/pull/4261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org