You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/03 09:59:22 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #530: Also check Scala 3 artifacts in MiMa
mdedetrich opened a new pull request, #530:
URL: https://github.com/apache/incubator-pekko/pull/530
While MiMa may not have worked on really early versions of Scala 3, its reported to be working fine with Scala 3.3 and I can also confirm this when adding MiMa to pekko-streams-circe (see https://github.com/mdedetrich/pekko-streams-circe/pull/13)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#issuecomment-1663712672
this doesn't resolve #493 because it doesn't enable a CI check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282999538
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -30,11 +30,11 @@ jobs:
# we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
fetch-depth: 0
- - name: Setup Java 11
+ - name: Setup Java 8
uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 11
+ java-version: 8
Review Comment:
Ah right, I got this mixed up with other repos, let me revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1283025080
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -30,11 +30,11 @@ jobs:
# we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
fetch-depth: 0
- - name: Setup Java 11
+ - name: Setup Java 8
Review Comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282999008
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -43,11 +38,11 @@ jobs:
run: cp .jvmopts-ci .jvmopts
- name: Compile code
- run: sbt "+~ ${{ matrix.scalaVersion }} Test/compile"
Review Comment:
There is no reason to also compile `Test` scope, the point of this github check is to validate binary compatibility issues and this is never done against test code. There are other github workflows which check that the code generally compiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#issuecomment-1663714064
> this doesn't resolve #493 because it doesn't enable a CI check
Thanks, if this works I will update PR to add check to CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#issuecomment-1663704954
part of https://github.com/apache/incubator-pekko/issues/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#issuecomment-1663706130
> part of #493
Thanks, added to resolves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282997946
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -18,23 +18,18 @@ jobs:
if: github.repository == 'apache/incubator-pekko'
strategy:
fail-fast: false
- matrix:
Review Comment:
matrix no longer needed, we test for all supported scala versions using sbt's `+`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282994978
##########
project/plugins.sbt:
##########
@@ -16,7 +16,7 @@ addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.33")
// sbt-osgi 0.9.5 is available but breaks including jdk9-only classes
// sbt-osgi 0.9.6 is available but breaks populating pekko-protobuf-v3
addSbtPlugin("com.typesafe.sbt" % "sbt-osgi" % "0.9.4")
-addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1")
Review Comment:
This old version of sbt-mima is why it wasn't correctly resolving Scala 3 artifacts, this has since been resolved in latest MiMA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282994076
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -30,11 +30,11 @@ jobs:
# we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
fetch-depth: 0
- - name: Setup Java 11
+ - name: Setup Java 8
Review Comment:
Just to be safe lets check MiMa with Java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282995495
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -30,11 +30,11 @@ jobs:
# we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
fetch-depth: 0
- - name: Setup Java 11
+ - name: Setup Java 8
uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 11
+ java-version: 8
Review Comment:
our release process for this repo requires Java 11 for the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282999008
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -43,11 +38,11 @@ jobs:
run: cp .jvmopts-ci .jvmopts
- name: Compile code
- run: sbt "+~ ${{ matrix.scalaVersion }} Test/compile"
Review Comment:
There is no reason to also compile `Test` scope, the point of this github check is to validate binary compatibility issues and this is never done against test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #530: Also check Scala 3 artifacts in MiMa
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #530:
URL: https://github.com/apache/incubator-pekko/pull/530#discussion_r1282997946
##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -18,23 +18,18 @@ jobs:
if: github.repository == 'apache/incubator-pekko'
strategy:
fail-fast: false
- matrix:
Review Comment:
matrix no longer needed, we test for all supported scala versions using `+`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org