You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "applike-ss (via GitHub)" <gi...@apache.org> on 2025/11/17 09:28:00 UTC

[I] Kubernetes Overlord Extension: Make peon job container name flexible (druid)

applike-ss opened a new issue, #18747:
URL: https://github.com/apache/druid/issues/18747

   ### Description
   I would like to be able to configure the container name for the pod template that I supply.
   
   Currently druids overlord extension is not consistent in this regard.
   Some occasions (assind side-car termination support) expect the first container in the spec to be the druid main container.
   In other places it is hardcoded to "main".
   Maybe this could be implemented more flexible by allowing to specify `druid.indexer.runner.k8s.druidContainerName.xyz=my-container-name` when `xyz` is the selection key for the `customTemplateAdapter`.
   
   With this additional configuration the whole configuration looks a bit strange to me though.
   So I'd suggest a different configuration structure, but I don't know how this might complicate the code unnecessarily.
   Say I had 2 pod templates next to the base template, then I'd suggest this structure:
   ```properties
   druid.indexer.runner.k8s.adapter.type=customTemplateAdapter
   druid.indexer.runner.k8s.podTemplate.base.filename: /druid/pod-templates/base.yaml
   druid.indexer.runner.k8s.podTemplate.base.druidContainerName: main
   druid.indexer.runner.k8s.podTemplate.x.filename: /druid/pod-templates/x.yaml
   druid.indexer.runner.k8s.podTemplate.x.druidContainerName: my-druid-container-name
   druid.indexer.runner.k8s.podTemplate.y.filename: /druid/pod-templates/y.yaml
   druid.indexer.runner.k8s.podTemplate.y.druidContainerName: my-other-druid-container-name
   ```
   
   
   ### Motivation
   
   For logging this is one of multiple indicators for me to route logs to certain sinks.
   
   "main" as the container name is simply too generic here for my purpose.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Kubernetes Overlord Extension: Make peon job container name flexible (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18747:
URL: https://github.com/apache/druid/issues/18747#issuecomment-5433274184

   This issue has been marked as stale due to 280 days of inactivity.
   It will be closed in 4 weeks if no further activity occurs. If this issue is still
   relevant, please simply write any comment. Even if closed, you can still revive the
   issue at any time or discuss it on the dev@druid.apache.org list.
   Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Kubernetes Overlord Extension: Make peon job container name flexible (druid)

Posted by "applike-ss (via GitHub)" <gi...@apache.org>.
applike-ss closed issue #18747: Kubernetes Overlord Extension: Make peon job container name flexible
URL: https://github.com/apache/druid/issues/18747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Kubernetes Overlord Extension: Make peon job container name flexible (druid)

Posted by "applike-ss (via GitHub)" <gi...@apache.org>.
applike-ss commented on issue #18747:
URL: https://github.com/apache/druid/issues/18747#issuecomment-3551155188

   In fact I would also like to be able to configure annotations on the K8s Job resource based on which pod template is chosen.
   
   Suggested implementation:
   
   ```
   druid.indexer.runner.k8s.podTemplate.base.jobAnnotations: {"foo":"bar"}
   druid.indexer.runner.k8s.podTemplate.x.jobAnnotations: {"bar":"baz"}
   druid.indexer.runner.k8s.podTemplate.y.jobAnnotations: {"baz":"buzz"}
   ```
   
   However I realize that having podTemplate as a prior part of the config name is somewhat confusing when it comes to what the jobAnnotations config would do.
   
   Maybe it makes sense to rename this somehow? No suggestions here from my side though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org