You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by "RKuttruff (via GitHub)" <gi...@apache.org> on 2023/09/18 14:24:02 UTC
[GitHub] [incubator-sdap-nexus] RKuttruff opened a new pull request, #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
RKuttruff opened a new pull request, #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279
We've been getting issues with Solr's polygon intersection search for certain tile shapes & bounding polys, so let's just use the more reliable bounding box search and mask out the extras.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
Posted by "ngachung (via GitHub)" <gi...@apache.org>.
ngachung commented on PR #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279#issuecomment-1723910807
Thanks Riley. I wonder if it's better to have the SolrProxy implementation switch polygon to bbox search versus forcing all metadata store implementation to only use bbox search?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] RKuttruff commented on a diff in pull request #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on code in PR #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279#discussion_r1329035523
##########
data-access/nexustiles/dao/SolrProxy.py:
##########
@@ -230,9 +230,16 @@ def find_tile_by_polygon_and_most_recent_day_of_year(self, bounding_polygon, ds,
search = 'dataset_s:%s' % ds
+ bounds = bounding_polygon.bounds
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung commented on a diff in pull request #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
Posted by "ngachung (via GitHub)" <gi...@apache.org>.
ngachung commented on code in PR #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279#discussion_r1329032194
##########
data-access/nexustiles/dao/SolrProxy.py:
##########
@@ -230,9 +230,16 @@ def find_tile_by_polygon_and_most_recent_day_of_year(self, bounding_polygon, ds,
search = 'dataset_s:%s' % ds
+ bounds = bounding_polygon.bounds
Review Comment:
For consistency, this can also be set as
`min_lon, min_lat, max_lon, max_lat = bounding_polygon.bounds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] RKuttruff commented on pull request #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on PR #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279#issuecomment-1723921414
@ngachung Probably. I'll switch it to there now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] RKuttruff merged pull request #279: SDAP-39 - Querying tiles by polygon now uses bbox query where possible
Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff merged PR #279:
URL: https://github.com/apache/incubator-sdap-nexus/pull/279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org