You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/10 17:20:13 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4458: Fix k8s cluster upgrade in shared networks
Pearl1594 opened a new pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458
## Description
Upgrade of kubernetes cluster reports as successful on a shared network, when it doesn't successfully upgrade the nodes
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Prior to the fix:
Deployed a 1.16.0 k8s cluster:
```
k8s-master ~ # kubectl get nodes
NAME STATUS ROLES AGE VERSION
k8s-master Ready,SchedulingDisabled master 6m23s v1.16.0
k8s-node-1 Ready <none> 5m51s v1.16.0
```
Upgraded the cluster to 1.16.3, though the upgradeKubernetesCluster API returns a successful response, it doesn't upgrade the worker nodes:
```
k8s-master ~ # kubectl get nodes
NAME STATUS ROLES AGE VERSION
k8s-master Ready master 8m35s v1.16.3
k8s-node-1 Ready <none> 8m3s v1.16.0
```
Post fix, once the upgrade completes i.e., when the upgradeKubernetesCluster API returns a success response, `kubectl get nodes` shows all nodes to be at the upgraded version, here, 1.16.3
```
c2-master ~ # kubectl get nodes
NAME STATUS ROLES AGE VERSION
c2-master Ready master 18m v1.16.0
c2-node-1 Ready <none> 18m v1.16.0
c2-master ~ # kubectl get nodes
NAME STATUS ROLES AGE VERSION
c2-master Ready,SchedulingDisabled master 19m v1.16.0
c2-node-1 Ready <none> 18m v1.16.0
...
c2-master ~ # kubectl get nodes
NAME STATUS ROLES AGE VERSION
c2-master Ready master 25m v1.16.3
c2-node-1 NotReady <none> 25m v1.16.3
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-729168100
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-729167513
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-724865321
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730191919
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-725192988
<b>Trillian test result (tid-3141)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33913 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4458-t3141-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesSupportedVersion>:setup | `Error` | 0.00 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730563661
<b>Trillian test result (tid-3208)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30505 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4458-t3208-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-729490917
Major issue in new functionality, @PaulAngus (IMNSHO). Do we accept this, still?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-724846866
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730043441
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730020710
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-724888807
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730017752
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-724846170
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-724889207
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-730191626
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-729493180
@DaanHoogland k8s cluster on shared network was present in 4.14 itself. IMO, this should be rebased to 4.14 and forward merge in master @Pearl1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4458: Fix k8s cluster upgrade in shared networks
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4458:
URL: https://github.com/apache/cloudstack/pull/4458#issuecomment-729452379
<b>Trillian test result (tid-3195)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34490 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4458-t3195-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 247.53 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org