You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/02/28 11:05:34 UTC

[GitHub] flink pull request #2946: [FLINK-5157] Extend AllWindow function metadata

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2946#discussion_r103425179
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java ---
    @@ -478,6 +581,135 @@ public AllWindowedStream(DataStream<T> input,
     		return input.transform(opName, resultType, operator).forceNonParallel();
     	}
     
    +	/**
    +	 * Applies the given window function to each window. The window function is called for each
    +	 * evaluation of the window for each key individually. The output of the window function is
    +	 * interpreted as a regular non-windowed stream.
    +	 *
    +	 * <p>Arriving data is incrementally aggregated using the given aggregate function. This means
    +	 * that the window function typically has only a single value to process when called.
    +	 *
    +	 * @param aggFunction The aggregate function that is used for incremental aggregation.
    +	 * @param windowFunction The process window function.
    +	 *
    +	 * @return The data stream that is the result of applying the window function to the window.
    +	 *
    +	 * @param <ACC> The type of the AggregateFunction's accumulator
    +	 * @param <V> The type of AggregateFunction's result, and the WindowFunction's input
    +	 * @param <R> The type of the elements in the resulting stream, equal to the
    +	 *            WindowFunction's result type
    +	 */
    +	public <ACC, V, R> SingleOutputStreamOperator<R> aggregate(
    --- End diff --
    
    These should also be `@PublicEvolving`. (I know that the corresponding methods on `WindowedStream` weren't marked like this due to an oversight on the implementers side.) No problem. \U0001f603 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---