You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/25 09:57:01 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #986: [KYUUBI #962] Support engine pool feature

yaooqinn commented on a change in pull request #986:
URL: https://github.com/apache/incubator-kyuubi/pull/986#discussion_r695594570



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ServiceDiscovery.scala
##########
@@ -257,6 +240,30 @@ object ServiceDiscovery extends Logging {
     }
     serviceNode
   }
+
+  def getEngineByPolicy(

Review comment:
       we don't need this, this has already been done at `Some("engine-pool-" + Random.nextInt(poolSize))`, we can use the old logic to get or create engine directly
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org