You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/11 10:09:37 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37117: [WIP][SPARK-39714][PYTHON] Try to fix the mypy annotation tests

HyukjinKwon commented on code in PR #37117:
URL: https://github.com/apache/spark/pull/37117#discussion_r917763897


##########
python/pyspark/pandas/series.py:
##########
@@ -4738,7 +4738,7 @@ def mode(self, dropna: bool = True) -> "Series":
         ser_count = self.value_counts(dropna=dropna, sort=False)
         sdf_count = ser_count._internal.spark_frame
         most_value = ser_count.max()
-        sdf_most_value = sdf_count.filter("count == {}".format(most_value))
+        sdf_most_value = sdf_count.filter("count == {}".format(most_value.__str__()))

Review Comment:
   ```suggestion
           sdf_most_value = sdf_count.filter("count == {}".format(str(most_value)))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org