[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5817: HDFS-17073. Enhance the warning message output for BlockGroupNonStripedChecksumComputer#compute"

["haiyang1987 (via GitHub)" <gi...@apache.org>]

haiyang1987 commented on code in PR #5817:
URL: https://github.com/apache/hadoop/pull/5817#discussion_r1257234652


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java:
##########
@@ -493,7 +493,8 @@ void compute() throws IOException {
               checksumBlock(block, idx, liveBlkInfo.getToken(),
                   liveBlkInfo.getDn());
             } catch (IOException ioe) {
-              LOG.warn("Exception while reading checksum", ioe);
+              LOG.warn("Exception while reading checksum for block {} at index {} " +
+                  "in blockGroup {}", block, idx, blockGroup, ioe);

Review Comment:
   Hi  @xinglin thanks help review it.
   thanks for the suggestion, I'll update later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org