[GitHub] nkalmar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

[GitBox <gi...@apache.org>]

nkalmar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size
URL: https://github.com/apache/zookeeper/pull/770#discussion_r251561774
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -873,6 +873,10 @@ public int getGlobalOutstandingLimit() {
         return limit;
     }
 
+    public static long getSnapSize() {
+        return Long.getLong("zookeeper.snapSize", 4294967296L); // 4GB by default
 
 Review comment:
   We should document this (probably in zookeeperAdmin.md).
   
   Maybe by default should be off with a special value like -1L? For backward compatibility reasons, but it doesn't really break anything... maybe just wait for a binding vote on this :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services