You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Eric Bresie <eb...@gmail.com> on 2020/12/30 19:48:31 UTC
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Agree this is very much a work in progress but still need help on resolving
these issues especially the licensing part of this.
I thought "donated" nbpython / contrib\*python* code (in the hg repository)
had licenses updated but assuming that may not be the case. What needs to
done to resolve these license problems?
(1) Does Oracle still have to scrub the files and update the licenses in
each file in some way? Or is what's in the hg repository good enough to
work with and make changed to align with Apache licensing needs?
(2) Does the "JYTHON" license need to be included in the codebase somewhere
for use in documenting the licenses used in some (i.e. jython) code context?
(3) What license should be used in each of these files? Assume there is
the original nbPython used licenses, then the "netbeans\contrib" used
licenses, and the "apache" licenses.
(4) Is there a tool to go through each file and update this in a batch
way? I seem to recall some form of "licensechanger" but not familiar with
how it works.
Is there
Eric Bresie
ebresie@gmail.com
On Wed, Dec 30, 2020 at 1:05 PM Geertjan Wielenga
<ge...@googlemail.com.invalid> wrote:
> I’d say it is a lot tol early to try to get this code into our GitHub.
>
> Gj
>
>
> On Wed, 30 Dec 2020 at 19:19, Eric Bresie <eb...@gmail.com> wrote:
>
> > There also seems to be failure on ergonomics tests like the below but I'm
> > not sure why this is happening. Maybe a failure elsewhere. Any ideas?
> >
> > [junit] WARNING [org.netbeans.TopSecurityManager]: use of system
> > property netbeans.home has been obsoleted in favor of
> > InstalledFileLocator/Places at
> >
> >
> org.netbeans.modules.ide.ergonomics.CommonServersBase.doGetAllInstancesErgo(CommonServersBase.java:90)
> > 10108 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > Iterating ergo
> > 10109 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > ergo: Amazon Beanstalk
> > 10110 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > Iteration done for ergo
> > *10111 [junit] Test
> > org.netbeans.modules.ide.ergonomics.DynamicVerifyTest FAILED*
> > 10112 [junit] Dec 30, 2020 5:38:14 PM
> > org.netbeans.core.startup.NbEvents logged
> > 10113 [junit] INFO: Warning - could not install some modules:
> > 10114 [junit] org.netbeans.modules.editor.lib2 - No module
> > providing the capability org.netbeans.modules.editor.actions could be
> > found.
> > 10115 [junit] org.netbeans.modules.editor.lib - The module
> > org.netbeans.modules.editor.lib2 would also need to be installed.
> >
> >
> > BUILD FAILED
> > 10234/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:723:
> > The following error occurred while executing this line:
> > 10235/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:716:
> > The following error occurred while executing this line:
> > 10236/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:750:
> > The following error occurred while executing this line:
> > 10237/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:747:
> > Some tests failed; see details above.
> > 10238
> > 10239Total time: 1 minute 24 seconds
> > 10240The command "ant $OPTS -f ergonomics/ide.ergonomics test
> > -Dtest.config=commit" exited with 1.
> >
> > Eric Bresie
> > ebresie@gmail.com
> >
> >
> > On Wed, Dec 30, 2020 at 12:03 PM Eric Bresie <eb...@gmail.com> wrote:
> >
> > > Okay after some synching with upstream and ovecoming some apparent
> github
> > > pr isms ...I have created a "draft PR" available at
> > > https://github.com/apache/netbeans/pull/2622
> > >
> > > However, it looks that some of the CI checks are failing as I kind of
> > > expected.
> > >
> > > Some seem to be related to licensing like the below.
> > >
> > > I assume some of this has to do with
> > > (1) Jython license details being missing,
> > > (2) Some "Oracle" licensing being present (assume this may be part of
> the
> > > donation process being worked), and some
> > > (3) Failure to document licenses in applicable locations
> > > (4) License formatting issues
> > >
> > > Can anyone familiar with handling licensing provide some input on how
> to
> > > handle these?
> > >
> > > Build licensing issues
> > > (1) This:
> > >
> > > verify-libs-and-licenses:
> > > 1226[verifylibsandlicenses]
> >
> /home/travis/build/apache/netbeans/nbbuild/build/verifylibsandlicenses.xml:
> > 3 failures out of 5 tests
> > > 1227
> > > 1228BUILD FAILED
> > > 1229/home/travis/build/apache/netbeans/nbbuild/build.xml:1642: Failed
> > VerifyLibsAndLicenses test(s):
> > > 1230Some binaries were found outside of <module>/external/ directories
> > (edit nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries as
> > needed)
> > >
> >
> 1231python/python.samples/src/org/netbeans/modules/python/samples/JySwingProject.zip
> > >
> >
> 1232python/python.samples/src/org/netbeans/modules/python/samples/PLYDemoProject.zip
> > >
> >
> 1233python/python.samples/src/org/netbeans/modules/python/samples/PyThreadsProject.zip
> > > 1234Some license files were badly formatted
> > > 1235python/o.jython.distro/external/jython-2.7.0-license.txt has a
> > trailing space on line #61
> > > 1236Some license files have incorrect headers
> > > 1237python/o.jython/external/jython-parser.jar does not appear to
> > include a version number
> > > 1238python/o.jython/external/jython-parser.jar is not associated with
> > any license file
> > > 1239python/o.jython.distro/external/jython-2.7.0-license.txt refers to
> > nonexistent nbbuild/licenses/Jython
> > > 1240python/python.editor/external/preindexed.zip does not appear to
> > include a version number
> > > 1241python/python.editor/external/preindexed.zip is not associated with
> > any license file
> > > 1242
> > > 1243Total time: 1 minute 30 seconds
> > > 1244The command "ant verify-libs-and-licenses
> > -Dverify-libs-and-licenses.haltonfailure=true -Dmetabuild.jsonurl=
> >
> https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
> "
> > exited with 1.
> > >
> > > <https://github.com/apache/netbeans/pull/2622>
> > >
> > > (2) And like this
> > >
> > > BUILD FAILED
> > > 550/home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2227:
> > Failed Rat test(s):
> > > 551Unapproved license in 549 file(s)
> > > 552
> >
> https://github.com/apache/netbeans/tree/master/python/python.debugger/src/org/netbeans/modules/python/debugger/config/NetBeansFrontend.java
> > > 553
> >
> https://github.com/apache/netbeans/tree/master/python/python.project/src/org/netbeans/modules/python/project/ui/actions/RunSingleCommand.java
> > > 554
> >
> https://github.com/apache/netbeans/tree/master/python/python.editor/src/org/netbeans/modules/python/editor/wizards/pypackage/PythonPackageWizardIterator.java
> > >
> > >
> > >
> > > Eric Bresie
> > > ebresie@gmail.com
> > >
> > >
> > > On Tue, Dec 29, 2020 at 12:28 PM Eric Bresie <eb...@gmail.com>
> wrote:
> > >
> > >> Okay...I was able to get it to compile and run successfully. Haven't
> > >> done too much testing yet but seems in good shape so far.
> > >>
> > >> Assume this may be in support of NETBEANS-4538
> > >>
> > >> So wanted to see what may be needed to go forward with this.
> > >>
> > >> It is still unclear to be about
> > >> (1) How to handle the missing files mentioned earlier (see earlier
> email
> > >> for more specifics)
> > >> (2) Is there expected to be any further "donation" activities which
> may
> > >> make some of this be overcome by other updates coming down the line?
> > >> (3) Is Oracle/Apache legal still working anything prior to acceptance?
> > >> (4) Since much of this is derived from the nbpython project, is there
> > any
> > >> concerns from the nbpython project team?
> > >> a) I've had difficult contacting anyone due to stale or
> > >> inaccessible web sites or comms means
> > >> b) I'm hoping some folks on the list may be able to help here
> > >> (5) What needs to be done to include this incoming
> > >> build/release/milestone/components/etc.?
> > >>
> > >> Assume one of the first steps would be check in and raise a PR but due
> > to
> > >> my inexperience in this sort of major git activities, I may need some
> > help
> > >> on this as I don't believe what I've done so far is quite right.
> > >>
> > >> When pushing my local "python" branch changes to my fork (see
> > >> https://github.com/ebresie/netbeans) on a remote "python" branch
> there
> > >> was a mixture of activities going on at the same time when trying to
> > check
> > >> some of this stuff in. Specifically there were changes including (1)
> > >> periodic upstream merge of recent change, (2) a separate cnd
> > >> activities[which should have been a separate branch but unfortunately
> > got
> > >> included with previous updates] , and (3) mixture of maven vs
> non-maven
> > >> python versions.
> > >>
> > >> So all that is to say, this makes creating a PR rather difficult..
> How
> > >> can I reconcile these issues in support of PR creation? Is there a
> way
> > to
> > >> exclude these sorts of things in github PR (i.e. can I somehow delete
> > the
> > >> other commits)? Do I need some squashed or some other git activities?
> > Do
> > >> I need to somehow revert back to state prior to python getting merged
> > and
> > >> without the "cnd" inclusion and then somehow merge the python changes
> in
> > >> some way on a fresh attempt? Git help is appreciated.
> > >>
> > >> Eric Bresie
> > >> ebresie@gmail.com
> > >>
> > >>
> > >> On Mon, Dec 28, 2020 at 8:30 PM Eric Bresie <eb...@gmail.com>
> wrote:
> > >>
> > >>> Also in the python.editor module, in the scripts is a missing
> > >>> "coverage.py" file as well.
> > >>>
> > >>> I believe this is related to
> > >>> http://nedbatchelder.com/code/modules/coverage.html
> > >>> Or more recently https://coverage.readthedocs.io/en/latest/
> > >>>
> > >>> Assume this one may be left out on purpose. Assume can either (1)
> > >>> remove references to it elsewhere (where it's getting copied), (2)
> > find a
> > >>> way to "import" as an external element of some type or (3) replace it
> > in
> > >>> some other way.
> > >>>
> > >>> Eric Bresie
> > >>> ebresie@gmail.com
> > >>>
> > >>>
> > >>> On Mon, Dec 28, 2020 at 6:56 PM Eric Bresie <eb...@gmail.com>
> wrote:
> > >>>
> > >>>> Okay...after a few failed attempts and a few more tweaks (I had to
> > >>>> change the location in the build.xml for each of the projects to
> > point to
> > >>>> the python cluster subdirectory)...I was finally able to get it to
> > build up
> > >>>> to a point...
> > >>>>
> > >>>> However ended with errors like the below.
> > >>>>
> > >>>> Seems
> > >>>>
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > >>>> depends on org.netbeans.modules.python.debugger.utils.MiscStatic
> which
> > >>>> appears to not be present. Did this get left out in the donation?
> I
> > don't
> > >>>> see it in the hg.netbeans.org main/contrib version of this but do
> > find
> > >>>> it in the maven version.
> > >>>>
> > >>>> Also seems to be missing package
> > >>>> org.netbeans.modules.python.source.scopes (also found in the maven
> > version)
> > >>>> with which includes but not limited to classes like SymbolTable and
> > >>>> SymInfo. Are these the sort of files that may get removed as part
> of
> > >>>> donation and/or IP sanitizing of the donation?
> > >>>>
> > >>>> -do-compile:
> > >>>> [nb-javac] Compiling 75 source files to
> > >>>> C:\netbeans\python\python.debugger\build\classes
> > >>>> [repeat] warning: [options] bootstrap class path not set in
> > >>>> conjunction with -source 7
> > >>>> [repeat]
> > >>>>
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > >>>> in org.xml.sax.helpers has been deprecated
> > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > >>>> [repeat] ^
> > >>>> [repeat]
> > >>>>
> >
> C:\git\netbeans.ebresie\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > >>>> [repeat] import
> > >>>> org.netbeans.modules.python.debugger.utils.MiscStatic;
> > >>>> [repeat] ^
> > >>>> [repeat] symbol: class MiscStatic
> > >>>> [repeat] location: package
> > >>>> org.netbeans.modules.python.debugger.utils
> > >>>> [repeat]
> > >>>>
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > >>>> in org.xml.sax.helpers has been deprecated
> > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > >>>> [repeat] ^
> > >>>> [repeat] 1 error
> > >>>> [repeat] 3 warnings
> > >>>> [nbmerge] Failed to build target: all-python.debugger
> > >>>>
> > >>>> BUILD FAILED
> > >>>> C:\netbeans\nbbuild\build.xml:643: The following error occurred
> while
> > >>>> executing this line:
> > >>>> C:\netbeans\nbbuild\build.xml:638: The following error occurred
> while
> > >>>> executing this line:
> > >>>> C:\netbeans\nbbuild\build.xml:685: The following error occurred
> while
> > >>>> executing this line:
> > >>>> C:\netbeans\nbbuild\templates\common.xml:206: Compile failed; see
> the
> > >>>> compiler error output for details.
> > >>>>
> > >>>> On a separate note...
> > >>>> However I was thinking maybe my depends may not be right.
> Presently I
> > >>>> have
> > >>>>
> > >>>> nb.cluster.python.depends=\
> > >>>> ${clusters.config.platform.list},\
> > >>>> nb.cluster.ide,\
> > >>>> nb.cluster.nb
> > >>>>
> > >>>> But not sure if that's overkill. Any recommendations on these?
> > >>>>
> > >>>>
> > >>>> Eric Bresie
> > >>>> ebresie@gmail.com
> > >>>>
> > >>>
> >
>
[Donation Status] Re: Work on Python [NETBEANS-4538] - Licenses for
Python Code
Posted by Eric Bresie <eb...@gmail.com>.
Hate to keep bugging but...
Is there any status update on the final donations?
I had worked some on one portion of things for python and almost had it
ready (1) [late last year with draft PR with pending work to resolve
conflicting unrealized files] but held off on finalizing the work due to
the need for usage of the official donation version as opposed to to the
the hg repository and forked source that I leveraged previously while
working things.
Possible new implementation has also been discussed but have not started
anything on that.
Anything?
Eric
Reference:
(1) https://github.com/apache/netbeans/pull/2622
On Sun, Jan 3, 2021 at 3:09 PM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
>
> Yes, I’ve asked for him to provide an update. However, ETAs don’t really
> work for these kinds of things — it’s going to take quite a while still, I
> believe. And, even then, it will take a lot of work to integrate into
> NetBeans. Probably an LSP based approach might work better, i.e., starting
> from scratch.
>
> Gj
>
> On Sun, 3 Jan 2021 at 22:06, John Mc <mc...@gmail.com> wrote:
>
>> Geertjan,
>>
>> Is the person responsible for Oracle on the mailing list? is there any way
>> to get an ETA on it? While we know it takes a while, we've not had much
>> info on this donation in a long time...
>>
>> Regards
>>
>> John
>>
>> On Sun, 3 Jan 2021 at 21:04, Geertjan Wielenga <ge...@apache.org>
>> wrote:
>>
>> > Yes, it is in the next and final donation, the 6th donation. Others in
>> > Oracle have taken over the task from me and as always this is going to
>> take
>> > some time. I recommend you forget about Python for a while and look at
>> > other things — really try to pick one thing, just one thing, not a
>> massive
>> > thing, but a small thing, to focus on.
>> >
>> > My 2c.
>> >
>> > Gj
>> >
>> > On Sun, 3 Jan 2021 at 20:45, Eric Bresie <eb...@gmail.com> wrote:
>> >
>> > > Geertjan, what is the status of Donation 6? And is the status still
>> > > tracked at the link below? The page doesn't show who is assigned to
>> the
>> > > work so not sure who to ask on this for further details.
>> > >
>> > > If the donation is complete, where are the zip file(s)?
>> > >
>> > > Eric Bresie
>> > > ebresie@gmail.com
>> > >
>> > >
>> > > On Sat, Jan 2, 2021 at 12:24 PM John Mc <mc...@gmail.com>
>> > wrote:
>> > >
>> > >> Might be one for Geertjan, to see how took over ownership in Oracle
>> for
>> > >> managing the donations when he left...
>> > >>
>> > >> Regards
>> > >>
>> > >> John
>> > >>
>> > >> On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
>> > >>
>> > >> > > EB ==> Okay sounds like a big misunderstanding on my part
>> (assumed
>> > hg
>> > >> > > > was a
>> > >> > > > valid "donation" source which is not the case)
>> > >> > > > EB ==> Where are the officially donated .zip file for the
>> python
>> > >> > > > (contrib)
>> > >> > > > files?
>> > >> > > > EB ==> I find some details here (1) but beyond that I don't see
>> > more
>> > >> > > > specifics.
>> > >> > > > EB ==> (1)
>> > >> > > >
>> > >>
>> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
>> > >> > >
>> > >> > > The python modules are part of the 6th donation package, which
>> has
>> > not
>> > >> > > been done yet (at least to my knowledge).
>> > >> > >
>> > >> >
>> > >> > Can anyone speak on the status of donation 6 then?
>> > >> >
>> > >> > Eric
>> > >> >
>> > >>
>> > >
>> >
>>
> --
Eric Bresie
ebresie@gmail.com
Re: How to implement a new language on LSP (Python)
Posted by Jan Lahoda <la...@gmail.com>.
Hi,
I've started with a page here:
https://cwiki.apache.org/confluence/display/NETBEANS/Adding+New+Language+Support
Feedback, or improvements based on experiences are welcome!
Jan
On Sun, Jan 24, 2021 at 3:22 PM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Hi Eric,
>
> Am Samstag, den 23.01.2021, 14:37 -0600 schrieb Eric Bresie:
> If one was to want to implement a new language using LSP, what does
> that
> take? Is there any document on doing so?
>
> have a look at the TypeScript module (webcommon/typescript.editor) or
> the whole cpplite cluster. Both build on top of lsp support.
>
> Greetings
>
> Matthias
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: How to implement a new language on LSP (Python)
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi Eric,
Am Samstag, den 23.01.2021, 14:37 -0600 schrieb Eric Bresie:
If one was to want to implement a new language using LSP, what does
that
take? Is there any document on doing so?
have a look at the TypeScript module (webcommon/typescript.editor) or
the whole cpplite cluster. Both build on top of lsp support.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
How to implement a new language on LSP (Python)
Posted by Eric Bresie <eb...@gmail.com>.
This is a new thread regarding LSP and python...
If one was to want to implement a new language using LSP, what does that
take? Is there any document on doing so?
Eric
On Sun, Jan 3, 2021 at 3:09 PM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
>
> Yes, I’ve asked for him to provide an update. However, ETAs don’t really
> work for these kinds of things — it’s going to take quite a while still, I
> believe. And, even then, it will take a lot of work to integrate into
> NetBeans. Probably an LSP based approach might work better, i.e., starting
> from scratch.
>
> Gj
>
--
Eric Bresie
ebresie@gmail.com
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Yes, I’ve asked for him to provide an update. However, ETAs don’t really
work for these kinds of things — it’s going to take quite a while still, I
believe. And, even then, it will take a lot of work to integrate into
NetBeans. Probably an LSP based approach might work better, i.e., starting
from scratch.
Gj
On Sun, 3 Jan 2021 at 22:06, John Mc <mc...@gmail.com> wrote:
> Geertjan,
>
> Is the person responsible for Oracle on the mailing list? is there any way
> to get an ETA on it? While we know it takes a while, we've not had much
> info on this donation in a long time...
>
> Regards
>
> John
>
> On Sun, 3 Jan 2021 at 21:04, Geertjan Wielenga <ge...@apache.org>
> wrote:
>
> > Yes, it is in the next and final donation, the 6th donation. Others in
> > Oracle have taken over the task from me and as always this is going to
> take
> > some time. I recommend you forget about Python for a while and look at
> > other things — really try to pick one thing, just one thing, not a
> massive
> > thing, but a small thing, to focus on.
> >
> > My 2c.
> >
> > Gj
> >
> > On Sun, 3 Jan 2021 at 20:45, Eric Bresie <eb...@gmail.com> wrote:
> >
> > > Geertjan, what is the status of Donation 6? And is the status still
> > > tracked at the link below? The page doesn't show who is assigned to
> the
> > > work so not sure who to ask on this for further details.
> > >
> > > If the donation is complete, where are the zip file(s)?
> > >
> > > Eric Bresie
> > > ebresie@gmail.com
> > >
> > >
> > > On Sat, Jan 2, 2021 at 12:24 PM John Mc <mc...@gmail.com>
> > wrote:
> > >
> > >> Might be one for Geertjan, to see how took over ownership in Oracle
> for
> > >> managing the donations when he left...
> > >>
> > >> Regards
> > >>
> > >> John
> > >>
> > >> On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
> > >>
> > >> > > EB ==> Okay sounds like a big misunderstanding on my part (assumed
> > hg
> > >> > > > was a
> > >> > > > valid "donation" source which is not the case)
> > >> > > > EB ==> Where are the officially donated .zip file for the python
> > >> > > > (contrib)
> > >> > > > files?
> > >> > > > EB ==> I find some details here (1) but beyond that I don't see
> > more
> > >> > > > specifics.
> > >> > > > EB ==> (1)
> > >> > > >
> > >>
> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
> > >> > >
> > >> > > The python modules are part of the 6th donation package, which has
> > not
> > >> > > been done yet (at least to my knowledge).
> > >> > >
> > >> >
> > >> > Can anyone speak on the status of donation 6 then?
> > >> >
> > >> > Eric
> > >> >
> > >>
> > >
> >
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by John Mc <mc...@gmail.com>.
Geertjan,
Is the person responsible for Oracle on the mailing list? is there any way
to get an ETA on it? While we know it takes a while, we've not had much
info on this donation in a long time...
Regards
John
On Sun, 3 Jan 2021 at 21:04, Geertjan Wielenga <ge...@apache.org> wrote:
> Yes, it is in the next and final donation, the 6th donation. Others in
> Oracle have taken over the task from me and as always this is going to take
> some time. I recommend you forget about Python for a while and look at
> other things — really try to pick one thing, just one thing, not a massive
> thing, but a small thing, to focus on.
>
> My 2c.
>
> Gj
>
> On Sun, 3 Jan 2021 at 20:45, Eric Bresie <eb...@gmail.com> wrote:
>
> > Geertjan, what is the status of Donation 6? And is the status still
> > tracked at the link below? The page doesn't show who is assigned to the
> > work so not sure who to ask on this for further details.
> >
> > If the donation is complete, where are the zip file(s)?
> >
> > Eric Bresie
> > ebresie@gmail.com
> >
> >
> > On Sat, Jan 2, 2021 at 12:24 PM John Mc <mc...@gmail.com>
> wrote:
> >
> >> Might be one for Geertjan, to see how took over ownership in Oracle for
> >> managing the donations when he left...
> >>
> >> Regards
> >>
> >> John
> >>
> >> On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
> >>
> >> > > EB ==> Okay sounds like a big misunderstanding on my part (assumed
> hg
> >> > > > was a
> >> > > > valid "donation" source which is not the case)
> >> > > > EB ==> Where are the officially donated .zip file for the python
> >> > > > (contrib)
> >> > > > files?
> >> > > > EB ==> I find some details here (1) but beyond that I don't see
> more
> >> > > > specifics.
> >> > > > EB ==> (1)
> >> > > >
> >> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
> >> > >
> >> > > The python modules are part of the 6th donation package, which has
> not
> >> > > been done yet (at least to my knowledge).
> >> > >
> >> >
> >> > Can anyone speak on the status of donation 6 then?
> >> >
> >> > Eric
> >> >
> >>
> >
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Geertjan Wielenga <ge...@apache.org>.
Yes, it is in the next and final donation, the 6th donation. Others in
Oracle have taken over the task from me and as always this is going to take
some time. I recommend you forget about Python for a while and look at
other things — really try to pick one thing, just one thing, not a massive
thing, but a small thing, to focus on.
My 2c.
Gj
On Sun, 3 Jan 2021 at 20:45, Eric Bresie <eb...@gmail.com> wrote:
> Geertjan, what is the status of Donation 6? And is the status still
> tracked at the link below? The page doesn't show who is assigned to the
> work so not sure who to ask on this for further details.
>
> If the donation is complete, where are the zip file(s)?
>
> Eric Bresie
> ebresie@gmail.com
>
>
> On Sat, Jan 2, 2021 at 12:24 PM John Mc <mc...@gmail.com> wrote:
>
>> Might be one for Geertjan, to see how took over ownership in Oracle for
>> managing the donations when he left...
>>
>> Regards
>>
>> John
>>
>> On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
>>
>> > > EB ==> Okay sounds like a big misunderstanding on my part (assumed hg
>> > > > was a
>> > > > valid "donation" source which is not the case)
>> > > > EB ==> Where are the officially donated .zip file for the python
>> > > > (contrib)
>> > > > files?
>> > > > EB ==> I find some details here (1) but beyond that I don't see more
>> > > > specifics.
>> > > > EB ==> (1)
>> > > >
>> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
>> > >
>> > > The python modules are part of the 6th donation package, which has not
>> > > been done yet (at least to my knowledge).
>> > >
>> >
>> > Can anyone speak on the status of donation 6 then?
>> >
>> > Eric
>> >
>>
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Eric Bresie <eb...@gmail.com>.
Geertjan, what is the status of Donation 6? And is the status still tracked
at the link below? The page doesn't show who is assigned to the work so
not sure who to ask on this for further details.
If the donation is complete, where are the zip file(s)?
Eric Bresie
ebresie@gmail.com
On Sat, Jan 2, 2021 at 12:24 PM John Mc <mc...@gmail.com> wrote:
> Might be one for Geertjan, to see how took over ownership in Oracle for
> managing the donations when he left...
>
> Regards
>
> John
>
> On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
>
> > > EB ==> Okay sounds like a big misunderstanding on my part (assumed hg
> > > > was a
> > > > valid "donation" source which is not the case)
> > > > EB ==> Where are the officially donated .zip file for the python
> > > > (contrib)
> > > > files?
> > > > EB ==> I find some details here (1) but beyond that I don't see more
> > > > specifics.
> > > > EB ==> (1)
> > > >
> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
> > >
> > > The python modules are part of the 6th donation package, which has not
> > > been done yet (at least to my knowledge).
> > >
> >
> > Can anyone speak on the status of donation 6 then?
> >
> > Eric
> >
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by John Mc <mc...@gmail.com>.
Might be one for Geertjan, to see how took over ownership in Oracle for
managing the donations when he left...
Regards
John
On Sat 2 Jan 2021, 18:00 Eric Bresie, <eb...@gmail.com> wrote:
> > EB ==> Okay sounds like a big misunderstanding on my part (assumed hg
> > > was a
> > > valid "donation" source which is not the case)
> > > EB ==> Where are the officially donated .zip file for the python
> > > (contrib)
> > > files?
> > > EB ==> I find some details here (1) but beyond that I don't see more
> > > specifics.
> > > EB ==> (1)
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
> >
> > The python modules are part of the 6th donation package, which has not
> > been done yet (at least to my knowledge).
> >
>
> Can anyone speak on the status of donation 6 then?
>
> Eric
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Eric Bresie <eb...@gmail.com>.
> EB ==> Okay sounds like a big misunderstanding on my part (assumed hg
> > was a
> > valid "donation" source which is not the case)
> > EB ==> Where are the officially donated .zip file for the python
> > (contrib)
> > files?
> > EB ==> I find some details here (1) but beyond that I don't see more
> > specifics.
> > EB ==> (1)
> > https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
>
> The python modules are part of the 6th donation package, which has not
> been done yet (at least to my knowledge).
>
Can anyone speak on the status of donation 6 then?
Eric
Re: License Converter Tool Issues
Posted by Eric Bresie <eb...@gmail.com>.
I made a small update to the converter tool in the netbeans-tools. See
https://github.com/apache/netbeans-tools/pull/41
Eric Bresie
ebresie@gmail.com
On Sun, Jan 3, 2021 at 1:39 PM Eric Bresie <eb...@gmail.com> wrote:
>
> On Sat, Jan 2, 2021 at 11:56 AM Matthias Bläsing <
> mblaesing@doppel-helix.eu> wrote:
>
>> Hi,
>>
>> Am Samstag, den 02.01.2021, 11:38 -0600 schrieb Eric Bresie:
>> > On Thu, Dec 31, 2020 at 1:41 AM Matthias Bläsing <
>> > mblaesing@doppel-helix.eu>
>> > wrote:
>> >
>> > > Am Mittwoch, den 30.12.2020, 16:24 -0600 schrieb Eric Bresie:
>> > >
>> > > See the "Convert" Tool, this might help with the correct mostly
>> > > automatic translation:
>> > >
>> > >
>> https://github.com/apache/netbeans-tools/blob/master/convert/src/convert/Convert.java
>> > >
>> > > This is part of the netbeans-tools repository:
>> > >
>> > > https://github.com/apache/netbeans-tools/
>> > >
>> > > And the whole project is here:
>> > >
>> > > https://github.com/apache/netbeans-tools/tree/master/convert
>> > >
>> >
>> > EB ==> Pulled the tool and started attempting to use this on the local
>> > codebase.
>> >
>> > EB ==> However when attempting it finds a "META-INF\LICENSE" file
>> without
>> > an extension which when attempting the "name.indexOf(".") on the file
>> > causes an index out of bound issue (i.e. there is no extension so
>> checks on
>> > specific extensions fails).
>>
>> Feel free to fix. The netbeans-tools repository is also just an Apache
>> repository holding tools (as the name implies).
>
>
> Okay with a minor tweak to account for this case I was able to get it to
> iterate through each of the files and replace the header with the Apache
> licenses in most cases.
>
> Eric Bresie
> ebresie@gmail.com
>
Re: License Converter Tool Issues
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Am Sonntag, den 03.01.2021, 13:39 -0600 schrieb Eric Bresie:
However I noticed the following possible further issues:
(1) When dealing with many of the properties files, it seemed to
strip comments starting with # all together. Assume this may require
changes to the logic where it's replacing the header to avoid this.
It would help if you could provide a stand-alone sample, that
reproduces the problem. I won't comment one theoretic questions without
reference.
(2) If there is no header presently, it does not modify this. Assume
this would be a case where when an existing header is not present then
add
it as well where applicable
Running "ant rat" on a clean tree (no build artifacts) will check the
files for licenses. It highly depends on the number of files that are
affected whether or not automation will help. You will never get 100%
succcess for this, the tools are there to help, not make all work go
away.
(3) When iterating through, it seems to iterate through some binary
files (i.e. class and jar files). Not sure if it tries to modify
these but seems like that might be unnecessary. Maybe need some
additional
"exclude" logics with some defaults included in some way (maybe a
properties
file with exclusions or a parameter with exclusions included)
There should be no binaries in the tree when the tool runs - even so,
it should be trivial to exclude these, either from the
scan/modification or the final commit.
If I was to make some of these changes, are changes for this tracked
in the Netbeans JIRA (i.e. does a ticket need raising here or elsewhere
[git
Issue?]). Or would making the changes with a PR suffice?
The netbeans-tools are a mixed bunch of code. For the convert tool
fixing it with a PR and maybe getting a second opinion should be
enough.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
License Converter Tool Issues
Posted by Eric Bresie <eb...@gmail.com>.
On Sat, Jan 2, 2021 at 11:56 AM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Hi,
>
> Am Samstag, den 02.01.2021, 11:38 -0600 schrieb Eric Bresie:
> > On Thu, Dec 31, 2020 at 1:41 AM Matthias Bläsing <
> > mblaesing@doppel-helix.eu>
> > wrote:
> >
> > > Am Mittwoch, den 30.12.2020, 16:24 -0600 schrieb Eric Bresie:
> > >
> > > Licenses from Oracle can be directly replaced, if there are files
> > > found, that are not owned by oracle, more analysis is required.
> > >
> > > See the "Convert" Tool, this might help with the correct mostly
> > > automatic translation:
> > >
> > >
> https://github.com/apache/netbeans-tools/blob/master/convert/src/convert/Convert.java
> > >
> > > This is part of the netbeans-tools repository:
> > >
> > > https://github.com/apache/netbeans-tools/
> > >
> > > And the whole project is here:
> > >
> > > https://github.com/apache/netbeans-tools/tree/master/convert
> > >
> >
> > EB ==> Pulled the tool and started attempting to use this on the local
> > codebase.
> >
> > EB ==> However when attempting it finds a "META-INF\LICENSE" file without
> > an extension which when attempting the "name.indexOf(".") on the file
> > causes an index out of bound issue (i.e. there is no extension so checks
> on
> > specific extensions fails).
>
> Feel free to fix. The netbeans-tools repository is also just an Apache
> repository holding tools (as the name implies).
Okay with a minor tweak to account for this case I was able to get it to
iterate through each of the files and replace the header with the Apache
licenses in most cases.
However I noticed the following possible further issues:
(1) When dealing with many of the properties files, it seemed to strip
comments starting with # all together. Assume this may require changes to
the logic where it's replacing the header to avoid this.
(2) If there is no header presently, it does not modify this. Assume this
would be a case where when an existing header is not present then add it as
well where applicable
(3) When iterating through, it seems to iterate through some binary
files (i.e. class and jar files). Not sure if it tries to modify these but
seems like that might be unnecessary. Maybe need some additional "exclude"
logics with some defaults included in some way (maybe a properties file
with exclusions or a parameter with exclusions included)
If I was to make some of these changes, are changes for this tracked in the
Netbeans JIRA (i.e. does a ticket need raising here or elsewhere [git
Issue?]). Or would making the changes with a PR suffice?
Eric Bresie
ebresie@gmail.com
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Samstag, den 02.01.2021, 11:38 -0600 schrieb Eric Bresie:
> On Thu, Dec 31, 2020 at 1:41 AM Matthias Bläsing <
> mblaesing@doppel-helix.eu>
> wrote:
>
> > Am Mittwoch, den 30.12.2020, 16:24 -0600 schrieb Eric Bresie:
> >
> >
> >
> > Licenses from Oracle can be directly replaced, if there are files
> > found, that are not owned by oracle, more analysis is required.
> >
> > See the "Convert" Tool, this might help with the correct mostly
> > automatic translation:
> >
> >
> > https://github.com/apache/netbeans-tools/blob/master/convert/src/convert/Convert.java
> >
> > This is part of the netbeans-tools repository:
> >
> > https://github.com/apache/netbeans-tools/
> >
> > And the whole project is here:
> >
> > https://github.com/apache/netbeans-tools/tree/master/convert
> >
>
> EB ==> Pulled the tool and started attempting to use this on the local
> codebase.
>
> EB ==> However when attempting it finds a "META-INF\LICENSE" file without
> an extension which when attempting the "name.indexOf(".") on the file
> causes an index out of bound issue (i.e. there is no extension so checks on
> specific extensions fails).
Feel free to fix. The netbeans-tools repository is also just an Apache
repository holding tools (as the name implies).
> > > > The general way (and maybe a reason to redo the PR) is:
> > > >
> > > > - Get the file(s) oracle donated
> > > >
> > > => I got most of the files from the hg.netbeans.org repository so
> > > assume
> > > most of this is good.
> >
> > No - if you got them from hg.netbeans.org they are bad and must not be
> > used. hg.netbeans.org holds the GPLv2/CDDL sources from oracle and was
> > not donated as a whole. Only the donated sources are a valid basis for
> > integration. We have the zips, the hashes and when integration happens
> > it needs to be verified, that the new files are indeed taken from that
> > zip.
> >
> > We can't take random source code and integrate that.
> >
>
> EB ==> Okay sounds like a big misunderstanding on my part (assumed hg
> was a
> valid "donation" source which is not the case)
> EB ==> Where are the officially donated .zip file for the python
> (contrib)
> files?
> EB ==> I find some details here (1) but beyond that I don't see more
> specifics.
> EB ==> (1)
> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
The python modules are part of the 6th donation package, which has not
been done yet (at least to my knowledge).
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Eric Bresie <eb...@gmail.com>.
See "EB ==>" below
Eric Bresie
ebresie@gmail.com
On Thu, Dec 31, 2020 at 1:41 AM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Am Mittwoch, den 30.12.2020, 16:24 -0600 schrieb Eric Bresie:
>
> > => SO if there are existing licenses from Oracle and/or any others (i.e.
> > JYTHON, nbPython licenses, etc.), these can be stripped and replaced or
> > should the Apache replace the Oracle and any other such licenses left?
> >
>
> Licenses from Oracle can be directly replaced, if there are files
> found, that are not owned by oracle, more analysis is required.
>
> See the "Convert" Tool, this might help with the correct mostly
> automatic translation:
>
>
> https://github.com/apache/netbeans-tools/blob/master/convert/src/convert/Convert.java
>
> This is part of the netbeans-tools repository:
>
> https://github.com/apache/netbeans-tools/
>
> And the whole project is here:
>
> https://github.com/apache/netbeans-tools/tree/master/convert
>
EB ==> Pulled the tool and started attempting to use this on the local
codebase.
EB ==> However when attempting it finds a "META-INF\LICENSE" file without
an extension which when attempting the "name.indexOf(".") on the file
causes an index out of bound issue (i.e. there is no extension so checks on
specific extensions fails).
> > > The general way (and maybe a reason to redo the PR) is:
> > >
> > > - Get the file(s) oracle donated
> > >
> > => I got most of the files from the hg.netbeans.org repository so assume
> > most of this is good.
>
> No - if you got them from hg.netbeans.org they are bad and must not be
> used. hg.netbeans.org holds the GPLv2/CDDL sources from oracle and was
> not donated as a whole. Only the donated sources are a valid basis for
> integration. We have the zips, the hashes and when integration happens
> it needs to be verified, that the new files are indeed taken from that
> zip.
>
> We can't take random source code and integrate that.
>
EB ==> Okay sounds like a big misunderstanding on my part (assumed hg was a
valid "donation" source which is not the case)
EB ==> Where are the officially donated .zip file for the python (contrib)
files?
EB ==> I find some details here (1) but beyond that I don't see more
specifics.
EB ==> (1)
https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition
EB ==> I do note it seems to indicate someone from the nbPython project may
need to be involved but
EB ==> I've not seen any direct input from this project or group in many
attempts so not sure if this project is
EB ==> just defunct or no one is working on it any more.
EB ==> Anyone from nbPython on the mailing list able to chime in?
> - Extract the files you want to integrate and document
> > > how it can be verified, that the files came that donated
> > > file
> > >
> > => However there were a few files missing from the hg repository which
> were
> > available in the "maven-ized" version of the python code base. I've
> > included those as well to get things to compile but not sure if these are
> > "donated" or not.
>
> Where does this code come from? The author of the new code is free to
> donate his changes, but no, it can't be integrated together with the
> oracle code in one single commit, but must be identifiable.
>
EB ==> The "initial files" came from hg.netbeans.org\main\contribs
projects.
EB ==> The "new files" came from "Tim's Mavenized version" of the contrib
folder projects.
EB ==> Assume this version was more closely related to the actual
donated one but I'm not sure.
EB ==> Once the zip file with the python contrib are identified I will
start over with this and hopefully avoid the mixture of files.
> The files in question included
> > (1) a "coverage.py" script for "test coverage" purposes. See
> > https://github.com/nedbat/coveragepy . I think this may be available
> > as
> > some form of node.js type modules so not sure if maybe this could be
> > another type of "external" component to download during prep for the
> > build
> > (2) The package org.netbeans.modules.python.source.scopes related
> > files
> > (3) MiscState and related files
> >
> > How should these be handled?
>
> Broad question - no idea without looking deeper into it. The idea to
> extract foreign files sonds sane though. We have some code that is ALv2
> licensed, but not donated. This can be done, but should be avoided.
> This should cover (1).
>
> For (2) + (3) no idea without some more description.
>
> EB ==> Will need to reevaluate once the "donate.zip" file is identified
and reattempted.
> > > - Create an orphan branch (a branch without a parent),
> > > add the extracted files to this branch and document
> > > in that file how the files and from where the files
> > > came from
> > >
> >
> > => Silly question, but how do you create a "branch without a parent"?
> >
> > I forked from apache\netbeans -> ebresie\netbeans then created a python
> > (branch) from that with periodic upstream (from apache\netbeans) fetches
> > and merges into my fork and into the branch to try to keep up.
>
> # change into the directory of the repository
> cd <repository>
> # create orphan branch
> git checkout --orphan nbpython_integration
> # remove all files
> git rm -rf .
> # if necessary remove all remaining files, ls + rm -rf should do it
> # Check that the directory is empty and nothing is still present
> ls
> git status
> # both should report nothing
>
> => Now you have an empty branch inside the netbeans repository, where
> the new files can be easily identified.
>
>
> > > - Do the license clean up
> > >
> > => This is the big part inwork now.
> >
> > I'm trying to use the License Changer Plugin (from 8.2 plugin site - see
> > http://plugins.netbeans.org/plugin/17960/license-changer ) but when
> > attempting after selecting the unpack200.exe (which is apparently no
> longer
> > available in java 15) and selecting the folder in question in file,
> during
> > "Preview" pane in the wizard, it keeps showing the Before and After with
> > the After showing "Canceled" without any apparent changes. Tim any ideas
> > on this or any updates on this plugin?
>
> See the netbeans-tools repository for an alternative (description
> above).
>
> >
> > > - Get approval from PMC for integration of this massive
> > > branch into master
> > >
> > => Assume PR then continue discussion here for that or is there some
> > other process needed?
>
> For an integration of this size I would suggest a vote about the
> integration, that makes it official and people will be woken up.
>
>
>
>
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Am Mittwoch, den 30.12.2020, 16:24 -0600 schrieb Eric Bresie:
> >
> > Oracle formally donated the code. Donation in this case means, that all
> > copyrights are transfered to the ASF and thus the ASF is free to apply
> > any license it sees fit.
> >
> > At this time the correct license is the Apache License 2.0. The right
> > header would then be:
> >
> > * Licensed to the Apache Software Foundation (ASF) under one
> > * or more contributor license agreements. See the NOTICE file
> > * distributed with this work for additional information
> > * regarding copyright ownership. The ASF licenses this file
> > * to you under the Apache License, Version 2.0 (the
> > * "License"); you may not use this file except in compliance
> > * with the License. You may obtain a copy of the License at
> > *
> > * http://www.apache.org/licenses/LICENSE-2.0
> > *
> > * Unless required by applicable law or agreed to in writing,
> > * software distributed under the License is distributed on an
> > * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > * KIND, either express or implied. See the License for the
> > * specific language governing permissions and limitations
> > * under the License.
> >
> > This can be found in neary every file on the repository.
> >
> >
> => SO if there are existing licenses from Oracle and/or any others (i.e.
> JYTHON, nbPython licenses, etc.), these can be stripped and replaced or
> should the Apache replace the Oracle and any other such licenses left?
>
Licenses from Oracle can be directly replaced, if there are files
found, that are not owned by oracle, more analysis is required.
See the "Convert" Tool, this might help with the correct mostly
automatic translation:
https://github.com/apache/netbeans-tools/blob/master/convert/src/convert/Convert.java
This is part of the netbeans-tools repository:
https://github.com/apache/netbeans-tools/
And the whole project is here:
https://github.com/apache/netbeans-tools/tree/master/convert
> > The general way (and maybe a reason to redo the PR) is:
> >
> > - Get the file(s) oracle donated
> >
> => I got most of the files from the hg.netbeans.org repository so assume
> most of this is good.
No - if you got them from hg.netbeans.org they are bad and must not be
used. hg.netbeans.org holds the GPLv2/CDDL sources from oracle and was
not donated as a whole. Only the donated sources are a valid basis for
integration. We have the zips, the hashes and when integration happens
it needs to be verified, that the new files are indeed taken from that
zip.
We can't take random source code and integrate that.
> - Extract the files you want to integrate and document
> > how it can be verified, that the files came that donated
> > file
> >
> => However there were a few files missing from the hg repository which were
> available in the "maven-ized" version of the python code base. I've
> included those as well to get things to compile but not sure if these are
> "donated" or not.
Where does this code come from? The author of the new code is free to
donate his changes, but no, it can't be integrated together with the
oracle code in one single commit, but must be identifiable.
> The files in question included
> (1) a "coverage.py" script for "test coverage" purposes. See
> https://github.com/nedbat/coveragepy . I think this may be available
> as
> some form of node.js type modules so not sure if maybe this could be
> another type of "external" component to download during prep for the
> build
> (2) The package org.netbeans.modules.python.source.scopes related
> files
> (3) MiscState and related files
>
> How should these be handled?
Broad question - no idea without looking deeper into it. The idea to
extract foreign files sonds sane though. We have some code that is ALv2
licensed, but not donated. This can be done, but should be avoided.
This should cover (1).
For (2) + (3) no idea without some more description.
> > - Create an orphan branch (a branch without a parent),
> > add the extracted files to this branch and document
> > in that file how the files and from where the files
> > came from
> >
>
> => Silly question, but how do you create a "branch without a parent"?
>
> I forked from apache\netbeans -> ebresie\netbeans then created a python
> (branch) from that with periodic upstream (from apache\netbeans) fetches
> and merges into my fork and into the branch to try to keep up.
# change into the directory of the repository
cd <repository>
# create orphan branch
git checkout --orphan nbpython_integration
# remove all files
git rm -rf .
# if necessary remove all remaining files, ls + rm -rf should do it
# Check that the directory is empty and nothing is still present
ls
git status
# both should report nothing
=> Now you have an empty branch inside the netbeans repository, where
the new files can be easily identified.
> > - Do the license clean up
> >
> => This is the big part inwork now.
>
> I'm trying to use the License Changer Plugin (from 8.2 plugin site - see
> http://plugins.netbeans.org/plugin/17960/license-changer ) but when
> attempting after selecting the unpack200.exe (which is apparently no longer
> available in java 15) and selecting the folder in question in file, during
> "Preview" pane in the wizard, it keeps showing the Before and After with
> the After showing "Canceled" without any apparent changes. Tim any ideas
> on this or any updates on this plugin?
See the netbeans-tools repository for an alternative (description
above).
>
> > - Get approval from PMC for integration of this massive
> > branch into master
> >
> => Assume PR then continue discussion here for that or is there some
> other process needed?
For an integration of this size I would suggest a vote about the
integration, that makes it official and people will be woken up.
HTH
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Eric Bresie <eb...@gmail.com>.
Thanks for the input Matthias...
=>See below
Eric Bresie
ebresie@gmail.com
On Wed, Dec 30, 2020 at 3:45 PM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Hi,
>
> Am Mittwoch, den 30.12.2020, 15:31 -0600 schrieb Eric Bresie:
> > As I don’t work for Oracle nor did I work on the nbPython work I didn’t
> > want to make assumptions on licenses.
> >
> > I thought I recalled when trying to get the Kolin support brought in,
> that
> > it required some work from the donator side. If that is not correct then
> > we can go ahead and re-license as applicable.
> >
> > Silly question but which Apache license should these be re-licensed to?
>
> Oracle formally donated the code. Donation in this case means, that all
> copyrights are transfered to the ASF and thus the ASF is free to apply
> any license it sees fit.
>
> At this time the correct license is the Apache License 2.0. The right
> header would then be:
>
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing,
> * software distributed under the License is distributed on an
> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> * KIND, either express or implied. See the License for the
> * specific language governing permissions and limitations
> * under the License.
>
> This can be found in neary every file on the repository.
>
>
=> SO if there are existing licenses from Oracle and/or any others (i.e.
JYTHON, nbPython licenses, etc.), these can be stripped and replaced or
should the Apache replace the Oracle and any other such licenses left?
> The general way (and maybe a reason to redo the PR) is:
>
> - Get the file(s) oracle donated
>
=> I got most of the files from the hg.netbeans.org repository so assume
most of this is good.
- Extract the files you want to integrate and document
> how it can be verified, that the files came that donated
> file
>
=> However there were a few files missing from the hg repository which were
available in the "maven-ized" version of the python code base. I've
included those as well to get things to compile but not sure if these are
"donated" or not.
The files in question included
(1) a "coverage.py" script for "test coverage" purposes. See
https://github.com/nedbat/coveragepy . I think this may be available as
some form of node.js type modules so not sure if maybe this could be
another type of "external" component to download during prep for the build
(2) The package org.netbeans.modules.python.source.scopes related files
(3) MiscState and related files
How should these be handled?
> - Create an orphan branch (a branch without a parent),
> add the extracted files to this branch and document
> in that file how the files and from where the files
> came from
>
=> Silly question, but how do you create a "branch without a parent"?
I forked from apache\netbeans -> ebresie\netbeans then created a python
(branch) from that with periodic upstream (from apache\netbeans) fetches
and merges into my fork and into the branch to try to keep up.
> - Do the license clean up
>
=> This is the big part inwork now.
I'm trying to use the License Changer Plugin (from 8.2 plugin site - see
http://plugins.netbeans.org/plugin/17960/license-changer ) but when
attempting after selecting the unpack200.exe (which is apparently no longer
available in java 15) and selecting the folder in question in file, during
"Preview" pane in the wizard, it keeps showing the Before and After with
the After showing "Canceled" without any apparent changes. Tim any ideas
on this or any updates on this plugin?
> - Make the code compilable (this might mean merging
> master into the orphan branch)
>
=> Was made compilable with the added files mentioned above and changes in
the build.xml files to the location from contrib to python cluster folder
where applicable, and the cluster.properties updates
.
> - Get approval from PMC for integration of this massive
> branch into master
>
=> Assume PR then continue discussion here for that or is there some other
process needed?
> - Done :-)
>
> This is the TL;DR version, as you can see with the CND branch, it can
> take much time.
>
> HTH
>
> Matthias
>
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Mittwoch, den 30.12.2020, 15:31 -0600 schrieb Eric Bresie:
> As I don’t work for Oracle nor did I work on the nbPython work I didn’t
> want to make assumptions on licenses.
>
> I thought I recalled when trying to get the Kolin support brought in, that
> it required some work from the donator side. If that is not correct then
> we can go ahead and re-license as applicable.
>
> Silly question but which Apache license should these be re-licensed to?
Oracle formally donated the code. Donation in this case means, that all
copyrights are transfered to the ASF and thus the ASF is free to apply
any license it sees fit.
At this time the correct license is the Apache License 2.0. The right
header would then be:
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
This can be found in neary every file on the repository.
The general way (and maybe a reason to redo the PR) is:
- Get the file(s) oracle donated
- Extract the files you want to integrate and document
how it can be verified, that the files came that donated
file
- Create an orphan branch (a branch without a parent),
add the extracted files to this branch and document
in that file how the files and from where the files
came from
- Do the license clean up
- Make the code compilable (this might mean merging
master into the orphan branch)
- Get approval from PMC for integration of this massive
branch into master
- Done :-)
This is the TL;DR version, as you can see with the CND branch, it can
take much time.
HTH
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Brad Walker <bw...@musings.com>.
On Wed, Dec 30, 2020 at 2:31 PM Eric Bresie <eb...@gmail.com> wrote:
> As I don’t work for Oracle nor did I work on the nbPython work I didn’t
> want to make assumptions on licenses.
>
> I thought I recalled when trying to get the Kolin support brought in, that
> it required some work from the donator side. If that is not correct then
> we can go ahead and re-license as applicable.
>
I don't believe any work is required from the donor side of things. Once
they have signed the license agreement and sent it over to Apache, it's
ours to do as we wish. The FIRST THING that should be done is properly
apply/update the license header in the donated source code.
Silly question but which Apache license should these be re-licensed to?
>
Apache License 2.0..
http://www.apache.org/licenses/LICENSE-2.0
Also assume there are some files (binary list files, some xml files, etc)
> that might not requiring the licenses to be added. If so then how do those
> get excluded?
>
There is an equivalent Apache license for our XML files. I remember fixing
a few of those in the CND module source code.
-brad w.
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Eric Bresie <eb...@gmail.com>.
As I don’t work for Oracle nor did I work on the nbPython work I didn’t
want to make assumptions on licenses.
I thought I recalled when trying to get the Kolin support brought in, that
it required some work from the donator side. If that is not correct then
we can go ahead and re-license as applicable.
Silly question but which Apache license should these be re-licensed to?
Also assume there are some files (binary list files, some xml files, etc)
that might not requiring the licenses to be added. If so then how do those
get excluded?
Also I thought I saw a “JYTHON” licenses referenced in some of the files.
Does this need to be added to the folder with licenses and maybe added to
names.properties file? Is this one compatible as well?
Eric
On Wed, Dec 30, 2020 at 1:56 PM Geertjan Wielenga
<ge...@googlemail.com.invalid> wrote:
> Donated means Oracle donated it, the code is now made available to us. We
> need to do the relicensing to Apache ourselves in Apache, why would Oracle
> be the one doing that?
>
> Gj
>
> On Wed, 30 Dec 2020 at 20:48, Eric Bresie <eb...@gmail.com> wrote:
>
> > Agree this is very much a work in progress but still need help on
> resolving
> > these issues especially the licensing part of this.
> >
> > I thought "donated" nbpython / contrib\*python* code (in the hg
> repository)
> > had licenses updated but assuming that may not be the case. What needs
> to
> > done to resolve these license problems?
> >
> > (1) Does Oracle still have to scrub the files and update the licenses in
> > each file in some way? Or is what's in the hg repository good enough to
> > work with and make changed to align with Apache licensing needs?
> > (2) Does the "JYTHON" license need to be included in the codebase
> somewhere
> > for use in documenting the licenses used in some (i.e. jython) code
> > context?
> > (3) What license should be used in each of these files? Assume there is
> > the original nbPython used licenses, then the "netbeans\contrib" used
> > licenses, and the "apache" licenses.
> > (4) Is there a tool to go through each file and update this in a batch
> > way? I seem to recall some form of "licensechanger" but not familiar
> with
> > how it works.
> > Is there
> > Eric Bresie
> > ebresie@gmail.com
> >
> >
> > On Wed, Dec 30, 2020 at 1:05 PM Geertjan Wielenga
> > <ge...@googlemail.com.invalid> wrote:
> >
> > > I’d say it is a lot tol early to try to get this code into our GitHub.
> > >
> > > Gj
> > >
> > >
> > > On Wed, 30 Dec 2020 at 19:19, Eric Bresie <eb...@gmail.com> wrote:
> > >
> > > > There also seems to be failure on ergonomics tests like the below but
> > I'm
> > > > not sure why this is happening. Maybe a failure elsewhere. Any
> > ideas?
> > > >
> > > > [junit] WARNING [org.netbeans.TopSecurityManager]: use of system
> > > > property netbeans.home has been obsoleted in favor of
> > > > InstalledFileLocator/Places at
> > > >
> > > >
> > >
> >
> org.netbeans.modules.ide.ergonomics.CommonServersBase.doGetAllInstancesErgo(CommonServersBase.java:90)
> > > > 10108 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > > Iterating ergo
> > > > 10109 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > > ergo: Amazon Beanstalk
> > > > 10110 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > > Iteration done for ergo
> > > > *10111 [junit] Test
> > > > org.netbeans.modules.ide.ergonomics.DynamicVerifyTest FAILED*
> > > > 10112 [junit] Dec 30, 2020 5:38:14 PM
> > > > org.netbeans.core.startup.NbEvents logged
> > > > 10113 [junit] INFO: Warning - could not install some modules:
> > > > 10114 [junit] org.netbeans.modules.editor.lib2 - No module
> > > > providing the capability org.netbeans.modules.editor.actions could be
> > > > found.
> > > > 10115 [junit] org.netbeans.modules.editor.lib - The module
> > > > org.netbeans.modules.editor.lib2 would also need to be installed.
> > > >
> > > >
> > > > BUILD FAILED
> > > >
> > 10234/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:723:
> > > > The following error occurred while executing this line:
> > > >
> > 10235/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:716:
> > > > The following error occurred while executing this line:
> > > >
> > 10236/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:750:
> > > > The following error occurred while executing this line:
> > > >
> > 10237/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:747:
> > > > Some tests failed; see details above.
> > > > 10238
> > > > 10239Total time: 1 minute 24 seconds
> > > > 10240The command "ant $OPTS -f ergonomics/ide.ergonomics test
> > > > -Dtest.config=commit" exited with 1.
> > > >
> > > > Eric Bresie
> > > > ebresie@gmail.com
> > > >
> > > >
> > > > On Wed, Dec 30, 2020 at 12:03 PM Eric Bresie <eb...@gmail.com>
> > wrote:
> > > >
> > > > > Okay after some synching with upstream and ovecoming some apparent
> > > github
> > > > > pr isms ...I have created a "draft PR" available at
> > > > > https://github.com/apache/netbeans/pull/2622
> > > > >
> > > > > However, it looks that some of the CI checks are failing as I kind
> of
> > > > > expected.
> > > > >
> > > > > Some seem to be related to licensing like the below.
> > > > >
> > > > > I assume some of this has to do with
> > > > > (1) Jython license details being missing,
> > > > > (2) Some "Oracle" licensing being present (assume this may be part
> of
> > > the
> > > > > donation process being worked), and some
> > > > > (3) Failure to document licenses in applicable locations
> > > > > (4) License formatting issues
> > > > >
> > > > > Can anyone familiar with handling licensing provide some input on
> how
> > > to
> > > > > handle these?
> > > > >
> > > > > Build licensing issues
> > > > > (1) This:
> > > > >
> > > > > verify-libs-and-licenses:
> > > > > 1226[verifylibsandlicenses]
> > > >
> > >
> >
> /home/travis/build/apache/netbeans/nbbuild/build/verifylibsandlicenses.xml:
> > > > 3 failures out of 5 tests
> > > > > 1227
> > > > > 1228BUILD FAILED
> > > > > 1229/home/travis/build/apache/netbeans/nbbuild/build.xml:1642:
> Failed
> > > > VerifyLibsAndLicenses test(s):
> > > > > 1230Some binaries were found outside of <module>/external/
> > directories
> > > > (edit nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries as
> > > > needed)
> > > > >
> > > >
> > >
> >
> 1231python/python.samples/src/org/netbeans/modules/python/samples/JySwingProject.zip
> > > > >
> > > >
> > >
> >
> 1232python/python.samples/src/org/netbeans/modules/python/samples/PLYDemoProject.zip
> > > > >
> > > >
> > >
> >
> 1233python/python.samples/src/org/netbeans/modules/python/samples/PyThreadsProject.zip
> > > > > 1234Some license files were badly formatted
> > > > > 1235python/o.jython.distro/external/jython-2.7.0-license.txt has a
> > > > trailing space on line #61
> > > > > 1236Some license files have incorrect headers
> > > > > 1237python/o.jython/external/jython-parser.jar does not appear to
> > > > include a version number
> > > > > 1238python/o.jython/external/jython-parser.jar is not associated
> with
> > > > any license file
> > > > > 1239python/o.jython.distro/external/jython-2.7.0-license.txt refers
> > to
> > > > nonexistent nbbuild/licenses/Jython
> > > > > 1240python/python.editor/external/preindexed.zip does not appear to
> > > > include a version number
> > > > > 1241python/python.editor/external/preindexed.zip is not associated
> > with
> > > > any license file
> > > > > 1242
> > > > > 1243Total time: 1 minute 30 seconds
> > > > > 1244The command "ant verify-libs-and-licenses
> > > > -Dverify-libs-and-licenses.haltonfailure=true -Dmetabuild.jsonurl=
> > > >
> > >
> >
> https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
> > > "
> > > > exited with 1.
> > > > >
> > > > > <https://github.com/apache/netbeans/pull/2622>
> > > > >
> > > > > (2) And like this
> > > > >
> > > > > BUILD FAILED
> > > > >
> 550/home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2227:
> > > > Failed Rat test(s):
> > > > > 551Unapproved license in 549 file(s)
> > > > > 552
> > > >
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.debugger/src/org/netbeans/modules/python/debugger/config/NetBeansFrontend.java
> > > > > 553
> > > >
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.project/src/org/netbeans/modules/python/project/ui/actions/RunSingleCommand.java
> > > > > 554
> > > >
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.editor/src/org/netbeans/modules/python/editor/wizards/pypackage/PythonPackageWizardIterator.java
> > > > >
> > > > >
> > > > >
> > > > > Eric Bresie
> > > > > ebresie@gmail.com
> > > > >
> > > > >
> > > > > On Tue, Dec 29, 2020 at 12:28 PM Eric Bresie <eb...@gmail.com>
> > > wrote:
> > > > >
> > > > >> Okay...I was able to get it to compile and run successfully.
> > Haven't
> > > > >> done too much testing yet but seems in good shape so far.
> > > > >>
> > > > >> Assume this may be in support of NETBEANS-4538
> > > > >>
> > > > >> So wanted to see what may be needed to go forward with this.
> > > > >>
> > > > >> It is still unclear to be about
> > > > >> (1) How to handle the missing files mentioned earlier (see earlier
> > > email
> > > > >> for more specifics)
> > > > >> (2) Is there expected to be any further "donation" activities
> which
> > > may
> > > > >> make some of this be overcome by other updates coming down the
> line?
> > > > >> (3) Is Oracle/Apache legal still working anything prior to
> > acceptance?
> > > > >> (4) Since much of this is derived from the nbpython project, is
> > there
> > > > any
> > > > >> concerns from the nbpython project team?
> > > > >> a) I've had difficult contacting anyone due to stale or
> > > > >> inaccessible web sites or comms means
> > > > >> b) I'm hoping some folks on the list may be able to help here
> > > > >> (5) What needs to be done to include this incoming
> > > > >> build/release/milestone/components/etc.?
> > > > >>
> > > > >> Assume one of the first steps would be check in and raise a PR but
> > due
> > > > to
> > > > >> my inexperience in this sort of major git activities, I may need
> > some
> > > > help
> > > > >> on this as I don't believe what I've done so far is quite right.
> > > > >>
> > > > >> When pushing my local "python" branch changes to my fork (see
> > > > >> https://github.com/ebresie/netbeans) on a remote "python" branch
> > > there
> > > > >> was a mixture of activities going on at the same time when trying
> to
> > > > check
> > > > >> some of this stuff in. Specifically there were changes including
> > (1)
> > > > >> periodic upstream merge of recent change, (2) a separate cnd
> > > > >> activities[which should have been a separate branch but
> > unfortunately
> > > > got
> > > > >> included with previous updates] , and (3) mixture of maven vs
> > > non-maven
> > > > >> python versions.
> > > > >>
> > > > >> So all that is to say, this makes creating a PR rather difficult..
> > > How
> > > > >> can I reconcile these issues in support of PR creation? Is there
> a
> > > way
> > > > to
> > > > >> exclude these sorts of things in github PR (i.e. can I somehow
> > delete
> > > > the
> > > > >> other commits)? Do I need some squashed or some other git
> > activities?
> > > > Do
> > > > >> I need to somehow revert back to state prior to python getting
> > merged
> > > > and
> > > > >> without the "cnd" inclusion and then somehow merge the python
> > changes
> > > in
> > > > >> some way on a fresh attempt? Git help is appreciated.
> > > > >>
> > > > >> Eric Bresie
> > > > >> ebresie@gmail.com
> > > > >>
> > > > >>
> > > > >> On Mon, Dec 28, 2020 at 8:30 PM Eric Bresie <eb...@gmail.com>
> > > wrote:
> > > > >>
> > > > >>> Also in the python.editor module, in the scripts is a missing
> > > > >>> "coverage.py" file as well.
> > > > >>>
> > > > >>> I believe this is related to
> > > > >>> http://nedbatchelder.com/code/modules/coverage.html
> > > > >>> Or more recently https://coverage.readthedocs.io/en/latest/
> > > > >>>
> > > > >>> Assume this one may be left out on purpose. Assume can either
> (1)
> > > > >>> remove references to it elsewhere (where it's getting copied),
> (2)
> > > > find a
> > > > >>> way to "import" as an external element of some type or (3)
> replace
> > it
> > > > in
> > > > >>> some other way.
> > > > >>>
> > > > >>> Eric Bresie
> > > > >>> ebresie@gmail.com
> > > > >>>
> > > > >>>
> > > > >>> On Mon, Dec 28, 2020 at 6:56 PM Eric Bresie <eb...@gmail.com>
> > > wrote:
> > > > >>>
> > > > >>>> Okay...after a few failed attempts and a few more tweaks (I had
> to
> > > > >>>> change the location in the build.xml for each of the projects to
> > > > point to
> > > > >>>> the python cluster subdirectory)...I was finally able to get it
> to
> > > > build up
> > > > >>>> to a point...
> > > > >>>>
> > > > >>>> However ended with errors like the below.
> > > > >>>>
> > > > >>>> Seems
> > > > >>>>
> > > >
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > > > >>>> depends on org.netbeans.modules.python.debugger.utils.MiscStatic
> > > which
> > > > >>>> appears to not be present. Did this get left out in the
> donation?
> > > I
> > > > don't
> > > > >>>> see it in the hg.netbeans.org main/contrib version of this but
> do
> > > > find
> > > > >>>> it in the maven version.
> > > > >>>>
> > > > >>>> Also seems to be missing package
> > > > >>>> org.netbeans.modules.python.source.scopes (also found in the
> maven
> > > > version)
> > > > >>>> with which includes but not limited to classes like SymbolTable
> > and
> > > > >>>> SymInfo. Are these the sort of files that may get removed as
> part
> > > of
> > > > >>>> donation and/or IP sanitizing of the donation?
> > > > >>>>
> > > > >>>> -do-compile:
> > > > >>>> [nb-javac] Compiling 75 source files to
> > > > >>>> C:\netbeans\python\python.debugger\build\classes
> > > > >>>> [repeat] warning: [options] bootstrap class path not set in
> > > > >>>> conjunction with -source 7
> > > > >>>> [repeat]
> > > > >>>>
> > > >
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > > > >>>> in org.xml.sax.helpers has been deprecated
> > > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > > > >>>> [repeat] ^
> > > > >>>> [repeat]
> > > > >>>>
> > > >
> > >
> >
> C:\git\netbeans.ebresie\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > > > >>>> [repeat] import
> > > > >>>> org.netbeans.modules.python.debugger.utils.MiscStatic;
> > > > >>>> [repeat] ^
> > > > >>>> [repeat] symbol: class MiscStatic
> > > > >>>> [repeat] location: package
> > > > >>>> org.netbeans.modules.python.debugger.utils
> > > > >>>> [repeat]
> > > > >>>>
> > > >
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > > > >>>> in org.xml.sax.helpers has been deprecated
> > > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > > > >>>> [repeat] ^
> > > > >>>> [repeat] 1 error
> > > > >>>> [repeat] 3 warnings
> > > > >>>> [nbmerge] Failed to build target: all-python.debugger
> > > > >>>>
> > > > >>>> BUILD FAILED
> > > > >>>> C:\netbeans\nbbuild\build.xml:643: The following error occurred
> > > while
> > > > >>>> executing this line:
> > > > >>>> C:\netbeans\nbbuild\build.xml:638: The following error occurred
> > > while
> > > > >>>> executing this line:
> > > > >>>> C:\netbeans\nbbuild\build.xml:685: The following error occurred
> > > while
> > > > >>>> executing this line:
> > > > >>>> C:\netbeans\nbbuild\templates\common.xml:206: Compile failed;
> see
> > > the
> > > > >>>> compiler error output for details.
> > > > >>>>
> > > > >>>> On a separate note...
> > > > >>>> However I was thinking maybe my depends may not be right.
> > > Presently I
> > > > >>>> have
> > > > >>>>
> > > > >>>> nb.cluster.python.depends=\
> > > > >>>> ${clusters.config.platform.list},\
> > > > >>>> nb.cluster.ide,\
> > > > >>>> nb.cluster.nb
> > > > >>>>
> > > > >>>> But not sure if that's overkill. Any recommendations on these?
> > > > >>>>
> > > > >>>>
> > > > >>>> Eric Bresie
> > > > >>>> ebresie@gmail.com
> > > > >>>>
> > > > >>>
> > > >
> > >
> >
>
--
Eric Bresie
ebresie@gmail.com
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Donated means Oracle donated it, the code is now made available to us. We
need to do the relicensing to Apache ourselves in Apache, why would Oracle
be the one doing that?
Gj
On Wed, 30 Dec 2020 at 20:48, Eric Bresie <eb...@gmail.com> wrote:
> Agree this is very much a work in progress but still need help on resolving
> these issues especially the licensing part of this.
>
> I thought "donated" nbpython / contrib\*python* code (in the hg repository)
> had licenses updated but assuming that may not be the case. What needs to
> done to resolve these license problems?
>
> (1) Does Oracle still have to scrub the files and update the licenses in
> each file in some way? Or is what's in the hg repository good enough to
> work with and make changed to align with Apache licensing needs?
> (2) Does the "JYTHON" license need to be included in the codebase somewhere
> for use in documenting the licenses used in some (i.e. jython) code
> context?
> (3) What license should be used in each of these files? Assume there is
> the original nbPython used licenses, then the "netbeans\contrib" used
> licenses, and the "apache" licenses.
> (4) Is there a tool to go through each file and update this in a batch
> way? I seem to recall some form of "licensechanger" but not familiar with
> how it works.
> Is there
> Eric Bresie
> ebresie@gmail.com
>
>
> On Wed, Dec 30, 2020 at 1:05 PM Geertjan Wielenga
> <ge...@googlemail.com.invalid> wrote:
>
> > I’d say it is a lot tol early to try to get this code into our GitHub.
> >
> > Gj
> >
> >
> > On Wed, 30 Dec 2020 at 19:19, Eric Bresie <eb...@gmail.com> wrote:
> >
> > > There also seems to be failure on ergonomics tests like the below but
> I'm
> > > not sure why this is happening. Maybe a failure elsewhere. Any
> ideas?
> > >
> > > [junit] WARNING [org.netbeans.TopSecurityManager]: use of system
> > > property netbeans.home has been obsoleted in favor of
> > > InstalledFileLocator/Places at
> > >
> > >
> >
> org.netbeans.modules.ide.ergonomics.CommonServersBase.doGetAllInstancesErgo(CommonServersBase.java:90)
> > > 10108 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > Iterating ergo
> > > 10109 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > ergo: Amazon Beanstalk
> > > 10110 [junit] INFO [commonserversbase.testGetAllCloudWizardsErgo]:
> > > Iteration done for ergo
> > > *10111 [junit] Test
> > > org.netbeans.modules.ide.ergonomics.DynamicVerifyTest FAILED*
> > > 10112 [junit] Dec 30, 2020 5:38:14 PM
> > > org.netbeans.core.startup.NbEvents logged
> > > 10113 [junit] INFO: Warning - could not install some modules:
> > > 10114 [junit] org.netbeans.modules.editor.lib2 - No module
> > > providing the capability org.netbeans.modules.editor.actions could be
> > > found.
> > > 10115 [junit] org.netbeans.modules.editor.lib - The module
> > > org.netbeans.modules.editor.lib2 would also need to be installed.
> > >
> > >
> > > BUILD FAILED
> > >
> 10234/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:723:
> > > The following error occurred while executing this line:
> > >
> 10235/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:716:
> > > The following error occurred while executing this line:
> > >
> 10236/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:750:
> > > The following error occurred while executing this line:
> > >
> 10237/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:747:
> > > Some tests failed; see details above.
> > > 10238
> > > 10239Total time: 1 minute 24 seconds
> > > 10240The command "ant $OPTS -f ergonomics/ide.ergonomics test
> > > -Dtest.config=commit" exited with 1.
> > >
> > > Eric Bresie
> > > ebresie@gmail.com
> > >
> > >
> > > On Wed, Dec 30, 2020 at 12:03 PM Eric Bresie <eb...@gmail.com>
> wrote:
> > >
> > > > Okay after some synching with upstream and ovecoming some apparent
> > github
> > > > pr isms ...I have created a "draft PR" available at
> > > > https://github.com/apache/netbeans/pull/2622
> > > >
> > > > However, it looks that some of the CI checks are failing as I kind of
> > > > expected.
> > > >
> > > > Some seem to be related to licensing like the below.
> > > >
> > > > I assume some of this has to do with
> > > > (1) Jython license details being missing,
> > > > (2) Some "Oracle" licensing being present (assume this may be part of
> > the
> > > > donation process being worked), and some
> > > > (3) Failure to document licenses in applicable locations
> > > > (4) License formatting issues
> > > >
> > > > Can anyone familiar with handling licensing provide some input on how
> > to
> > > > handle these?
> > > >
> > > > Build licensing issues
> > > > (1) This:
> > > >
> > > > verify-libs-and-licenses:
> > > > 1226[verifylibsandlicenses]
> > >
> >
> /home/travis/build/apache/netbeans/nbbuild/build/verifylibsandlicenses.xml:
> > > 3 failures out of 5 tests
> > > > 1227
> > > > 1228BUILD FAILED
> > > > 1229/home/travis/build/apache/netbeans/nbbuild/build.xml:1642: Failed
> > > VerifyLibsAndLicenses test(s):
> > > > 1230Some binaries were found outside of <module>/external/
> directories
> > > (edit nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries as
> > > needed)
> > > >
> > >
> >
> 1231python/python.samples/src/org/netbeans/modules/python/samples/JySwingProject.zip
> > > >
> > >
> >
> 1232python/python.samples/src/org/netbeans/modules/python/samples/PLYDemoProject.zip
> > > >
> > >
> >
> 1233python/python.samples/src/org/netbeans/modules/python/samples/PyThreadsProject.zip
> > > > 1234Some license files were badly formatted
> > > > 1235python/o.jython.distro/external/jython-2.7.0-license.txt has a
> > > trailing space on line #61
> > > > 1236Some license files have incorrect headers
> > > > 1237python/o.jython/external/jython-parser.jar does not appear to
> > > include a version number
> > > > 1238python/o.jython/external/jython-parser.jar is not associated with
> > > any license file
> > > > 1239python/o.jython.distro/external/jython-2.7.0-license.txt refers
> to
> > > nonexistent nbbuild/licenses/Jython
> > > > 1240python/python.editor/external/preindexed.zip does not appear to
> > > include a version number
> > > > 1241python/python.editor/external/preindexed.zip is not associated
> with
> > > any license file
> > > > 1242
> > > > 1243Total time: 1 minute 30 seconds
> > > > 1244The command "ant verify-libs-and-licenses
> > > -Dverify-libs-and-licenses.haltonfailure=true -Dmetabuild.jsonurl=
> > >
> >
> https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
> > "
> > > exited with 1.
> > > >
> > > > <https://github.com/apache/netbeans/pull/2622>
> > > >
> > > > (2) And like this
> > > >
> > > > BUILD FAILED
> > > > 550/home/travis/build/apache/netbeans/scratch/nbbuild/build.xml:2227:
> > > Failed Rat test(s):
> > > > 551Unapproved license in 549 file(s)
> > > > 552
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.debugger/src/org/netbeans/modules/python/debugger/config/NetBeansFrontend.java
> > > > 553
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.project/src/org/netbeans/modules/python/project/ui/actions/RunSingleCommand.java
> > > > 554
> > >
> >
> https://github.com/apache/netbeans/tree/master/python/python.editor/src/org/netbeans/modules/python/editor/wizards/pypackage/PythonPackageWizardIterator.java
> > > >
> > > >
> > > >
> > > > Eric Bresie
> > > > ebresie@gmail.com
> > > >
> > > >
> > > > On Tue, Dec 29, 2020 at 12:28 PM Eric Bresie <eb...@gmail.com>
> > wrote:
> > > >
> > > >> Okay...I was able to get it to compile and run successfully.
> Haven't
> > > >> done too much testing yet but seems in good shape so far.
> > > >>
> > > >> Assume this may be in support of NETBEANS-4538
> > > >>
> > > >> So wanted to see what may be needed to go forward with this.
> > > >>
> > > >> It is still unclear to be about
> > > >> (1) How to handle the missing files mentioned earlier (see earlier
> > email
> > > >> for more specifics)
> > > >> (2) Is there expected to be any further "donation" activities which
> > may
> > > >> make some of this be overcome by other updates coming down the line?
> > > >> (3) Is Oracle/Apache legal still working anything prior to
> acceptance?
> > > >> (4) Since much of this is derived from the nbpython project, is
> there
> > > any
> > > >> concerns from the nbpython project team?
> > > >> a) I've had difficult contacting anyone due to stale or
> > > >> inaccessible web sites or comms means
> > > >> b) I'm hoping some folks on the list may be able to help here
> > > >> (5) What needs to be done to include this incoming
> > > >> build/release/milestone/components/etc.?
> > > >>
> > > >> Assume one of the first steps would be check in and raise a PR but
> due
> > > to
> > > >> my inexperience in this sort of major git activities, I may need
> some
> > > help
> > > >> on this as I don't believe what I've done so far is quite right.
> > > >>
> > > >> When pushing my local "python" branch changes to my fork (see
> > > >> https://github.com/ebresie/netbeans) on a remote "python" branch
> > there
> > > >> was a mixture of activities going on at the same time when trying to
> > > check
> > > >> some of this stuff in. Specifically there were changes including
> (1)
> > > >> periodic upstream merge of recent change, (2) a separate cnd
> > > >> activities[which should have been a separate branch but
> unfortunately
> > > got
> > > >> included with previous updates] , and (3) mixture of maven vs
> > non-maven
> > > >> python versions.
> > > >>
> > > >> So all that is to say, this makes creating a PR rather difficult..
> > How
> > > >> can I reconcile these issues in support of PR creation? Is there a
> > way
> > > to
> > > >> exclude these sorts of things in github PR (i.e. can I somehow
> delete
> > > the
> > > >> other commits)? Do I need some squashed or some other git
> activities?
> > > Do
> > > >> I need to somehow revert back to state prior to python getting
> merged
> > > and
> > > >> without the "cnd" inclusion and then somehow merge the python
> changes
> > in
> > > >> some way on a fresh attempt? Git help is appreciated.
> > > >>
> > > >> Eric Bresie
> > > >> ebresie@gmail.com
> > > >>
> > > >>
> > > >> On Mon, Dec 28, 2020 at 8:30 PM Eric Bresie <eb...@gmail.com>
> > wrote:
> > > >>
> > > >>> Also in the python.editor module, in the scripts is a missing
> > > >>> "coverage.py" file as well.
> > > >>>
> > > >>> I believe this is related to
> > > >>> http://nedbatchelder.com/code/modules/coverage.html
> > > >>> Or more recently https://coverage.readthedocs.io/en/latest/
> > > >>>
> > > >>> Assume this one may be left out on purpose. Assume can either (1)
> > > >>> remove references to it elsewhere (where it's getting copied), (2)
> > > find a
> > > >>> way to "import" as an external element of some type or (3) replace
> it
> > > in
> > > >>> some other way.
> > > >>>
> > > >>> Eric Bresie
> > > >>> ebresie@gmail.com
> > > >>>
> > > >>>
> > > >>> On Mon, Dec 28, 2020 at 6:56 PM Eric Bresie <eb...@gmail.com>
> > wrote:
> > > >>>
> > > >>>> Okay...after a few failed attempts and a few more tweaks (I had to
> > > >>>> change the location in the build.xml for each of the projects to
> > > point to
> > > >>>> the python cluster subdirectory)...I was finally able to get it to
> > > build up
> > > >>>> to a point...
> > > >>>>
> > > >>>> However ended with errors like the below.
> > > >>>>
> > > >>>> Seems
> > > >>>>
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > > >>>> depends on org.netbeans.modules.python.debugger.utils.MiscStatic
> > which
> > > >>>> appears to not be present. Did this get left out in the donation?
> > I
> > > don't
> > > >>>> see it in the hg.netbeans.org main/contrib version of this but do
> > > find
> > > >>>> it in the maven version.
> > > >>>>
> > > >>>> Also seems to be missing package
> > > >>>> org.netbeans.modules.python.source.scopes (also found in the maven
> > > version)
> > > >>>> with which includes but not limited to classes like SymbolTable
> and
> > > >>>> SymInfo. Are these the sort of files that may get removed as part
> > of
> > > >>>> donation and/or IP sanitizing of the donation?
> > > >>>>
> > > >>>> -do-compile:
> > > >>>> [nb-javac] Compiling 75 source files to
> > > >>>> C:\netbeans\python\python.debugger\build\classes
> > > >>>> [repeat] warning: [options] bootstrap class path not set in
> > > >>>> conjunction with -source 7
> > > >>>> [repeat]
> > > >>>>
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > > >>>> in org.xml.sax.helpers has been deprecated
> > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > > >>>> [repeat] ^
> > > >>>> [repeat]
> > > >>>>
> > >
> >
> C:\git\netbeans.ebresie\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\gui\PythonDebugContainer.java
> > > >>>> [repeat] import
> > > >>>> org.netbeans.modules.python.debugger.utils.MiscStatic;
> > > >>>> [repeat] ^
> > > >>>> [repeat] symbol: class MiscStatic
> > > >>>> [repeat] location: package
> > > >>>> org.netbeans.modules.python.debugger.utils
> > > >>>> [repeat]
> > > >>>>
> > >
> >
> C:\netbeans\python\python.debugger\src\org\netbeans\modules\python\debugger\backend\JPyDebugXmlParser.javLReaderFactory
> > > >>>> in org.xml.sax.helpers has been deprecated
> > > >>>> [repeat] import org.xml.sax.helpers.XMLReaderFactory;
> > > >>>> [repeat] ^
> > > >>>> [repeat] 1 error
> > > >>>> [repeat] 3 warnings
> > > >>>> [nbmerge] Failed to build target: all-python.debugger
> > > >>>>
> > > >>>> BUILD FAILED
> > > >>>> C:\netbeans\nbbuild\build.xml:643: The following error occurred
> > while
> > > >>>> executing this line:
> > > >>>> C:\netbeans\nbbuild\build.xml:638: The following error occurred
> > while
> > > >>>> executing this line:
> > > >>>> C:\netbeans\nbbuild\build.xml:685: The following error occurred
> > while
> > > >>>> executing this line:
> > > >>>> C:\netbeans\nbbuild\templates\common.xml:206: Compile failed; see
> > the
> > > >>>> compiler error output for details.
> > > >>>>
> > > >>>> On a separate note...
> > > >>>> However I was thinking maybe my depends may not be right.
> > Presently I
> > > >>>> have
> > > >>>>
> > > >>>> nb.cluster.python.depends=\
> > > >>>> ${clusters.config.platform.list},\
> > > >>>> nb.cluster.ide,\
> > > >>>> nb.cluster.nb
> > > >>>>
> > > >>>> But not sure if that's overkill. Any recommendations on these?
> > > >>>>
> > > >>>>
> > > >>>> Eric Bresie
> > > >>>> ebresie@gmail.com
> > > >>>>
> > > >>>
> > >
> >
>
Re: Work on Python [NETBEANS-4538] - Licenses for Python Code
Posted by Brad Walker <bw...@musings.com>.
Hey Eric,
For the C/C++ CND module, I cleaned up a lot of license issues that were
remaining.
I'm happy to help clean up the license headers on the Python code if that
helps you.
FYI,
-brad w.
On Wed, Dec 30, 2020 at 12:49 PM Eric Bresie <eb...@gmail.com> wrote:
> Agree this is very much a work in progress but still need help on resolving
> these issues especially the licensing part of this.
>
> I thought "donated" nbpython / contrib\*python* code (in the hg repository)
> had licenses updated but assuming that may not be the case. What needs to
> done to resolve these license problems?
>
>