[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2428: Fix Ballista executing during plan

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2428:
URL: https://github.com/apache/arrow-datafusion/pull/2428#discussion_r863846420


##########
ballista/rust/core/src/execution_plans/distributed_query.rs:
##########
@@ -168,15 +169,6 @@ impl<T: 'static + AsLogicalPlan> ExecutionPlan for DistributedQueryExec<T> {
     ) -> Result<SendableRecordBatchStream> {
         assert_eq!(0, partition);
 
-        info!("Connecting to Ballista scheduler at {}", self.scheduler_url);
-        // TODO reuse the scheduler to avoid connecting to the Ballista scheduler again and again
-
-        let mut scheduler = SchedulerGrpcClient::connect(self.scheduler_url.clone())
-            .await
-            .map_err(|e| DataFusionError::Execution(format!("{:?}", e)))?;
-
-        let schema: Schema = self.plan.schema().as_ref().clone().into();
-
         let mut buf: Vec<u8> = vec![];

Review Comment:
   I recommend reviewing this without whitespace
   
   https://github.com/apache/arrow-datafusion/pull/2428/files?w=1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org