You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2024/03/05 05:38:34 UTC

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21088


Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................

IMPALA-12802: Support ALTER TABLE for JDBC tables

IMPALA-12793 changes the syntax for creating JDBC table. The
configurations of connection credentials - url, username, password,
jdbc driver, etc, are set as table properties.

This patch allows user to change these table properties, or edit
columns via ALTER TABLE statement.

Testing:
 - Added frontend analysis unit-tests.
 - Added end-to-end unit-test.
 - Passed Core tests

Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetPartitionSpecStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test
33 files changed, 453 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/21088/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 4:

Thanks Joe


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 04:07:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15399/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2024 06:03:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 4: Code-Review+2

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 03:07:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21088/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/21088/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@157
PS2, Line 157:         throw new AnalysisException(String.format("Unsetting the '%s' table property is " +
line too long (91 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2024 05:39:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................

IMPALA-12802: Support ALTER TABLE for JDBC tables

IMPALA-12793 changes the syntax for creating JDBC table. The
configurations of connection credentials - url, username, password,
jdbc driver, etc, are set as table properties.

This patch allows user to change these table properties, or edit
columns via ALTER TABLE statement.

Testing:
 - Added frontend analysis unit-tests.
 - Added end-to-end unit-test.
 - Passed Core tests

Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetPartitionSpecStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test
33 files changed, 452 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/21088/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 4:

(4 comments)

Thanks Joe for your feedback.

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java@49
PS3, Line 49: E
> Nit: extra space at the beginning
fixed


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@39
PS3, Line 39:   @Override
            :   public void analyze(Analyzer analyzer) throws 
> I think this class isn't used directly, so another option is for this to be
Changed the class as abstract class


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@228
PS3, Line 228: change internal properties of D
> Nit: Maybe this should be "Cannot change internal properties of DataSource"
fixed the comments


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@148
PS3, Line 148: unset internal properties of Da
> Nit: maybe say "internal properties" to emphasize that these are set by us.
fixed it.



-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2024 00:46:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15525/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2024 01:09:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15400/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2024 06:14:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java@49
PS3, Line 49:  
Nit: extra space at the beginning


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@39
PS3, Line 39:   @Override
            :   public String getOperation() { return "SET"; }
I think this class isn't used directly, so another option is for this to be an abstract class that doesn't specify this and require subclasses to implement it.


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@228
PS3, Line 228: unset properties of DataSource.
Nit: Maybe this should be "Cannot change internal properties of DataSource"


http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@148
PS3, Line 148: unset properties of DataSource.
Nit: maybe say "internal properties" to emphasize that these are set by us.



-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2024 23:27:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:01:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................

IMPALA-12802: Support ALTER TABLE for JDBC tables

IMPALA-12793 changes the syntax for creating JDBC table. The
configurations of connection credentials - url, username, password,
jdbc driver, etc, are set as table properties.

This patch allows user to change these table properties, or edit
columns via ALTER TABLE statement.

Testing:
 - Added frontend analysis unit-tests.
 - Added end-to-end unit-test.
 - Passed Core tests

Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Reviewed-on: http://gerrit.cloudera.org:8080/21088
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetPartitionSpecStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test
33 files changed, 452 insertions(+), 35 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10391/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 04:06:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gs...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 04:06:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12802: Support ALTER TABLE for JDBC tables

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21088 )

Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables
......................................................................

IMPALA-12802: Support ALTER TABLE for JDBC tables

IMPALA-12793 changes the syntax for creating JDBC table. The
configurations of connection credentials - url, username, password,
jdbc driver, etc, are set as table properties.

This patch allows user to change these table properties, or edit
columns via ALTER TABLE statement.

Testing:
 - Added frontend analysis unit-tests.
 - Added end-to-end unit-test.
 - Passed Core tests

Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetCachedStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetColumnStats.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetPartitionSpecStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetRowFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test
33 files changed, 453 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/21088/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>