You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/02 23:22:35 UTC

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4956: Make plugin manager to load plugins based on environment variables

fx19880617 opened a new pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956
 
 
   Make plugin manager to take 2 env variables:
   **plugins.root.directory** and **plugins.loading** .
   So user could specify the plugins to load based on their own needs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/499f03f72fbccc17e2ff1e092e69dab8e4dfa900?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `26.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   + Coverage     57.16%   57.19%   +0.02%     
     Complexity       12       12              
   ============================================
     Files          1159     1159              
     Lines         61778    61830      +52     
     Branches       9112     9117       +5     
   ============================================
   + Hits          35315    35361      +46     
   + Misses        23873    23870       -3     
   - Partials       2590     2599       +9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ools/admin/command/StreamAvroIntoKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RyZWFtQXZyb0ludG9LYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/tools/streams/AirlineDataStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvQWlybGluZURhdGFTdHJlYW0uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `93.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/perf/PerfBenchmarkDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya0RyaXZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | [...java/org/apache/pinot/tools/PinotToolLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1Bpbm90VG9vbExhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/streams/MeetupRsvpStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvTWVldHVwUnN2cFN0cmVhbS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [33 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [499f03f...fcf1d5b](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io commented on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/fd75576104df90c7d1ef3b2ec584bea7dab64118?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `29.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   - Coverage     57.13%   57.12%   -0.01%     
     Complexity       12       12              
   ============================================
     Files          1159     1159              
     Lines         61778    61802      +24     
     Branches       9112     9116       +4     
   ============================================
   + Hits          35294    35307      +13     
   - Misses        23890    23902      +12     
   + Partials       2594     2593       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ava/org/apache/pinot/spi/plugin/PluginManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbk1hbmFnZXIuamF2YQ==) | `36.76% <29.16%> (-6.42%)` | `0 <0> (ø)` | |
   | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `58.06% <0%> (-12.91%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `46.34% <0%> (-8.54%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `60.21% <0%> (-7.53%)` | `0% <0%> (ø)` | |
   | [...pache/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NvcnRlZFJhbmdlSW50ZXJzZWN0aW9uLmphdmE=) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | |
   | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `43.01% <0%> (-6.46%)` | `0% <0%> (ø)` | |
   | [...ore/startree/v2/builder/BaseSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL0Jhc2VTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `90.52% <0%> (-4.74%)` | `0% <0%> (ø)` | |
   | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `75% <0%> (-4.17%)` | `0% <0%> (ø)` | |
   | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `46.03% <0%> (-3.18%)` | `0% <0%> (ø)` | |
   | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-2.57%)` | `0% <0%> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [fd75576...8059fdc](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362986701
 
 

 ##########
 File path: pinot-tools/pom.xml
 ##########
 @@ -165,6 +163,7 @@
                 <extraArguments>
                   <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/pinot-tools-log4j2.xml</extraArgument>
+                  <extraArgument>-Dplugins.dir=plugins</extraArgument>
 
 Review comment:
   can we make it absolute? I think there is a variable set in the script to get the basedir

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362680117
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,59 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  public static final String PLUGINS_ROOT_DIR_ENV_VAR = "plugins.root.directory";
+  public static final String PLUGINS_LOADING_ENV_VAR = "plugins.loading";
   public static final String DEFAULT_PLUGIN_NAME = "DEFAULT";
+  private static final String JAR_FILE_EXTENSION = "jar";
   static PluginManager PLUGIN_MANAGER = new PluginManager();
 
   Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+  String pluginsRootDir;
+  String pluginsLoading;
 
   private PluginManager() {
     _registry.put(new Plugin(DEFAULT_PLUGIN_NAME), createClassLoader(Collections.emptyList()));
+    pluginsRootDir = System.getenv(PLUGINS_ROOT_DIR_ENV_VAR);
+    pluginsLoading = System.getenv(PLUGINS_LOADING_ENV_VAR);
+    init(pluginsRootDir, pluginsLoading);
+  }
+
+  private void init(String pluginsRootDir, String pluginsLoading) {
+    if (StringUtils.isEmpty(pluginsRootDir)) {
+      LOGGER.info("No plugins root dir specified from environment variable");
+      return;
+    } else {
+      LOGGER.info("Plugins root dir is [{}]", pluginsRootDir);
+    }
+    Collection<File> jarFiles = FileUtils.listFiles(new File(pluginsRootDir), new String[]{JAR_FILE_EXTENSION}, true);
+    List<String> pluginsToLoad = null;
+    if (!StringUtils.isEmpty(pluginsLoading)) {
+      pluginsToLoad = Arrays.asList(pluginsLoading.split(","));
+      LOGGER.info("Trying to load plugins: [{}]", Arrays.toString(pluginsToLoad.toArray()));
+    } else {
+      LOGGER.info("No pluginsLoading specified, trying to load all plugins: [{}]", Arrays.toString(jarFiles.toArray()));
 
 Review comment:
   Just say loading all plugins. use plugins.include to customize

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362679950
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,59 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  public static final String PLUGINS_ROOT_DIR_ENV_VAR = "plugins.root.directory";
+  public static final String PLUGINS_LOADING_ENV_VAR = "plugins.loading";
   public static final String DEFAULT_PLUGIN_NAME = "DEFAULT";
+  private static final String JAR_FILE_EXTENSION = "jar";
   static PluginManager PLUGIN_MANAGER = new PluginManager();
 
   Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+  String pluginsRootDir;
+  String pluginsLoading;
 
   private PluginManager() {
     _registry.put(new Plugin(DEFAULT_PLUGIN_NAME), createClassLoader(Collections.emptyList()));
+    pluginsRootDir = System.getenv(PLUGINS_ROOT_DIR_ENV_VAR);
+    pluginsLoading = System.getenv(PLUGINS_LOADING_ENV_VAR);
+    init(pluginsRootDir, pluginsLoading);
+  }
+
+  private void init(String pluginsRootDir, String pluginsLoading) {
+    if (StringUtils.isEmpty(pluginsRootDir)) {
+      LOGGER.info("No plugins root dir specified from environment variable");
 
 Review comment:
   change to "Env variable 'PLUGINS_ROOT_DIR_ENV_VAR' is not specified. Set this variable to load additional plugins"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/499f03f72fbccc17e2ff1e092e69dab8e4dfa900?src=pr&el=desc) will **increase** coverage by `0.49%`.
   > The diff coverage is `25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   + Coverage     57.16%   57.66%   +0.49%     
     Complexity       12       12              
   ============================================
     Files          1159     1143      -16     
     Lines         61778    61315     -463     
     Branches       9112     9055      -57     
   ============================================
   + Hits          35315    35356      +41     
   + Misses        23873    23335     -538     
   - Partials       2590     2624      +34
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...java/org/apache/pinot/spi/stream/StreamConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbUNvbmZpZy5qYXZh) | `92.59% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/tools/streams/AirlineDataStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvQWlybGluZURhdGFTdHJlYW0uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ools/admin/command/StreamAvroIntoKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RyZWFtQXZyb0ludG9LYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `93.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...g/apache/pinot/tools/perf/PerfBenchmarkDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya0RyaXZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | [...java/org/apache/pinot/tools/PinotToolLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1Bpbm90VG9vbExhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...inot/tools/admin/command/CreateSegmentCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQ3JlYXRlU2VnbWVudENvbW1hbmQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ava/org/apache/pinot/tools/RealtimeQuickStart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1JlYWx0aW1lUXVpY2tTdGFydC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [59 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [499f03f...7cc3cac](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/020040791c4f1f83e4953637ba95e33f8d252470?src=pr&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `26.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   + Coverage     57.11%   57.21%   +0.09%     
     Complexity       12       12              
   ============================================
     Files          1159     1159              
     Lines         61778    61830      +52     
     Branches       9112     9117       +5     
   ============================================
   + Hits          35282    35373      +91     
   + Misses        23896    23860      -36     
   + Partials       2600     2597       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ools/admin/command/StreamAvroIntoKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RyZWFtQXZyb0ludG9LYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/tools/streams/AirlineDataStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvQWlybGluZURhdGFTdHJlYW0uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `93.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/perf/PerfBenchmarkDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya0RyaXZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | [...java/org/apache/pinot/tools/PinotToolLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1Bpbm90VG9vbExhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/streams/MeetupRsvpStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvTWVldHVwUnN2cFN0cmVhbS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [0200407...98f5eb9](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/020040791c4f1f83e4953637ba95e33f8d252470?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `34.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   + Coverage     57.11%   57.12%   +0.01%     
     Complexity       12       12              
   ============================================
     Files          1159     1159              
     Lines         61778    61821      +43     
     Branches       9112     9116       +4     
   ============================================
   + Hits          35282    35315      +33     
   - Misses        23896    23907      +11     
   + Partials       2600     2599       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | [...ava/org/apache/pinot/spi/plugin/PluginManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbk1hbmFnZXIuamF2YQ==) | `38.37% <35.71%> (-4.81%)` | `0 <0> (ø)` | |
   | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `36.58% <0%> (-12.2%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `56.09% <0%> (-6.1%)` | `0% <0%> (ø)` | |
   | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `75% <0%> (-4.17%)` | `0% <0%> (ø)` | |
   | [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `29.48% <0%> (-2.57%)` | `0% <0%> (ø)` | |
   | [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `47.61% <0%> (-2.39%)` | `0% <0%> (ø)` | |
   | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `85.88% <0%> (-1.85%)` | `0% <0%> (ø)` | |
   | [.../java/org/apache/pinot/spi/data/TimeFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9UaW1lRmllbGRTcGVjLmphdmE=) | `92.59% <0%> (-1.24%)` | `0% <0%> (ø)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [0200407...ac6272e](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/020040791c4f1f83e4953637ba95e33f8d252470?src=pr&el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `32.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4956      +/-   ##
   ============================================
   + Coverage     57.11%   57.19%   +0.07%     
     Complexity       12       12              
   ============================================
     Files          1159     1159              
     Lines         61778    61828      +50     
     Branches       9112     9117       +5     
   ============================================
   + Hits          35282    35360      +78     
   + Misses        23896    23877      -19     
   + Partials       2600     2591       -9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ools/admin/command/StreamAvroIntoKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RyZWFtQXZyb0ludG9LYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/tools/streams/AirlineDataStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvQWlybGluZURhdGFTdHJlYW0uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/streams/MeetupRsvpStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvTWVldHVwUnN2cFN0cmVhbS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `93.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...java/org/apache/pinot/tools/PinotToolLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1Bpbm90VG9vbExhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [0200407...6f33830](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362675953
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,59 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  public static final String PLUGINS_ROOT_DIR_ENV_VAR = "plugins.root.directory";
+  public static final String PLUGINS_LOADING_ENV_VAR = "plugins.loading";
 
 Review comment:
   plugins.include

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362985904
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,89 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  public static final String PLUGINS_DIR_ENV_VAR = "plugins.dir";
 
 Review comment:
   we are looking for these in system property not env. Let's just call it PLUGINS_DIR_PROPERTY_NAME.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362676123
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,59 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  public static final String PLUGINS_ROOT_DIR_ENV_VAR = "plugins.root.directory";
 
 Review comment:
   plugins.dir

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362677030
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -49,6 +89,7 @@ private PluginManager() {
    * @param directory
    */
   public void load(String pluginName, File directory) {
+    LOGGER.info("Trying to load plugin [{}] from location [{}]", pluginName, directory);
 
 Review comment:
   Add another log to say that the plugin was loaded successfully. Maybe do this in the caller and catch the exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362986916
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
 ##########
 @@ -50,6 +51,7 @@ private HybridQuickstart() {
 
   public static void main(String[] args)
       throws Exception {
+    PluginManager.get().init();
 
 Review comment:
   add a comment on why we need this for now and add a todo to delete this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 merged pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362677133
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,59 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  public static final String PLUGINS_ROOT_DIR_ENV_VAR = "plugins.root.directory";
+  public static final String PLUGINS_LOADING_ENV_VAR = "plugins.loading";
   public static final String DEFAULT_PLUGIN_NAME = "DEFAULT";
+  private static final String JAR_FILE_EXTENSION = "jar";
   static PluginManager PLUGIN_MANAGER = new PluginManager();
 
   Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+  String pluginsRootDir;
+  String pluginsLoading;
 
   private PluginManager() {
     _registry.put(new Plugin(DEFAULT_PLUGIN_NAME), createClassLoader(Collections.emptyList()));
+    pluginsRootDir = System.getenv(PLUGINS_ROOT_DIR_ENV_VAR);
+    pluginsLoading = System.getenv(PLUGINS_LOADING_ENV_VAR);
+    init(pluginsRootDir, pluginsLoading);
+  }
+
+  private void init(String pluginsRootDir, String pluginsLoading) {
+    if (StringUtils.isEmpty(pluginsRootDir)) {
+      LOGGER.info("No plugins root dir specified from environment variable");
+      return;
+    } else {
+      LOGGER.info("Plugins root dir is [{}]", pluginsRootDir);
+    }
+    Collection<File> jarFiles = FileUtils.listFiles(new File(pluginsRootDir), new String[]{JAR_FILE_EXTENSION}, true);
+    List<String> pluginsToLoad = null;
+    if (!StringUtils.isEmpty(pluginsLoading)) {
+      pluginsToLoad = Arrays.asList(pluginsLoading.split(","));
+      LOGGER.info("Trying to load plugins: [{}]", Arrays.toString(pluginsToLoad.toArray()));
+    } else {
+      LOGGER.info("No pluginsLoading specified, trying to load all plugins: [{}]", Arrays.toString(jarFiles.toArray()));
+    }
+    for (File jarFile : jarFiles) {
+      File pluginDir = jarFile.getParentFile();
+      String pluginName = pluginDir.getName();
+      if (pluginsToLoad != null) {
+        if (!pluginsToLoad.contains(pluginName)) {
+          continue;
+        }
+      }
+      load(pluginName, pluginDir);
 
 Review comment:
   try catch since the creating classloader might result in a runtime exception

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362986199
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -28,19 +28,89 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 
 public class PluginManager {
 
+  public static final String PLUGINS_DIR_ENV_VAR = "plugins.dir";
+  public static final String PLUGINS_INCLUDE_ENV_VAR = "plugins.include";
   public static final String DEFAULT_PLUGIN_NAME = "DEFAULT";
-  static PluginManager PLUGIN_MANAGER = new PluginManager();
+  private static final Logger LOGGER = LoggerFactory.getLogger(PluginManager.class);
+  private static final String JAR_FILE_EXTENSION = "jar";
+  private static PluginManager PLUGIN_MANAGER = new PluginManager();
 
-  Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+  private Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+  private String _pluginsRootDir;
+  private String _pluginsInclude;
+  private boolean _initialized = false;
 
   private PluginManager() {
     _registry.put(new Plugin(DEFAULT_PLUGIN_NAME), createClassLoader(Collections.emptyList()));
+    init();
+  }
+
+  public synchronized void init() {
+    if (_initialized) {
+      return;
+    }
+    try {
+      _pluginsRootDir = System.getProperty(PLUGINS_DIR_ENV_VAR);
+    } catch (Exception e) {
+      LOGGER.error("Failed to load env variable {}", PLUGINS_DIR_ENV_VAR, e);
+      _pluginsRootDir = null;
+    }
+    try {
+      _pluginsInclude = System.getProperty(PLUGINS_INCLUDE_ENV_VAR);
+    } catch (Exception e) {
+      LOGGER.error("Failed to load env variable {}", PLUGINS_INCLUDE_ENV_VAR, e);
+      _pluginsInclude = null;
+    }
+    init(_pluginsRootDir, _pluginsInclude);
+    _initialized = true;
+  }
+
+  private void init(String pluginsRootDir, String pluginsLoading) {
 
 Review comment:
   pluginsLoading -- > pluginsInclude

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4956: Make plugin manager to load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#issuecomment-570407207
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=h1) Report
   > Merging [#4956](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/020040791c4f1f83e4953637ba95e33f8d252470?src=pr&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `31.91%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4956/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #4956      +/-   ##
   ===========================================
   + Coverage     57.11%   57.2%   +0.09%     
     Complexity       12      12              
   ===========================================
     Files          1159    1159              
     Lines         61778   61825      +47     
     Branches       9112    9116       +4     
   ===========================================
   + Hits          35282   35367      +85     
   + Misses        23896   23867      -29     
   + Partials       2600    2591       -9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ools/admin/command/StreamAvroIntoKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RyZWFtQXZyb0ludG9LYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../apache/pinot/tools/streams/AirlineDataStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvQWlybGluZURhdGFTdHJlYW0uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/pinot/tools/streams/MeetupRsvpStream.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3N0cmVhbXMvTWVldHVwUnN2cFN0cmVhbS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/pinot/tools/admin/command/StartKafkaCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvU3RhcnRLYWZrYUNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `93.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...g/apache/pinot/tools/admin/PinotAdministrator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL1Bpbm90QWRtaW5pc3RyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...java/org/apache/pinot/tools/PinotToolLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1Bpbm90VG9vbExhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../main/java/org/apache/pinot/spi/plugin/Plugin.java](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbi5qYXZh) | `54.54% <0%> (-5.46%)` | `0 <0> (ø)` | |
   | ... and [30 more](https://codecov.io/gh/apache/incubator-pinot/pull/4956/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=footer). Last update [0200407...f301dc2](https://codecov.io/gh/apache/incubator-pinot/pull/4956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org