You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2009/01/14 22:23:30 UTC
Re: [DBCP] svn commit: r734473
On Wed, Jan 14, 2009 at 1:36 PM, <se...@apache.org> wrote:
> Author: sebb
> Date: Wed Jan 14 10:36:07 2009
> New Revision: 734473
>
> URL: http://svn.apache.org/viewvc?rev=734473&view=rev
> Log:
> Make non-private static fields final
<snip/>
Note that the above breaks binary and source compatibility. Therefore,
at the least, such changes deserve notable mentions in the release
notes and often additional thought about the version number of the
next release.
-Rahul
> Replace deprecated SQLNestedException with equivalent code
>
> Modified:
> commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java
> commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java
>
> Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java
> URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java?rev=734473&r1=734472&r2=734473&view=diff
> ==============================================================================
> --- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java (original)
> +++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java Wed Jan 14 10:36:07 2009
> @@ -59,7 +59,7 @@
> }
>
> /** The map of registered pools. */
> - protected static HashMap _pools = new HashMap();
> + protected static final HashMap _pools = new HashMap();
>
> /** Controls access to the underlying connection */
> private static boolean accessToUnderlyingConnectionAllowed = false;
> @@ -112,10 +112,10 @@
> jocl = JOCLContentHandler.parse(in);
> }
> catch (SAXException e) {
> - throw new SQLNestedException("Could not parse configuration file", e);
> + throw (SQLException) new SQLException("Could not parse configuration file").initCause(e);
> }
> catch (IOException e) {
> - throw new SQLNestedException("Could not load configuration file", e);
> + throw (SQLException) new SQLException("Could not load configuration file").initCause(e);
> }
> if(jocl.getType(0).equals(String.class)) {
> pool = getPool((String)(jocl.getValue(0)));
> @@ -148,7 +148,7 @@
> pool.close();
> }
> catch (Exception e) {
> - throw new SQLNestedException("Error closing pool " + name, e);
> + throw (SQLException) new SQLException("Error closing pool " + name).initCause(e);
> }
> }
> }
> @@ -181,11 +181,11 @@
> } catch(SQLException e) {
> throw e;
> } catch(NoSuchElementException e) {
> - throw new SQLNestedException("Cannot get a connection, pool error: " + e.getMessage(), e);
> + throw (SQLException) new SQLException("Cannot get a connection, pool error: " + e.getMessage()).initCause(e);
> } catch(RuntimeException e) {
> throw e;
> } catch(Exception e) {
> - throw new SQLNestedException("Cannot get a connection, general error: " + e.getMessage(), e);
> + throw (SQLException) new SQLException("Cannot get a connection, general error: " + e.getMessage()).initCause(e);
> }
> }
> } else {
> @@ -236,12 +236,12 @@
> }
>
> /** My URL prefix */
> - protected static String URL_PREFIX = "jdbc:apache:commons:dbcp:";
> - protected static int URL_PREFIX_LEN = URL_PREFIX.length();
> + protected static final String URL_PREFIX = "jdbc:apache:commons:dbcp:";
> + protected static final int URL_PREFIX_LEN = URL_PREFIX.length();
>
> // version numbers
> - protected static int MAJOR_VERSION = 1;
> - protected static int MINOR_VERSION = 0;
> + protected static final int MAJOR_VERSION = 1;
> + protected static final int MINOR_VERSION = 0;
>
> /**
> * PoolGuardConnectionWrapper is a Connection wrapper that makes sure a
>
> Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java
> URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java?rev=734473&r1=734472&r2=734473&view=diff
> ==============================================================================
> --- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java (original)
> +++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterDriver.java Wed Jan 14 10:36:07 2009
> @@ -116,10 +116,10 @@
> return new DriverPropertyInfo[0];
> }
>
> - protected static String CONNECT_STRING = "jdbc:apache:commons:testdriver";
> + protected static final String CONNECT_STRING = "jdbc:apache:commons:testdriver";
>
> // version numbers
> - protected static int MAJOR_VERSION = 1;
> - protected static int MINOR_VERSION = 0;
> + protected static final int MAJOR_VERSION = 1;
> + protected static final int MINOR_VERSION = 0;
>
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Rahul Akolkar <ra...@gmail.com>.
On Mon, Jan 19, 2009 at 1:46 PM, sebb <se...@gmail.com> wrote:
> On 19/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> Not really a DBCP only discussion at this point ...
>>
>>
>> On Sun, Jan 18, 2009 at 1:20 PM, sebb <se...@gmail.com> wrote:
>> > On 18/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
<snip/>
>> >> I think whats being pointed out
>> >> here is that at some point a design decision was made to have a non
>> >> final protected field and its hard to say what usage implications that
>> >> has had in the wild.
>> >
>> > I take your point, but I think it's more likely that the final
>> > qualifier was accidentally omitted...
>>
>> <snip/>
>>
>> Yes, and only the original author can attest to that.
>>
>
> But we can draw inferences from other aspects of the class design.
>
>>
>> > in particular, the MAJOR_VERSION
>> > and MINOR_VERSION fields should surely be final, otherwise will the
>> > implementation be JDBC compliant?
>> >
>>
>> <snap/>
>>
>> No time to look at the code ATM, but those seem to be special cases
>> (theres more semantics to those fields that the purely final/non final
>> discussion here).
>>
>
> Indeed, that is the point - it does not make sense for these fields to
> be mutable.
>
>>
>> > If the user was expected to change the fields, why not provide
>> > synchronised setters/getters as is done with
>> > accessToUnderlyingConnectionAllowed?
>> >
>>
>> <snip/>
>>
>> Yes that can be done.
>
> My point was that if the author really had intended for the fields to
> be mutable, then why did (s)he not provide thread-safe methods for
> doing so?
>
<snap/>
*shrug*
>
>> But that doesn't change the fact that finalizing
>> the field(s) at this time breaks compatibility.
>>
>
> IMO, it only breaks compatibility with broken code.
>
<snip/>
I think it boils down to the above point -- saying all code that
writes will necessarily be broken cannot be corroborated.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by sebb <se...@gmail.com>.
On 19/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> Not really a DBCP only discussion at this point ...
>
>
> On Sun, Jan 18, 2009 at 1:20 PM, sebb <se...@gmail.com> wrote:
> > On 18/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> On Thu, Jan 15, 2009 at 6:22 AM, sebb <se...@gmail.com> wrote:
> >> > On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
> >> >> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
> >> >>
> >> >> >
> >> >> > Stephen Colebourne wrote:
> >> >> > > Rahul Akolkar wrote:
> >> >> > >>
> >> >>
> >> >> > >> Note that the above breaks binary and source compatibility.
> >> >> > Therefore,
> >> >> > >> at the least, such changes deserve notable mentions in the release
> >> >> > >> notes and often additional thought about the version number of the
> >> >> > >> next release.
> >> >> > >
> >> >>
> >> >> > > We shouldn't create any more jar hell situations.
> >> >
> >> > As far as I can tell, making these static fields final will only break
> >> > code that tries to write to the field(s).
> >> >
> >> > If code merely references the field, then it will continue to compile
> >> > and run against a final-ised version of the class.
> >> >
> >>
> >> <snip/>
> >>
> >> Yup.
> >>
> >>
> >>
> >> > Any code that writes to the fields in question is dubious at best, so
> >> > I personally don't see any problem in breaking it.
> >> >
> >> > Surely "jar hell" can only happen to incorrect code in this case?
> >> >
> >> > Or am I missing some subtlety here?
> >> >
> >>
> >> <snap/>
> >>
> >> It may be possible that for some constrained usage pattern the non
> >> final protected field may be written to, and with said constraints it
> >> may be less dubious or not at all.
> >
> > I'd be interested to see a use case for changing any of the fields.
> >
>
> <snip/>
>
> Wrong approach :-) Having said something is protected, the onus is
> hardly on users to show why they need to write to it.
>
>
>
> > The existing references to the fields within the class do not use
> > synchronisation.
> > It would be tricky to make the any code that changes any of the fields
> > thread-safe.
> >
>
> <snap/>
>
> There could be external synchronization or single threaded scenarios
> (container startup shutdown, who knows what :-)
>
>
>
>
> >> I think whats being pointed out
> >> here is that at some point a design decision was made to have a non
> >> final protected field and its hard to say what usage implications that
> >> has had in the wild.
> >
> > I take your point, but I think it's more likely that the final
> > qualifier was accidentally omitted...
>
> <snip/>
>
> Yes, and only the original author can attest to that.
>
But we can draw inferences from other aspects of the class design.
>
> > in particular, the MAJOR_VERSION
> > and MINOR_VERSION fields should surely be final, otherwise will the
> > implementation be JDBC compliant?
> >
>
> <snap/>
>
> No time to look at the code ATM, but those seem to be special cases
> (theres more semantics to those fields that the purely final/non final
> discussion here).
>
Indeed, that is the point - it does not make sense for these fields to
be mutable.
>
> > If the user was expected to change the fields, why not provide
> > synchronised setters/getters as is done with
> > accessToUnderlyingConnectionAllowed?
> >
>
> <snip/>
>
> Yes that can be done.
My point was that if the author really had intended for the fields to
be mutable, then why did (s)he not provide thread-safe methods for
doing so?
> But that doesn't change the fact that finalizing
> the field(s) at this time breaks compatibility.
>
IMO, it only breaks compatibility with broken code.
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Rahul Akolkar <ra...@gmail.com>.
Not really a DBCP only discussion at this point ...
On Sun, Jan 18, 2009 at 1:20 PM, sebb <se...@gmail.com> wrote:
> On 18/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> On Thu, Jan 15, 2009 at 6:22 AM, sebb <se...@gmail.com> wrote:
>> > On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
>> >> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
>> >>
>> >> >
>> >> > Stephen Colebourne wrote:
>> >> > > Rahul Akolkar wrote:
>> >> > >>
>> >>
>> >> > >> Note that the above breaks binary and source compatibility.
>> >> > Therefore,
>> >> > >> at the least, such changes deserve notable mentions in the release
>> >> > >> notes and often additional thought about the version number of the
>> >> > >> next release.
>> >> > >
>> >>
>> >> > > We shouldn't create any more jar hell situations.
>> >
>> > As far as I can tell, making these static fields final will only break
>> > code that tries to write to the field(s).
>> >
>> > If code merely references the field, then it will continue to compile
>> > and run against a final-ised version of the class.
>> >
>>
>> <snip/>
>>
>> Yup.
>>
>>
>>
>> > Any code that writes to the fields in question is dubious at best, so
>> > I personally don't see any problem in breaking it.
>> >
>> > Surely "jar hell" can only happen to incorrect code in this case?
>> >
>> > Or am I missing some subtlety here?
>> >
>>
>> <snap/>
>>
>> It may be possible that for some constrained usage pattern the non
>> final protected field may be written to, and with said constraints it
>> may be less dubious or not at all.
>
> I'd be interested to see a use case for changing any of the fields.
>
<snip/>
Wrong approach :-) Having said something is protected, the onus is
hardly on users to show why they need to write to it.
> The existing references to the fields within the class do not use
> synchronisation.
> It would be tricky to make the any code that changes any of the fields
> thread-safe.
>
<snap/>
There could be external synchronization or single threaded scenarios
(container startup shutdown, who knows what :-)
>> I think whats being pointed out
>> here is that at some point a design decision was made to have a non
>> final protected field and its hard to say what usage implications that
>> has had in the wild.
>
> I take your point, but I think it's more likely that the final
> qualifier was accidentally omitted...
<snip/>
Yes, and only the original author can attest to that.
> in particular, the MAJOR_VERSION
> and MINOR_VERSION fields should surely be final, otherwise will the
> implementation be JDBC compliant?
>
<snap/>
No time to look at the code ATM, but those seem to be special cases
(theres more semantics to those fields that the purely final/non final
discussion here).
> If the user was expected to change the fields, why not provide
> synchronised setters/getters as is done with
> accessToUnderlyingConnectionAllowed?
>
<snip/>
Yes that can be done. But that doesn't change the fact that finalizing
the field(s) at this time breaks compatibility.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by sebb <se...@gmail.com>.
On 18/01/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Thu, Jan 15, 2009 at 6:22 AM, sebb <se...@gmail.com> wrote:
> > On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
> >> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
> >>
> >> >
> >> > Stephen Colebourne wrote:
> >> > > Rahul Akolkar wrote:
> >> > >>
> >>
> >> > >> Note that the above breaks binary and source compatibility.
> >> > Therefore,
> >> > >> at the least, such changes deserve notable mentions in the release
> >> > >> notes and often additional thought about the version number of the
> >> > >> next release.
> >> > >
> >>
> >> > > We shouldn't create any more jar hell situations.
> >
> > As far as I can tell, making these static fields final will only break
> > code that tries to write to the field(s).
> >
> > If code merely references the field, then it will continue to compile
> > and run against a final-ised version of the class.
> >
>
> <snip/>
>
> Yup.
>
>
>
> > Any code that writes to the fields in question is dubious at best, so
> > I personally don't see any problem in breaking it.
> >
> > Surely "jar hell" can only happen to incorrect code in this case?
> >
> > Or am I missing some subtlety here?
> >
>
> <snap/>
>
> It may be possible that for some constrained usage pattern the non
> final protected field may be written to, and with said constraints it
> may be less dubious or not at all.
I'd be interested to see a use case for changing any of the fields.
The existing references to the fields within the class do not use
synchronisation.
It would be tricky to make the any code that changes any of the fields
thread-safe.
> I think whats being pointed out
> here is that at some point a design decision was made to have a non
> final protected field and its hard to say what usage implications that
> has had in the wild.
I take your point, but I think it's more likely that the final
qualifier was accidentally omitted... in particular, the MAJOR_VERSION
and MINOR_VERSION fields should surely be final, otherwise will the
implementation be JDBC compliant?
If the user was expected to change the fields, why not provide
synchronised setters/getters as is done with
accessToUnderlyingConnectionAllowed?
>
> -Rahul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Phil Steitz <ph...@gmail.com>.
Rahul Akolkar wrote:
> On Thu, Jan 15, 2009 at 6:22 AM, sebb <se...@gmail.com> wrote:
>
>> On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
>>
>>>> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>>>>
>>> > Stephen Colebourne wrote:
>>> > > Rahul Akolkar wrote:
>>> > >>
>>>
>>>
>>>>>> Note that the above breaks binary and source compatibility.
>>>>>>
>>> > Therefore,
>>> > >> at the least, such changes deserve notable mentions in the release
>>> > >> notes and often additional thought about the version number of the
>>> > >> next release.
>>> > >
>>>
>>>
>>>>> We shouldn't create any more jar hell situations.
>>>>>
>> As far as I can tell, making these static fields final will only break
>> code that tries to write to the field(s).
>>
>> If code merely references the field, then it will continue to compile
>> and run against a final-ised version of the class.
>>
>>
> <snip/>
>
> Yup.
>
>
>
>> Any code that writes to the fields in question is dubious at best, so
>> I personally don't see any problem in breaking it.
>>
>> Surely "jar hell" can only happen to incorrect code in this case?
>>
>> Or am I missing some subtlety here?
>>
>>
> <snap/>
>
> It may be possible that for some constrained usage pattern the non
> final protected field may be written to, and with said constraints it
> may be less dubious or not at all. I think whats being pointed out
> here is that at some point a design decision was made to have a non
> final protected field and its hard to say what usage implications that
> has had in the wild.
>
Yes. And we have agreed that we do not break source or binary
compatability in .x releases, so we need to revert this and any other
change that breaks source or binary compatibility.
Phil
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Rahul Akolkar <ra...@gmail.com>.
On Thu, Jan 15, 2009 at 6:22 AM, sebb <se...@gmail.com> wrote:
> On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
>> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
>>
>> >
>> > Stephen Colebourne wrote:
>> > > Rahul Akolkar wrote:
>> > >>
>>
>> > >> Note that the above breaks binary and source compatibility.
>> > Therefore,
>> > >> at the least, such changes deserve notable mentions in the release
>> > >> notes and often additional thought about the version number of the
>> > >> next release.
>> > >
>>
>> > > We shouldn't create any more jar hell situations.
>
> As far as I can tell, making these static fields final will only break
> code that tries to write to the field(s).
>
> If code merely references the field, then it will continue to compile
> and run against a final-ised version of the class.
>
<snip/>
Yup.
> Any code that writes to the fields in question is dubious at best, so
> I personally don't see any problem in breaking it.
>
> Surely "jar hell" can only happen to incorrect code in this case?
>
> Or am I missing some subtlety here?
>
<snap/>
It may be possible that for some constrained usage pattern the non
final protected field may be written to, and with said constraints it
may be less dubious or not at all. I think whats being pointed out
here is that at some point a design decision was made to have a non
final protected field and its hard to say what usage implications that
has had in the wild.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by sebb <se...@gmail.com>.
On 15/01/2009, Mark Thomas <ma...@apache.org> wrote:
> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
>
> >
> > Stephen Colebourne wrote:
> > > Rahul Akolkar wrote:
> > >>
>
> > >> Note that the above breaks binary and source compatibility.
> > Therefore,
> > >> at the least, such changes deserve notable mentions in the release
> > >> notes and often additional thought about the version number of the
> > >> next release.
> > >
>
> > > We shouldn't create any more jar hell situations.
As far as I can tell, making these static fields final will only break
code that tries to write to the field(s).
If code merely references the field, then it will continue to compile
and run against a final-ised version of the class.
Any code that writes to the fields in question is dubious at best, so
I personally don't see any problem in breaking it.
Surely "jar hell" can only happen to incorrect code in this case?
Or am I missing some subtlety here?
> > I agree with Stephen on this. This is a needless break. I would
> > prefer
> > to limit changes to what is required to support compilation under JDK
> > 1.6. Otherwise, we need to target a 2.0 (and consider changing
> > package
> > name) and as there does not appear to be collective energy to push out
> > a
> > 1.2.3 bugfix release, I would really like to see 1.3 usable by current
> > users as there are some nasty bugs that have been fixed in trunk.
>
>
> +1
>
>
> Mark
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [DBCP] svn commit: r734473
Posted by Mark Thomas <ma...@apache.org>.
> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>
> Stephen Colebourne wrote:
> > Rahul Akolkar wrote:
> >>
> >> Note that the above breaks binary and source compatibility.
> Therefore,
> >> at the least, such changes deserve notable mentions in the release
> >> notes and often additional thought about the version number of the
> >> next release.
> >
> > We shouldn't create any more jar hell situations.
> I agree with Stephen on this. This is a needless break. I would
> prefer
> to limit changes to what is required to support compilation under JDK
> 1.6. Otherwise, we need to target a 2.0 (and consider changing
> package
> name) and as there does not appear to be collective energy to push out
> a
> 1.2.3 bugfix release, I would really like to see 1.3 usable by current
> users as there are some nasty bugs that have been fixed in trunk.
+1
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Phil Steitz <ph...@gmail.com>.
Stephen Colebourne wrote:
> Rahul Akolkar wrote:
>> On Wed, Jan 14, 2009 at 1:36 PM, <se...@apache.org> wrote:
>>> Author: sebb
>>> Date: Wed Jan 14 10:36:07 2009
>>> New Revision: 734473
>>>
>>> URL: http://svn.apache.org/viewvc?rev=734473&view=rev
>>> Log:
>>> Make non-private static fields final
>> <snip/>
>>
>> Note that the above breaks binary and source compatibility. Therefore,
>> at the least, such changes deserve notable mentions in the release
>> notes and often additional thought about the version number of the
>> next release.
>
> With such a low level and widely used component as DBCP, changing
> binary compatability will cause users lots of pain (unless there is a
> specific plan here).
>
> Possible solutions include
> - don't make a binary/source incompatible change
> - change the package name
>
> We shouldn't create any more jar hell situations.
I agree with Stephen on this. This is a needless break. I would prefer
to limit changes to what is required to support compilation under JDK
1.6. Otherwise, we need to target a 2.0 (and consider changing package
name) and as there does not appear to be collective energy to push out a
1.2.3 bugfix release, I would really like to see 1.3 usable by current
users as there are some nasty bugs that have been fixed in trunk.
>
> Stephen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] svn commit: r734473
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Rahul Akolkar wrote:
> On Wed, Jan 14, 2009 at 1:36 PM, <se...@apache.org> wrote:
>> Author: sebb
>> Date: Wed Jan 14 10:36:07 2009
>> New Revision: 734473
>>
>> URL: http://svn.apache.org/viewvc?rev=734473&view=rev
>> Log:
>> Make non-private static fields final
> <snip/>
>
> Note that the above breaks binary and source compatibility. Therefore,
> at the least, such changes deserve notable mentions in the release
> notes and often additional thought about the version number of the
> next release.
With such a low level and widely used component as DBCP, changing binary
compatability will cause users lots of pain (unless there is a specific
plan here).
Possible solutions include
- don't make a binary/source incompatible change
- change the package name
We shouldn't create any more jar hell situations.
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org