You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/02 06:43:01 UTC
[jira] [Commented] (OODT-395) SerializableMetadata.toXml() doesn't
set namespace on root element
[ https://issues.apache.org/jira/browse/OODT-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220686#comment-13220686 ]
jiraposter@reviews.apache.org commented on OODT-395:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4088/#review5545
-----------------------------------------------------------
Ship it!
LGTM, Ricky!
- Chris
On 2012-02-29 20:02:06, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4088/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-29 20:02:06)
bq.
bq.
bq. Review request for oodt.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Create metadata root element with a proper namespace and prefix.
bq.
bq.
bq. This addresses bug OODT-395.
bq. https://issues.apache.org/jira/browse/OODT-395
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/SerializableMetadata.java 1293402
bq. trunk/metadata/src/test/org/apache/oodt/cas/metadata/TestSerializableMetadata.java 1293402
bq.
bq. Diff: https://reviews.apache.org/r/4088/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit test in TestSerializableMetadata#testNamespace() to demonstrate bug and fix.
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> SerializableMetadata.toXml() doesn't set namespace on root element
> ------------------------------------------------------------------
>
> Key: OODT-395
> URL: https://issues.apache.org/jira/browse/OODT-395
> Project: OODT
> Issue Type: Bug
> Components: metadata container
> Affects Versions: 0.4
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
> Attachments: rickdn.oodt-395.patch
>
>
> This issue becomes apparent when using o.a.o.cas.pge.writers.xslt.XslTransformWriter in the <dynInputFile> element of a PGE config xml. If you use the identity xsl transform (http://en.wikipedia.org/wiki/Identity_transform#Using_XSLT):
> {code}
> <xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
> <xsl:template match="@*|node()">
> <xsl:copy>
> <xsl:apply-templates select="@*|node()"/>
> </xsl:copy>
> </xsl:template>
> </xsl:stylesheet>
> {code}
> Then the root element is NOT part of the "cas" namespace:
> {code}
> <metadata xmlns:cas="http://oodt.jpl.nasa.gov/1.0/cas">
> ...
> </metadata>
> {code}
> Whereas the serialized form of metadata (when written to a File or OutputStream) DOES use the "cas" namespace:
> {code}
> <cas:metadata xmlns:cas="http://oodt.jpl.nasa.gov/1.0/cas">
> ...
> </cas:metadata>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira