You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/12 22:28:47 UTC

[GitHub] [helix] zhangmeng916 opened a new pull request #1261: change default monitor window length from 1 hour to 1 min

zhangmeng916 opened a new pull request #1261:
URL: https://github.com/apache/helix/pull/1261


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixed #1259 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Helix default monitor window length was set as 1 hour for histogram metrics. The long time window leads to a high memory usage during runtime. This PR changes the default length from 1 hour to 1 min in order to reduce memory usage. 
   
   ### Tests
   
   - [X] The following is the result of the "mvn test" command on the appropriate module:
   helix-core:
   [INFO]
   [INFO] Results:
   [INFO]
   [ERROR] Failures:
   [ERROR]   TestWagedRebalance.testChangeIdealState:303->validate:646 expected:<true> but was:<false>
   [INFO]
   [ERROR] Tests run: 1163, Failures: 1, Errors: 0, Skipped: 1
   [INFO]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  01:15 h
   [INFO] Finished at: 2020-08-12T15:13:28-07:00
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] dasahcc merged pull request #1261: change default monitor window length from 1 hour to 1 min

Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1261:
URL: https://github.com/apache/helix/pull/1261


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] zhangmeng916 commented on pull request #1261: change default monitor window length from 1 hour to 1 min

Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1261:
URL: https://github.com/apache/helix/pull/1261#issuecomment-673149001


   This PR is ready to merge, approved by @narendly 
   Final commit message:
   Change default monitor window length from 1 hour to 1 min
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org