You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2021/02/13 11:11:36 UTC

Checkstyle and Openrewrite or/and Spotless

Hi,

Some times ago at https://s.apache.org/tzcwm Eugen suggested:

Are you aware of https://github.com/openrewrite/rewrite-gradle-plugin <https://github.com/openrewrite/rewrite-gradle-plugin> and 
https://github.com/diffplug/spotless <https://github.com/diffplug/spotless> ?
They can provide IDE independent formatting and checking .

I think we should consider them after finishing the current work, even if not totally complete.

Opinions? (disclaimer I did not look into details yet)

Jacques

Re: Checkstyle and Openrewrite or/and Spotless

Posted by Jacques Le Roux <ja...@les7arts.com>.

Yes I tend to agree, makes sense, thanks Michael

Le 13/02/2021 à 12:51, Michael Brohl a écrit :
> Hi Jacques,
>
> I am not a fan for automatical code changes during a build:
>
> - it can/will change a lot of code you do not want to be changed. We've already seen that checkstyle errors can be disputable.
>
> - it adds another complexity to the build and makes it slower
>
> - it prevents people from learning. If you are being forced to manually change the code after checkstyle has found an error during build, you'll 
> learn on the way.
>
> So better use the project formatter settings for the IDE and let people deal with checkstyle errors during their implementation.
>
> My 2 cts,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 13.02.21 um 12:11 schrieb Jacques Le Roux:
>> Hi,
>>
>> Some times ago at https://s.apache.org/tzcwm Eugen suggested:
>>
>> Are you aware of https://github.com/openrewrite/rewrite-gradle-plugin <https://github.com/openrewrite/rewrite-gradle-plugin> and 
>> https://github.com/diffplug/spotless <https://github.com/diffplug/spotless> ?
>> They can provide IDE independent formatting and checking .
>>
>> I think we should consider them after finishing the current work, even if not totally complete.
>>
>> Opinions? (disclaimer I did not look into details yet)
>>
>> Jacques
>>
>>

Re: Checkstyle and Openrewrite or/and Spotless

Posted by Michael Brohl <mi...@ecomify.de>.

Hi Jacques,

I am not a fan for automatical code changes during a build:

- it can/will change a lot of code you do not want to be changed. We've 
already seen that checkstyle errors can be disputable.

- it adds another complexity to the build and makes it slower

- it prevents people from learning. If you are being forced to manually 
change the code after checkstyle has found an error during build, you'll 
learn on the way.

So better use the project formatter settings for the IDE and let people 
deal with checkstyle errors during their implementation.

My 2 cts,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 13.02.21 um 12:11 schrieb Jacques Le Roux:
> Hi,
>
> Some times ago at https://s.apache.org/tzcwm Eugen suggested:
>
> Are you aware of https://github.com/openrewrite/rewrite-gradle-plugin 
> <https://github.com/openrewrite/rewrite-gradle-plugin> and 
> https://github.com/diffplug/spotless 
> <https://github.com/diffplug/spotless> ?
> They can provide IDE independent formatting and checking .
>
> I think we should consider them after finishing the current work, even 
> if not totally complete.
>
> Opinions? (disclaimer I did not look into details yet)
>
> Jacques
>
>