You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 16:29:26 UTC

[GitHub] [arrow-rs] viirya commented on a change in pull request #1481: Fix reading/writing nested null arrays (#1480) (#1036) (#1399)

viirya commented on a change in pull request #1481:
URL: https://github.com/apache/arrow-rs/pull/1481#discussion_r834502380



##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -887,7 +886,7 @@ fn remove_indices(
                 Ok(Arc::new(StructArray::from((new_columns, valid.finish()))))
             }
         }
-        ArrowType::Null => Ok(Arc::new(NullArray::new(arr.len()))),
+        ArrowType::Null => Ok(Arc::new(NullArray::new(arr.len() - indices.len()))),

Review comment:
       Hmm, I remember by deducting the null indices, the resulting record batch will be empty, but actually there are a row with empty list in previous issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org