[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3356: BP-41 Add flag to enable/disable BookieAddressResolver

[GitBox <gi...@apache.org>]

StevenLuMT commented on code in PR #3356:
URL: https://github.com/apache/bookkeeper/pull/3356#discussion_r929159189


##########
tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommandTest.java:
##########
@@ -62,17 +64,23 @@ public void setup() throws Exception {
 
         this.cmd = mock(DiscoveryCommand.class, CALLS_REAL_METHODS);
 
-        this.serverConf = new ServerConfiguration();
-        this.serverConf.setMetadataServiceUri("zk://127.0.0.1/path/to/ledgers");
+        this.clientConf = new ClientConfiguration();

Review Comment:
   why change ServerConfiguration to ClientConfiguration?
   



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {

Review Comment:
   old code style is getBookieAddressResolverEnable 
   I think it's better



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1288,6 +1289,33 @@ public ClientConfiguration setEnsemblePlacementPolicySlowBookies(boolean enabled
         return this;
     }
 
+    /**
+     * Whether to enable BookieAddressResolver.
+     *
+     * @return flag to enable/disable BookieAddressResolver.
+     */
+    public boolean getEnableBookieAddressResolver() {
+        return getBoolean(ENABLE_BOOKIE_ADDRESS_RESOLVER, true);
+    }
+
+    /**
+     * Enable/Disable BookieAddressResolver.
+     *
+     * <p>
+     * If this flag is true, read bookie information from the metadata service (e.g. ZooKeeper) to resolve the address
+     * from each bookie ID. If all bookie IDs in the cluster are "address:port" or "hostname:port", you can set this
+     * flag to false to reduce requests to the metadata service.
+     * </p>
+     *
+     * @param enabled
+     *          flag to enable/disable BookieAddressResolver.
+     * @return client configuration.
+     */
+    public ClientConfiguration setEnableBookieAddressResolver(boolean enabled) {

Review Comment:
   setBookieAddressResolverEnable 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org