[myfaces-tobago] 01/02: fix: tobago-popover

[hn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-5.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit acfd5e28a38f4cc6a533ee621fd8909bbbe6d3a7
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Mon Jun 12 14:41:31 2023 +0200

    fix: tobago-popover
    
    By default the messagePosition is buttonRight. If an error message occur on a form component, a button with a tobago-popover should displayed on the right side. With the current Chrome(v114) and the current Edge(v114), this button is noch visible anymore. In the older version of Edge(v112) or with Firefox(v114) the button is shown.
    
    It seems that the newer Chrome/Edge browser has activated this feature https://developer.mozilla.org/en-US/docs/Web/CSS/:popover-open
    With this feature some styles are set on a [popover] which hide the message button.
    
    Issue: TOBAGO-2232
---
 tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
index 4a1b83167b..49cec5300c 100644
--- a/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
+++ b/tobago-theme/tobago-theme-standard/src/main/ts/tobago-popover.ts
@@ -15,10 +15,6 @@
  * limitations under the License.
  */
 
-// XXX which? nothing works...
-// import * as bootstrap from "bootstrap/dist/js/bootstrap";
-// import Popover from "bootstrap/dist/js/bootstrap.bundle";
-// import {createPopper} from "@popperjs/core/dist/esm/popper";
 import {Popover} from "bootstrap";
 import {MenuStore} from "./tobago-menu-store";
 
@@ -26,14 +22,14 @@ import {MenuStore} from "./tobago-menu-store";
 
 class TobagoPopover extends HTMLElement {
 
-  private popover: Popover;
+  private instance: Popover;
 
   constructor() {
     super();
   }
 
   connectedCallback(): void {
-    this.popover = new Popover(this.trigger, {
+    this.instance = new Popover(this.trigger, {
       container: MenuStore.get()
     });
   }