You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 17:05:16 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2134: Make MapFieldNames public (#2118)
tustvold opened a new pull request, #2134:
URL: https://github.com/apache/arrow-rs/pull/2134
# Which issue does this PR close?
Closes #2118
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See ticket
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Make MapFieldNames public so `MapBuilder` can be used
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2134: Make MapFieldNames public (#2118)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2134:
URL: https://github.com/apache/arrow-rs/pull/2134#issuecomment-1192807623
If this is a regression since 18.0.0 I think we should merge it and cut a new release candidate for 19.0.0 (and avoid releasing the regression)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2134: Make MapFieldNames public (#2118)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2134:
URL: https://github.com/apache/arrow-rs/pull/2134#issuecomment-1192829552
Benchmark runs are scheduled for baseline = 34f58f96d421302aa2c67b689ff1a63ac77fa1a1 and contender = add264979720a3500440da7b38b6f5ae6ac9eadb. add264979720a3500440da7b38b6f5ae6ac9eadb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1943323a294e4edf965dce67063086f3...7c40b2b9c8194b999ca316d8cb804793/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/946f91bf75ca4328adbf9e0de16025cc...ce0ac8cd63d04171a11fa9f26b7197bd/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fc1c9eb1a45b467680a3ec4469e043d2...44d684f35fda49a484ccc80125c0a773/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ba6a199c2bb24f27b1e4c6cf4b2db286...0f44a3029129467481799743509a4ae0/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2134: Make MapFieldNames public (#2118)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2134:
URL: https://github.com/apache/arrow-rs/pull/2134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org