You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/07 18:01:41 UTC
Review Request 39093: CMake:[3/3] Add `make check` target.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
CMake:[3/3] Add `make check` target.
Diffs
-----
CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
Diff: https://reviews.apache.org/r/39093/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102309
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 12, 2015, 12:41 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 12:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102458
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Oct. 12, 2015, 12:41 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 12:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102606
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Oct. 13, 2015, 6:25 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 6:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:25 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
CMake:[3/3] Add `make check` target.
Diffs (updated)
-----
CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
Diff: https://reviews.apache.org/r/39093/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 7:41 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
CMake:[3/3] Add `make check` target.
Diffs (updated)
-----
CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
Diff: https://reviews.apache.org/r/39093/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 12, 2015, 7:06 p.m., Joseph Wu wrote:
> > CMakeLists.txt, lines 96-99
> > <https://reviews.apache.org/r/39093/diff/2/?file=1094407#file1094407line96>
> >
> > Still only runs the libprocess tests.
> >
> > This runs both tests:
> > ```
> > add_custom_target(
> > check ${STOUT_TESTS_TARGET}
> > COMMAND ${PROCESS_TESTS_TARGET}
> > DEPENDS ${PROCESS_TESTS_TARGET} ${STOUT_TESTS_TARGET}
> > )
> > ```
> >
> > So for future tests, you'll need to insert another `COMMAND ${..._TESTS_TARGET}`.
Oh man, sorry, the process tests fail on corpnet, and in the flurry of commits I forgot to come back and verify this worked when I went home.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102295
-----------------------------------------------------------
On Oct. 10, 2015, 4:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 4:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review102295
-----------------------------------------------------------
CMakeLists.txt (lines 96 - 99)
<https://reviews.apache.org/r/39093/#comment159898>
Still only runs the libprocess tests.
This runs both tests:
```
add_custom_target(
check ${STOUT_TESTS_TARGET}
COMMAND ${PROCESS_TESTS_TARGET}
DEPENDS ${PROCESS_TESTS_TARGET} ${STOUT_TESTS_TARGET}
)
```
So for future tests, you'll need to insert another `COMMAND ${..._TESTS_TARGET}`.
- Joseph Wu
On Oct. 9, 2015, 9:27 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 9:27 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/
-----------------------------------------------------------
(Updated Oct. 10, 2015, 4:27 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
CMake:[3/3] Add `make check` target.
Diffs (updated)
-----
CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
Diff: https://reviews.apache.org/r/39093/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 7, 2015, 5:05 p.m., Joseph Wu wrote:
> > CMakeLists.txt, line 97
> > <https://reviews.apache.org/r/39093/diff/1/?file=1092411#file1092411line97>
> >
> > This only runs the libprocess tests. Did you mean to do this?
Oh, man, somehow they must have gotten obliterated when I was moving this code around. Oops!
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review101790
-----------------------------------------------------------
On Oct. 7, 2015, 4:01 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 4:01 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review101790
-----------------------------------------------------------
Applied the chain and ran:
```
cmake ..
make
make check
```
Only libprocess tests ran. But there was **color** (yay! :)
CMakeLists.txt (line 97)
<https://reviews.apache.org/r/39093/#comment159280>
This only runs the libprocess tests. Did you mean to do this?
- Joseph Wu
On Oct. 7, 2015, 9:01 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 9:01 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39093: CMake:[3/3] Add `make check` target.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39093/#review101803
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39019, 39076, 39091, 39092, 39093]
All tests passed.
- Mesos ReviewBot
On Oct. 7, 2015, 4:01 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39093/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 4:01 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[3/3] Add `make check` target.
>
>
> Diffs
> -----
>
> CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f
>
> Diff: https://reviews.apache.org/r/39093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>