[GitHub] [helix] narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #525: Add waged rebalancer monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337804645
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -74,6 +77,7 @@
   // Make it static to avoid unnecessary reinitialization.
   private static final ThreadLocal<ResourceChangeDetector> CHANGE_DETECTOR_THREAD_LOCAL =
       new ThreadLocal<>();
+  private static final long REBALANCE_COUNTER_INCREMENT = 1L;
 
 Review comment:
   I think for this, using `increaseCount(1L)` would be more readable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org