You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/20 10:16:45 UTC

[GitHub] [ozone] ChenSammi commented on a change in pull request #2439: HDDS-5465. Delete redundant code when set、add and remove bucket acl

ChenSammi commented on a change in pull request #2439:
URL: https://github.com/apache/ozone/pull/2439#discussion_r672966958



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -122,8 +122,7 @@ OMClientResponse onSuccess(OMResponse.Builder omResponse,
   @Override
   OMClientResponse onFailure(OMResponse.Builder omResponse,

Review comment:
       You can just remove this onFailure implementation in each sub class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org