[GitHub] [incubator-hop] hansva commented on a change in pull request #353: HOP-3129 IPerspective return Control not Composite

[GitBox <gi...@apache.org>]

hansva commented on a change in pull request #353:
URL: https://github.com/apache/incubator-hop/pull/353#discussion_r519159993



##########
File path: plugins/misc/git/src/main/java/org/apache/hop/git/HopGitPerspective.java
##########
@@ -862,7 +862,7 @@ private void getPerspectiveToolbarImages() {
     return false;
   }
 
-  @Override public Composite getComposite() {
+  @Override public Control getControl() {
     return perspectiveComposite;

Review comment:
       isn't this still returning a Composite?

##########
File path: ui/src/main/java/org/apache/hop/ui/hopgui/perspective/pluginexplorer/HopPluginExplorePerspective.java
##########
@@ -286,14 +287,9 @@ public boolean hasNavigationPreviousFile() {
 	public boolean hasNavigationNextFile() {
 		return false;
 	}
-
-	/**
-	 * Gets composite
-	 *
-	 * @return value of composite
-	 */
+	
 	@Override
-	public Composite getComposite() {
+	public Control getControl() {
 		return composite;
 	}

Review comment:
       same

##########
File path: ui/src/main/java/org/apache/hop/ui/hopgui/perspective/dataorch/HopDataOrchestrationPerspective.java
##########
@@ -657,38 +658,10 @@ public void setHopGui( HopGui hopGui ) {
     this.hopGui = hopGui;
   }
 
-  /**
-   * Gets parent
-   *
-   * @return value of parent
-   */
-  public Composite getParent() {
-    return parent;
-  }
-
-  /**
-   * @param parent The parent to set
-   */
-  public void setParent( Composite parent ) {
-    this.parent = parent;
-  }
-
-  /**
-   * Gets composite
-   *
-   * @return value of composite
-   */
-  @Override public Composite getComposite() {
+  @Override public Control getControl() {
     return composite;
   }

Review comment:
       This returns a composite




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org