You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/09 03:19:06 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1407: HDDS-4158. Provide a class type for Java based configuration
maobaolong opened a new pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
## What changes were proposed in this pull request?
Provide a class type for Java based configuration
## What is the link to the Apache JIRA
HDDS-4158
## How was this patch tested?
The related unit test can prove this work as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407#discussion_r496629283
##########
File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/SimpleConfiguration.java
##########
@@ -93,4 +98,12 @@ public int getPort() {
public long getWaitTime() {
return waitTime;
}
+
+ public Class<? extends Object> getMyClass() {
Review comment:
Nit: this can be simplified to:
```suggestion
public Class<?> getMyClass() {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407#issuecomment-690017443
@adoroszlai Please take a look at this PR, it will help us to use the `Java based configuration` conveniently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407#issuecomment-712249238
Thanks @maobaolong for the improvement and @elek for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407#issuecomment-709296180
Thank @elek for trigger ci checks for me, now it getting green, could you please to merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1407: HDDS-4158. Provide a class type for Java based configuration
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1407:
URL: https://github.com/apache/hadoop-ozone/pull/1407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org