Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

["basil (via GitHub)" <gi...@apache.org>]

basil commented on code in PR #202:
URL: https://github.com/apache/maven-release/pull/202#discussion_r1672787787


##########
maven-release-manager/src/test/resources/projects/rewrite-for-release/pom-with-parent-and-cifriendly-expressions/expected-pom.xml:
##########
@@ -31,6 +31,8 @@
 
   <properties>
     <revision>1.0</revision>
+    <sha1>.123</sha1>
+    <changelist></changelist>

Review Comment:
   I think it would be nice if this PR would instead produce `<changelist />`, as that is the coding style used in Maven's own POM (which has, e.g. `<relativePath />`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org