You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/02 01:56:00 UTC
[jira] [Work logged] (BEAM-11424) [Website revamp] Development of
Contribution Guide page
[ https://issues.apache.org/jira/browse/BEAM-11424?focusedWorklogId=545731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545731 ]
ASF GitHub Bot logged work on BEAM-11424:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/21 01:55
Start Date: 02/Feb/21 01:55
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request #13565:
URL: https://github.com/apache/beam/pull/13565#discussion_r568261897
##########
File path: website/www/site/content/en/blog/adding-data-sources-to-sql.md
##########
@@ -81,19 +81,19 @@ The `TableProvider` classes are under
Our table provider looks like this:
-{{< highlight java >}}
+{{< highlight language="java" >}}
@AutoService(TableProvider.class)
public class GenerateSequenceTableProvider extends InMemoryMetaTableProvider {
- @Override
- public String getTableType() {
- return "sequence";
- }
+@Override
+public String getTableType() {
+return "sequence";
+}
- @Override
- public BeamSqlTable buildBeamSqlTable(Table table) {
- return new GenerateSequenceTable(table);
- }
+@Override
+public BeamSqlTable buildBeamSqlTable(Table table) {
+return new GenerateSequenceTable(table);
+}
Review comment:
I don't think we should be making changes to a blog post's contents. It looks like you've made changes to a lot of blog posts to remove leading whitespace in code snippets.
Are these changes something you did while you were experimenting? Can they be reverted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 545731)
Time Spent: 5.5h (was: 5h 20m)
> [Website revamp] Development of Contribution Guide page
> -------------------------------------------------------
>
> Key: BEAM-11424
> URL: https://issues.apache.org/jira/browse/BEAM-11424
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Agnieszka Sell
> Assignee: Jakub Sadowski
> Priority: P2
> Labels: website-revamp-2020, website-revamp-sprint-9
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)