You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:42:10 UTC

[GitHub] [pulsar-client-python] nodece commented on a diff in pull request #15: Support auth param string for Basic authentication

nodece commented on code in PR #15:
URL: https://github.com/apache/pulsar-client-python/pull/15#discussion_r994739602


##########
pulsar/__init__.py:
##########
@@ -347,18 +347,32 @@ class AuthenticationBasic(Authentication):
     """
     Basic Authentication implementation
     """
-    def __init__(self, username, password):
+    def __init__(self, username=None, password=None, auth_params_string=None):

Review Comment:
   I agreed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org