[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #36591: GH-36590: [Docs] Support Pydata Sphinx Theme 0.13

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #36591:
URL: https://github.com/apache/arrow/pull/36591#discussion_r1258421448


##########
docs/source/conf.py:
##########
@@ -288,16 +288,34 @@
 # further.  For a list of options available for each theme, see the
 # documentation.
 #
+
 html_theme_options = {
-    "show_toc_level": 2,

Review Comment:
   This could be kept?



##########
docs/source/_static/theme_overrides.css:
##########
@@ -50,14 +49,13 @@ code {
 a.navbar-brand img {
   height: auto;
   width: auto;
-  max-height: 15vh;
+  max-height: var(--pst-header-height);
   max-width: 100%;
 }

Review Comment:
   Probably this whole section (and the `.navbar-brand` above) can be removed, as it was previously only needed because we put this section in the sidebar instead of navbar. Now the logo is in the normal location as the theme expects, so I would assume no custom css is needed (at least to start with)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org