You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 13:41:02 UTC
[GitHub] [arrow-datafusion] parthsarthy opened a new pull request #411: Add some padding around the logo
parthsarthy opened a new pull request #411:
URL: https://github.com/apache/arrow-datafusion/pull/411
# Which issue does this PR close?
Related to #67
# Rationale for this change
Adds spacing around the logo for dark mode
**Before**
<img width="530" alt="Screenshot 2021-05-24 at 14 25 31" src="https://user-images.githubusercontent.com/5324682/119354717-4bf1f400-bc9c-11eb-833a-357109c2c90c.png">
**After**
<img width="534" alt="Screenshot 2021-05-24 at 14 25 20" src="https://user-images.githubusercontent.com/5324682/119354722-4dbbb780-bc9c-11eb-9bc1-3c75f6d6b486.png">
# What changes are included in this PR?
Adds spacing around the logo
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #411: Add some padding around the logo
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #411:
URL: https://github.com/apache/arrow-datafusion/pull/411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #411: Add some padding around the logo
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #411:
URL: https://github.com/apache/arrow-datafusion/pull/411#issuecomment-847088864
Thank you @parthsarthy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #411: Add some padding around the logo
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #411:
URL: https://github.com/apache/arrow-datafusion/pull/411#issuecomment-847084350
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#411](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d9f076f) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/0aea0df448b6df3ec7cb489a5ed49f4840bbb551?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0aea0df) will **increase** coverage by `0.01%`.
> The diff coverage is `72.56%`.
> :exclamation: Current head d9f076f differs from pull request most recent head 28a1723. Consider uploading reports for the commit 28a1723 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 74.84% 74.86% +0.01%
==========================================
Files 146 146
Lines 24382 24495 +113
==========================================
+ Hits 18249 18338 +89
- Misses 6133 6157 +24
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/411/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc2NhbGFyLnJz) | `58.66% <72.56%> (+4.95%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0aea0df...28a1723](https://codecov.io/gh/apache/arrow-datafusion/pull/411?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org