You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:14:17 UTC
[GitHub] [doris] spaces-X opened a new pull request, #11204: [fix](be): fix stack overflow in unhex function
spaces-X opened a new pull request, #11204:
URL: https://github.com/apache/doris/pull/11204
# Proposed changes
Fix be crushed due to stack overflow in the `unhex` function.
Located and fixed by @924060929
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11204: [fix](be): fix stack overflow in unhex function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11204:
URL: https://github.com/apache/doris/pull/11204#issuecomment-1195341320
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X commented on pull request #11204: [fix](be): fix stack overflow in unhex function
Posted by GitBox <gi...@apache.org>.
spaces-X commented on PR #11204:
URL: https://github.com/apache/doris/pull/11204#issuecomment-1196431095
@dataroaring @yiguolei Fix an ut error and it has been passed in my local env. Please review again thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11204: [fix](be): fix stack overflow in unhex function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11204:
URL: https://github.com/apache/doris/pull/11204#issuecomment-1195341351
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X commented on a diff in pull request #11204: [fix](be): fix stack overflow in unhex function
Posted by GitBox <gi...@apache.org>.
spaces-X commented on code in PR #11204:
URL: https://github.com/apache/doris/pull/11204#discussion_r930779540
##########
be/src/udf/udf.h:
##########
@@ -255,7 +256,8 @@ class FunctionContext {
// Create a test FunctionContext object. The caller is responsible for calling delete
// on it. This context has additional debugging validation enabled.
- static FunctionContext* create_test_context();
+ // And the default value of mem_pool is nullprt.
Review Comment:
```suggestion
// And the default value of mem_pool is nullptr.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11204: [fix](be): fix stack overflow in unhex function
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11204:
URL: https://github.com/apache/doris/pull/11204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org