You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/28 16:29:00 UTC

[jira] [Commented] (FLINK-9451) End-to-end test: Scala Quickstarts

    [ https://issues.apache.org/jira/browse/FLINK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492813#comment-16492813 ] 

ASF GitHub Bot commented on FLINK-9451:
---------------------------------------

GitHub user medcv opened a pull request:

    https://github.com/apache/flink/pull/6089

    [FLINK-9451]End-to-end test: Scala Quickstarts

    ## What is the purpose of the change
    
    Added an end-to-end test which verifies Flink's quickstarts scala. It does the following:
    
    - create a new Flink project using the quickstarts scala archetype
    - add a new Flink kafka connector dependency to the pom.xml 
    - run mvn clean package
    - verify that no core dependencies are contained in the jar file
    - Run the program
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/medcv/flink FLINK-9451

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6089
    
----
commit 26f5948eff55fd54dbffc3125e0599479bee3bbe
Author: Yadan.JS <y_...@...>
Date:   2018-05-28T16:16:40Z

    [FLINK-9451]End-to-end test: Scala Quickstarts

----


> End-to-end test: Scala Quickstarts
> ----------------------------------
>
>                 Key: FLINK-9451
>                 URL: https://issues.apache.org/jira/browse/FLINK-9451
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Quickstarts
>    Affects Versions: 1.5.0, 1.4.1, 1.4.2
>            Reporter: Yazdan Shirvany
>            Assignee: Yazdan Shirvany
>            Priority: Blocker
>
> We could add an end-to-end test which verifies Flink's quickstarts scala. It should do the following:
>  # create a new Flink project using the quickstarts archetype
>  # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or library)
>  # run {{mvn clean package -Pbuild-jar}}
>  # verify that no core dependencies are contained in the jar file
>  # Run the program



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)