You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/13 11:31:43 UTC
[GitHub] [iotdb] irvine0109 opened a new pull request, #5901: [IoTDB-3178] Refactor integration test for the new cluster
irvine0109 opened a new pull request, #5901:
URL: https://github.com/apache/iotdb/pull/5901
New feature:
- Adapt for the new cluster.
- Add the log record for every node in the cluster integration test.
- Parallel to do cluster integration test.
TODO:
- [ ] Add the whitelist for IT files in this module.
- [ ] The log record files can be downloaded.
- [ ] To integrate with GitHub action.
- [ ] Finish the README and user document.
Use command below to do test:
`mvn spotless:apply clean verify -Dsession.test.skip=true -Diotdb.test.skip=true -Dcluster.test.skip=true -Dtsfile.test.skip=true -Dcommons.test.skip=true -Dconfignode.test.skip=true -pl integration-new -am -PNewCluster`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r877202590
##########
.github/workflows/cluster-new.yml:
##########
@@ -1,14 +1,16 @@
-name: Cluster Test
+name: New Cluster IT
on:
push:
branches:
- test_cluster
+ - IOTDB-3178*
paths-ignore:
- 'docs/**'
pull_request:
branches:
- test_cluster
+ #- master
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r874291346
##########
.github/workflows/cluster-new.yml:
##########
@@ -49,4 +51,12 @@ jobs:
shell: bash
# we do not compile client-cpp for saving time, it is tested in client.yml
# we can skip influxdb-protocol because it has been tested separately in influxdb-protocol.yml
- run: mvn -B clean verify -Dsession.test.skip=true -Diotdb.test.skip=true -Dcluster.test.skip=true -Dtsfile.test.skip=true -pl integration -am -PCluster
+ run: mvn -B clean verify -Dsession.test.skip=true -Diotdb.test.skip=true -Dcluster.test.skip=true -Dtsfile.test.skip=true -Dcommons.test.skip=true -Dconfignode.test.skip=true -pl integration-new -am -PNewCluster
+ - name: Upload Artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: cluster-log
+ path: integration-new/target/cluster-logs
+ retention-days: 1
Review Comment:
Yes. This upload step only happens after the previous IT step fails.
You can download the zip file of log files at [this URL](https://github.com/irvine0109/iotdb/actions/runs/2333221271). The Artifacts part is at the bottom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r874285449
##########
.github/workflows/cluster-new.yml:
##########
@@ -49,4 +51,12 @@ jobs:
shell: bash
# we do not compile client-cpp for saving time, it is tested in client.yml
# we can skip influxdb-protocol because it has been tested separately in influxdb-protocol.yml
- run: mvn -B clean verify -Dsession.test.skip=true -Diotdb.test.skip=true -Dcluster.test.skip=true -Dtsfile.test.skip=true -pl integration -am -PCluster
+ run: mvn -B clean verify -Dsession.test.skip=true -Diotdb.test.skip=true -Dcluster.test.skip=true -Dtsfile.test.skip=true -Dcommons.test.skip=true -Dconfignode.test.skip=true -pl integration-new -am -PNewCluster
+ - name: Upload Artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: cluster-log
+ path: integration-new/target/cluster-logs
+ retention-days: 1
Review Comment:
This will upload the test log files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r877202052
##########
.github/workflows/cluster-new.yml:
##########
@@ -1,14 +1,16 @@
-name: Cluster Test
+name: New Cluster IT
on:
push:
branches:
- test_cluster
+ - IOTDB-3178*
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#issuecomment-1126848616
> Hi, the picture could be put into https://github.com/apache/iotdb-bin-resources.
Thanks, I will put the pictures into the new place.
These pictures are all out of date. The README and user document will be updated later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r874285728
##########
confignode/pom.xml:
##########
@@ -50,11 +50,6 @@
<artifactId>iotdb-server</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.iotdb</groupId>
- <artifactId>iotdb-procedure</artifactId>
- <version>${project.version}</version>
- </dependency>
Review Comment:
Why remove procedure here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r877197579
##########
.github/workflows/cluster-new.yml:
##########
@@ -1,14 +1,16 @@
-name: Cluster Test
+name: New Cluster IT
on:
push:
branches:
- test_cluster
+ - IOTDB-3178*
paths-ignore:
- 'docs/**'
pull_request:
branches:
- test_cluster
+ #- master
Review Comment:
```suggestion
- master
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#issuecomment-1126862134
@irvine0109 Hi, Haonan should already fixed the pictures~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #5901:
URL: https://github.com/apache/iotdb/pull/5901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r877197263
##########
.github/workflows/cluster-new.yml:
##########
@@ -1,14 +1,16 @@
-name: Cluster Test
+name: New Cluster IT
on:
push:
branches:
- test_cluster
+ - IOTDB-3178*
Review Comment:
```suggestion
- master
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r873100594
##########
integration-new/pom.xml:
##########
@@ -0,0 +1,314 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>iotdb-parent</artifactId>
+ <groupId>org.apache.iotdb</groupId>
+ <version>0.14.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+ <artifactId>integration-new</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iotdb</groupId>
+ <artifactId>iotdb-server</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iotdb</groupId>
+ <artifactId>iotdb-server</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
Review Comment:
This file is a copy of the integration module. And line 37-43 is introduced by [this commit](https://github.com/apache/iotdb/commit/3dca44a4eab975aa8e0ddeb31067761f748078ba). I don't understand this part's meaning, and I will figure this out with the author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r872967670
##########
integration-new/pom.xml:
##########
@@ -0,0 +1,314 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>iotdb-parent</artifactId>
+ <groupId>org.apache.iotdb</groupId>
+ <version>0.14.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+ <artifactId>integration-new</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iotdb</groupId>
+ <artifactId>iotdb-server</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iotdb</groupId>
+ <artifactId>iotdb-server</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Duplicated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] irvine0109 commented on a diff in pull request #5901: [IOTDB-3178] Refactor integration test for the new cluster
Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #5901:
URL: https://github.com/apache/iotdb/pull/5901#discussion_r874289644
##########
confignode/pom.xml:
##########
@@ -50,11 +50,6 @@
<artifactId>iotdb-server</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.iotdb</groupId>
- <artifactId>iotdb-procedure</artifactId>
- <version>${project.version}</version>
- </dependency>
Review Comment:
The procedure module is removed in [this commit](https://github.com/apache/iotdb/commit/fa06bbb43243fef53fa07b82dc848cd3684e09b4). IDE reported an error message about this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org