You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/28 01:09:33 UTC

[GitHub] [submarine] FatalLin commented on a change in pull request #848: SUBMARINE-1139. add internal api for status sync

FatalLin commented on a change in pull request #848:
URL: https://github.com/apache/submarine/pull/848#discussion_r775685276



##########
File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
##########
@@ -44,10 +44,11 @@
   /**
    * Create experiment with spec
    * @param spec experiment spec
+   * @param id experimentId 
    * @return object
    * @throws SubmarineRuntimeException running error
    */
-  Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException;
+  Experiment createExperiment(ExperimentSpec spec, String experimentId) throws SubmarineRuntimeException;

Review comment:
       oh i haven't notice before, will recover it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org