[GitHub] [mahout] andrewmusselman commented on a diff in pull request #424: MAHOUT-2155 Add Javadocs for RandomWrapper

["andrewmusselman (via GitHub)" <gi...@apache.org>]

andrewmusselman commented on code in PR #424:
URL: https://github.com/apache/mahout/pull/424#discussion_r1106454856


##########
core/src/main/java/org/apache/mahout/common/RandomWrapper.java:
##########
@@ -47,14 +65,21 @@ public void setSeed(long seed) {
     }
   }
 
+    /**
+     * Sets the seed to a standard value that can be used to ensure that tests are deterministic.
+     */
   void resetToTestSeed() {
     setSeed(STANDARD_SEED);
   }
 
+    /**
+     * @return the delegate random number generator.
+     */
   public RandomGenerator getRandomGenerator() {
     return random;
   }
 
+

Review Comment:
   Do we need this extra newline?



##########
core/src/main/java/org/apache/mahout/common/RandomWrapper.java:
##########
@@ -47,14 +65,21 @@ public void setSeed(long seed) {
     }
   }
 
+    /**
+     * Sets the seed to a standard value that can be used to ensure that tests are deterministic.
+     */
   void resetToTestSeed() {
     setSeed(STANDARD_SEED);
   }
 
+    /**
+     * @return the delegate random number generator.
+     */
   public RandomGenerator getRandomGenerator() {
     return random;
   }
 
+
   @Override
   protected int next(int bits) {

Review Comment:
   While we're at it can we add a comment block to this method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org