You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/07 13:31:57 UTC
[GitHub] [superset] trepmag opened a new pull request #16619: fix: dashboard standalone class not added when parameter set
trepmag opened a new pull request #16619:
URL: https://github.com/apache/superset/pull/16619
### SUMMARY
When the `standalone` url parameter is set the dashboard html body class should be set to `standalone`.
This was integrated in issue #6811.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16619: fix: dashboard standalone class not added when parameter set
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16619:
URL: https://github.com/apache/superset/pull/16619#discussion_r757317529
##########
File path: superset/views/core.py
##########
@@ -1912,6 +1914,7 @@ def dashboard(
bootstrap_data=json.dumps(
bootstrap_data, default=utils.pessimistic_json_iso_dttm_ser
),
+ standalone_mode=standalone_mode,
Review comment:
nit: since `standalone_mode` isn't being reused, I'd prefer to place it inline here, like
```python
standalone_mode=ReservedUrlParameters.is_standalone_mode(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org