You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2017/12/07 12:26:13 UTC

[GitHub] carbondata pull request #1617: [CARBONDATA-1870] Add dictionary path support...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1617#discussion_r155507173
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/DictionaryColumnUniqueIdentifier.java ---
    @@ -79,21 +82,26 @@ public DictionaryColumnUniqueIdentifier(AbsoluteTableIdentifier absoluteTableIde
         this.dataType = dataType;
         if (null != carbonTablePath) {
           this.carbonTablePath = carbonTablePath;
    +    } else {
    +      this.carbonTablePath = CarbonStorePath.getCarbonTablePath(absoluteTableIdentifier);
    --- End diff --
    
    dictionaryLocation needs to be initialized here also


---