You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/08/01 18:31:36 UTC
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
-----------------------------------------------------------
(Updated Aug. 1, 2017, 6:31 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Changes
-------
Fix broken test
Repository: geode
Description
-------
GEODE-3313: Test utility supports building jar files with multiple classes
Diffs (updated)
-----
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCodeTest.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java PRE-CREATION
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java PRE-CREATION
Diff: https://reviews.apache.org/r/61166/diff/6/
Changes: https://reviews.apache.org/r/61166/diff/5-6/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181921
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Aug. 1, 2017, 6:31 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 6:31 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3313: Test utility supports building jar files with multiple classes
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCodeTest.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61166/diff/6/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Emily Yeh <ey...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review182126
-----------------------------------------------------------
Ship it!
Looks good! +1
geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java
Lines 22 (patched)
<https://reviews.apache.org/r/61166/#comment257978>
Always really impressed by your regexes!
geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java
Lines 108 (patched)
<https://reviews.apache.org/r/61166/#comment257977>
Super nitpick: there's just one extra line here that could be deleted.
- Emily Yeh
On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 5:54 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3313: Test utility supports building jar files with multiple classes
>
>
> Diffs
> -----
>
> geode-junit/build.gradle e47095f
> geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61166/diff/7/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
-----------------------------------------------------------
(Updated Aug. 8, 2017, 5:14 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Changes
-------
Improve error handling and remove unused test resources.
Repository: geode
Description
-------
GEODE-3313: Test utility supports building jar files with multiple classes
Diffs (updated)
-----
geode-junit/build.gradle e47095f
geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractClass.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteClass.java PRE-CREATION
Diff: https://reviews.apache.org/r/61166/diff/8/
Changes: https://reviews.apache.org/r/61166/diff/7-8/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
-----------------------------------------------------------
(Updated Aug. 2, 2017, 5:54 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Changes
-------
Moved classes into geode-junit
Repository: geode
Description
-------
GEODE-3313: Test utility supports building jar files with multiple classes
Diffs (updated)
-----
geode-junit/build.gradle e47095f
geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java PRE-CREATION
geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java PRE-CREATION
geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java PRE-CREATION
Diff: https://reviews.apache.org/r/61166/diff/7/
Changes: https://reviews.apache.org/r/61166/diff/6-7/
Testing
-------
Precheckin running
Thanks,
Jared Stewart
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Jared Stewart <js...@pivotal.io>.
> On Aug. 2, 2017, 4:44 p.m., Kirk Lund wrote:
> > You might consider hoisting these classes out of management pkg and into org.apache.geode.test.something. Maybe even move them to geode-test module. They seem very useful even outside of geode-core and management.
> >
> > Ship It!
Great suggestion, this also lets me separate the test utilities from the tests that test the test utilities. (That was a tongue twister..)
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181999
-----------------------------------------------------------
On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 5:54 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3313: Test utility supports building jar files with multiple classes
>
>
> Diffs
> -----
>
> geode-junit/build.gradle e47095f
> geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java PRE-CREATION
> geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java PRE-CREATION
> geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java PRE-CREATION
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61166/diff/7/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 61166: GEODE-3313: Test utility supports building
jar files with multiple classes
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181999
-----------------------------------------------------------
Ship it!
You might consider hoisting these classes out of management pkg and into org.apache.geode.test.something. Maybe even move them to geode-test module. They seem very useful even outside of geode-core and management.
Ship It!
- Kirk Lund
On Aug. 1, 2017, 6:31 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 6:31 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3313: Test utility supports building jar files with multiple classes
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCodeTest.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java PRE-CREATION
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61166/diff/6/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>