You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by pa...@apache.org on 2025/05/07 18:04:30 UTC

(felix-dev) branch master updated (d8bce3a111 -> 6858ded925)

This is an automated email from the ASF dual-hosted git repository.

paulrutter pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git


    from d8bce3a111 Merge pull request #417 from apache/maintenance/FELIX-6775-Jetty-12.0.20
     add 24cb75e32c FELIX-6774 `org.apache.felix.http.jetty.maxFormSize` not enforced - Add integration test for demonstrating the issue
     add b7030c6e72 Merge branch 'master' into maintenance/FELIX-6774-IT-demonstrating-the-issue
     add ce1b5afef1 FELIX-6774 `org.apache.felix.http.jetty.maxFormSize` not enforced - Fix test; when calling getParameter("key"), an IOException is thrown (leading to a HTTP 500). This is as expected
     new 6858ded925 Merge pull request #415 from apache/maintenance/FELIX-6774-IT-demonstrating-the-issue

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ...eModeDefaultIT.java => JettyMaxFormSizeIT.java} | 44 +++++++++++++++-------
 .../jetty/it/JettyUriComplianceModeDefaultIT.java  |  2 +
 .../jetty/it/JettyUriComplianceModeLegacyIT.java   |  2 +
 .../felix/http/jetty/it/JettyVirtualThreadsIT.java |  2 +
 4 files changed, 36 insertions(+), 14 deletions(-)
 copy http/jetty12/src/test/java/org/apache/felix/http/jetty/it/{JettyUriComplianceModeDefaultIT.java => JettyMaxFormSizeIT.java} (72%)


(felix-dev) 01/01: Merge pull request #415 from apache/maintenance/FELIX-6774-IT-demonstrating-the-issue

Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

paulrutter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git

commit 6858ded9250434153971e1122202f40c73a4bcf1
Merge: d8bce3a111 ce1b5afef1
Author: Paul <pa...@blueconic.com>
AuthorDate: Wed May 7 20:04:25 2025 +0200

    Merge pull request #415 from apache/maintenance/FELIX-6774-IT-demonstrating-the-issue
    
    FELIX-6774 `org.apache.felix.http.jetty.maxFormSize` not enforced: Unit test to demonstrate issue
    
    - Merging the IT, which now asserts the correct behavior of `org.apache.felix.http.jetty.maxFormSize`.
    
    context.setMaxFormContentSize(this.config.getMaxFormSize());
    
    Only affects request.getParameter(), but does not apply to any other places. It does not affect a multipart file upload for example.
    
    For that purpose, one can add the SizeLimitHandler, which affects all incoming requests (including form data). It just operates on a different level.
    
    In that respect, this is not a bug, but a change request.

 ...eModeDefaultIT.java => JettyMaxFormSizeIT.java} | 44 +++++++++++++++-------
 .../jetty/it/JettyUriComplianceModeDefaultIT.java  |  2 +
 .../jetty/it/JettyUriComplianceModeLegacyIT.java   |  2 +
 .../felix/http/jetty/it/JettyVirtualThreadsIT.java |  2 +
 4 files changed, 36 insertions(+), 14 deletions(-)