You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/03/19 17:48:14 UTC
[Bug 121917] New: Crash when editing a drawing object anchored to
header paragraph
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Bug ID: 121917
Issue Type: DEFECT
Summary: Crash when editing a drawing object anchored to header
paragraph
Classification: Application
Product: Writer
Version: AOO400-dev
Hardware: PC
OS: Windows 7
Status: UNCONFIRMED
Severity: major
Priority: P3
Component: editing
Assignee: issues@openoffice.apache.org
Reporter: rb.henschel@t-online.de
CC: issues@openoffice.apache.org
Created attachment 80434
--> https://issues.apache.org/ooo/attachment.cgi?id=80434&action=edit
document with text box anchored to header
Open the attached document.
Goto page 2
Right-click on the text box A.
Choose "Position & Size" from its context menu.
Crash.
The text box is anchored to the paragraph in the header. Therefore the drawing
object on the second page is not the original one, but a clone, which is
generated for header repeating. If it is not intended, that the drawing object
can be edit from such position, then the drawing object should not be
selectable there. If the object should be editable at that position--like other
header content--then it should not crash.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked on mac at r1499347, all is well. Indeed crashes on Win7 also on
r1499347. Does not crash on current trunk build. Maybe snapshot build was not
up-to-date? Controlling checkin, also no automatic note added to this task...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #22 from Armin Le Grand <Ar...@me.com> ---
ALG: Comitted in trunk and branch AOO400, cui needs rebuild but is compatible.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #11 from fanyuzhen@gmail.com ---
I still reproduce the crash with revision 1499347
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #12 from Regina Henschel <rb...@t-online.de> ---
Still crashes in non-pro build of r1501409. The crash is triggered be calling
the dialog, not by setting width or height in the sidebar.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS|Windows 7 |All
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, thanks, Regina. Found commit r1494127, also changes are in trunk,
verified. Getting the buildbot win build r1501409, checking...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
brinzing <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oliver.brinzing@gmx.de
--- Comment #2 from brinzing <ol...@gmx.de> ---
crash confirmed in oo32
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked that my changes do the fix, preparing checkin.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #23 from Armin Le Grand <Ar...@me.com> ---
ALG: Added #122720# to clean this up on trunk in general
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: UhOh. GetPlusHdl should not even be called, it's only called due to
casting a SdrObject to SdrTextObj which is in this case a SwDrawVirtObj. At
that object HasText is called, but lands on GetPlusHdl (jumping over the wrong
virtual table). Two steps:
- Change the cast to dynamic_cast and adapt code
- Take the chance and make methods at SwDrawVirtObj more safe.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #16 from Armin Le Grand <Ar...@me.com> ---
ALG: Also crashes with buildbot build r1501409, need to make a clean, fresh
windows build to check (current trunk does not crash)...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.0.0_release_blocker? |4.0.0_release_blocker+
--- Comment #10 from jsc@apache.org ---
grant showstopper flag to get clear status, already fixed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |awf.aoo@googlemail.com
--- Comment #3 from Andre <aw...@googlemail.com> ---
Crash takes place in SwDrawVirtObj::GetPlusHdl() because a NULL pointer is
dereferenced.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #19 from Armin Le Grand <Ar...@me.com> ---
ALG: Adapted three places with bad/dangerous casts in cui, needed a pro build
to test if this helps. Works as expected, indeed this causes the trouble. Did
some more deep tests with debugger and manipulating that 2nd objects, looks
good. Preparing commit...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #24 from fanyuzhen@gmail.com ---
I do not see the crash in RC, Rev. 1502185 on Win 7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #20 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1502162 into trunk:
i121917 secure SdrTextObj casts in cui
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: Taking a look...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Made a short check with Symphony, from the code it should also crash
there. It does.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
ALG: Setting to fixed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #21 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1502164 into branches/AOO400:
i121917 secure SdrTextObj casts in cui
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #18 from Armin Le Grand <Ar...@me.com> ---
ALG: Found another place in cui where a SdrObject is casted the old way to a
SdrTextObj because the SdrObjKind is a text type; this is not safe as long as
we have SdrVirtObjs in Writer. In this case, the wrong cast leads to a wrong
function call (SwDrawVirtObj::GetPlusHdl instead of HasText). Other system
compilers somehow survive that, as the win compiler does in non-pro build.
Anyways, it's an error. Checking with a pro-build if this is the error.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fanyuzhen@gmail.com
Flags| |4.0.0_release_blocker?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #14 from Regina Henschel <rb...@t-online.de> ---
My build is from a fresh clone (~18h ago) of trunk, and it crashes.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |crash
Status|UNCONFIRMED |CONFIRMED
CC| |arielch@apache.org
Version|AOO400-dev |AOO 3.4.1
Ever confirmed|0 |1
--- Comment #1 from Ariel Constenla-Haile <ar...@apache.org> ---
It crashes in 3.4.1, but also 3.2.1-OOO320_m18-9502 and
3.4.0-BETA-OOO340_m0-9583
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
4.0.0_release_blocker granted: [Bug 121917] Crash when editing a
drawing object anchored to header paragraph
Posted by bu...@apache.org.
jsc@apache.org has granted fanyuzhen@gmail.com's request for
4.0.0_release_blocker:
Bug 121917: Crash when editing a drawing object anchored to header paragraph
https://issues.apache.org/ooo/show_bug.cgi?id=121917
------- Additional Comments from jsc@apache.org
grant showstopper flag to get clear status, already fixed
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #17 from Armin Le Grand <Ar...@me.com> ---
ALG: Re-checked: Mac and Linux are okay.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 121917] Crash when editing a drawing object anchored to header
paragraph
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121917
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.