You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/20 12:11:49 UTC

[GitHub] [spark] maropu commented on pull request #32605: [WIP][SPARK-35446] Override getJDBCType in MySQLDialect to map FloatType to FLOAT

maropu commented on pull request #32605:
URL: https://github.com/apache/spark/pull/32605#issuecomment-845042955


   Thank you for the your contribution, @mariosmeim-db . Could you add tests in `MySQLIntegrationSuite`, too? Our test framework does not run the integration test now, so please run it on your env.
   
   Thank you for pining me, @HyukjinKwon. btw, is it better to run these integration tests in GA, too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org